On Tue, 9 Feb 2021 13:46:15 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed printing and narrowed the exception
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateT
> Fixes a mutability issue for `LocalDateTimeStringConverter` (and
> `LocalDateStringConverter`) where the chronology can change during the
> lifetime of the instance and cause an inconsistent state. The following
> changes were made:
>
> * The input is now formatted and parsed directly with th
On Tue, 9 Feb 2021 21:59:58 GMT, Jose Pereda wrote:
> This PR allows rendering Myanmar script correctly, following up on
> https://bugs.openjdk.java.net/browse/JDK-8223558.
It looks fine to me. Not sure whether there is a good way to have an automated
test, but as the fix is simple enough, we
On Tue, 9 Feb 2021 10:31:57 GMT, Jeanette Winzenburg
wrote:
>> My concern is about having a similar way of doing something. It would keep
>> the code uniform. We have been following the earlier pattern under a cleanup
>> task [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364).
>>
This PR allows rendering Myanmar script correctly, following up on
https://bugs.openjdk.java.net/browse/JDK-8223558.
-
Commit messages:
- Allow rendering Myanmar script correctly
Changes: https://git.openjdk.java.net/jfx/pull/399/files
Webrev: https://webrevs.openjdk.java.net/?rep
On Tue, 9 Feb 2021 20:43:08 GMT, John Hendrikx wrote:
>> hmm ... might appear convenient (in very controlled contexts) but looks like
>> a precondition violation: the sender of the change must not be null
>> (concededly not explicitly spec'ed but logically implied, IMO)
>>
>> so would tend to
> This is a PoC for performance testing.
>
> It contains commented out code in PopupWindow and ProgressIndicatorSkin and
> two tests are failing because of that.
>
> This code avoids registering two listeners (on Scene and on Window) for each
> and every Node to support the aforementioned cla
On Tue, 9 Feb 2021 10:31:57 GMT, Jeanette Winzenburg
wrote:
>> My concern is about having a similar way of doing something. It would keep
>> the code uniform. We have been following the earlier pattern under a cleanup
>> task [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364).
>>
On Fri, 5 Feb 2021 10:37:54 GMT, Jose Pereda wrote:
> Using a digitizer tablet with a pen that works with Windows or MacOS, it
> works fine on MacOS, but throws a RTE on Windows 10. On MacOS there are only
> MouseEvents, while on Windows there are both MouseEvents and TouchEvents
> mixed toget
On Sun, 7 Feb 2021 11:33:13 GMT, Pankaj Bansal wrote:
> JavaFX ignores the HiDPI scaling settings on Fedora 32 and Ubuntu 20.04.
>
> The scale detection in JavaFX assumes that the "scaling-factor" setting in
> "org.gnome.desktop.interface" has the correct Hi-DPI setting. But this not
> true fo
On Sun, 7 Feb 2021 11:33:13 GMT, Pankaj Bansal wrote:
> JavaFX ignores the HiDPI scaling settings on Fedora 32 and Ubuntu 20.04.
>
> The scale detection in JavaFX assumes that the "scaling-factor" setting in
> "org.gnome.desktop.interface" has the correct Hi-DPI setting. But this not
> true fo
JavaFX ignores the HiDPI scaling settings on Fedora 32 and Ubuntu 20.04.
The scale detection in JavaFX assumes that the "scaling-factor" setting in
"org.gnome.desktop.interface" has the correct Hi-DPI setting. But this not true
for some systems and "scaling-factor" has value of 0. JavaFX should
On Thu, 4 Feb 2021 20:01:10 GMT, Nir Lisker wrote:
> Fixes a mutability issue for `LocalDateTimeStringConverter` (and
> `LocalDateStringConverter`) where the chronology can change during the
> lifetime of the instance and cause an inconsistent state. The following
> changes were made:
>
> * T
On Thu, 4 Feb 2021 20:04:39 GMT, Nir Lisker wrote:
> The added test will look meaningless after the patch, since it's trying to
> force a change that can't happen anymore, and this can be confusing in the
> future. Does it still make sense to commit it? It's more of a demonstration
> of the bu
On Fri, 5 Feb 2021 10:37:54 GMT, Jose Pereda wrote:
> Using a digitizer tablet with a pen that works with Windows or MacOS, it
> works fine on MacOS, but throws a RTE on Windows 10. On MacOS there are only
> MouseEvents, while on Windows there are both MouseEvents and TouchEvents
> mixed toget
On Fri, 29 Jan 2021 00:05:57 GMT, Kevin Rushforth wrote:
> As indicated in the JBS bug, using a `PixelReader` to read a scaled image in
> HiDPI mode, for example an `@2x` image, to read more than one pixel will read
> data from the wrong location in the image, usually leading to an IOOBE.
>
>
On Fri, 29 Jan 2021 00:05:57 GMT, Kevin Rushforth wrote:
> As indicated in the JBS bug, using a `PixelReader` to read a scaled image in
> HiDPI mode, for example an `@2x` image, to read more than one pixel will read
> data from the wrong location in the image, usually leading to an IOOBE.
>
>
On Wed, 27 Jan 2021 13:31:45 GMT, Kevin Rushforth wrote:
> Prism implements a dirty region optimization, where in many cases, only part
> of the scene graph is re-rendered when something changes. In support of this,
> the `ViewPainter` class in the Quantum Toolkit keeps an array of node paths,
On Mon, 8 Feb 2021 13:42:52 GMT, Ambarish Rapte wrote:
>> Isn't it quite error prone to repeat this logic again (especially with all
>> the null cases), not to mention that you would need to test the code for the
>> initial case (with/without Scene, with/without Window), the "in use" case
>> a
19 matches
Mail list logo
