On Tue, 23 Mar 2021 07:53:03 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> fixed the names of some tests
>
> Marked as reviewed by arapte (Reviewer).
The CSR is now in
On Thu, 25 Mar 2021 11:44:21 GMT, Jeanette Winzenburg
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> good catch, yet another property that's not correctly updated on index change
> :)
>
> Quick questions:
> - what are the macroscopic effects (that is
On Wed, 3 Mar 2021 22:07:34 GMT, Alessadro Parisi
wrote:
> Can you also update the build script located in tools/scripts?
> Build fails on my system with `FAIL: WINSDK_DIR not defined`
I filed [JDK-8264219](https://bugs.openjdk.java.net/browse/JDK-8264219) to
track this. We don't use that
On Thu, 25 Mar 2021 22:08:36 GMT, Kevin Rushforth wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> Kevin Rushforth has updated the pull request incrementally with one
>
> Simple fix to add a missing closing bracket to `PickResult::toString`. This
> includes a unit test that fails without the fix and passes with the fix.
Kevin Rushforth has updated the pull request incrementally with one additional
commit since the last revision:
Address review feedback: fix
On Wed, 24 Mar 2021 22:00:03 GMT, Kevin Rushforth wrote:
>> I've written a command line utility that runs through all the keyboard
>> layouts available in macOS 11.2.3 and generates a report on how this PR
>> would change the Java key codes for each layout. I used it to spot-check the
>>
On Wed, 24 Mar 2021 19:50:11 GMT, John Neffenger wrote:
> Are all of them actually needed?
Just to follow up on that question, all of them are in fact downloaded during
the build, at least. I removed the Gradle directory `$HOME/.gradle` and ran the
build as follows. Then I compared the list
On Thu, 25 Mar 2021 16:30:30 GMT, Nir Lisker wrote:
>> Good catch. Test fails before and succeeds after the patch.
>
> By the way, this class could easily be converted to a `record`, and that
> would take care of the `toString` and other ceremonies. I'm not sure it's a
> backwards compatible
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
> expected by more accurately mapping from a Mac key code to a Java key code
> based on the user’s active keyboard layout (the existing code assumes a US
> QWERTY layout). The new code first identifies a set of Mac keys
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
> expected by more accurately mapping from a Mac key code to a Java key code
> based on the user’s active keyboard layout (the existing code assumes a US
> QWERTY layout). The new code first identifies a set of Mac keys
On Thu, 25 Mar 2021 13:21:24 GMT, Johan Vos wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> Good catch. Test fails before and succeeds after the patch.
By the way, this class
On Thu, 25 Mar 2021 14:15:47 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/input/MouseEventTest.java
>> line 139:
>>
>>> 137: case ']':
>>> 138: --bracketCount;
>>> 139: assertTrue("Too many
The email address used by the Skara tooling for all git commits, for the
Committer and for the Author if the Author has an associated OpenJDK ID,
is: `openjd...@openjdk.org`
-- Kevin
On 3/25/2021 7:03 AM, Nir Lisker wrote:
What are these email addresses?
On Thu, Mar 25, 2021 at 1:12 PM
On Thu, 25 Mar 2021 13:32:53 GMT, Nir Lisker wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/input/MouseEventTest.java
>
On Thu, 25 Mar 2021 13:52:20 GMT, Nir Lisker wrote:
>>>
>>>
>>> Can you list the other affected methods?
>>
>> at line 211 (in the changed skinBase)
>>
>> /**
>> * Subclasses can invoke this method to register that they want to
>> listen to
>> * property change events for the
What are these email addresses?
On Thu, Mar 25, 2021 at 1:12 PM Kevin Rushforth
wrote:
> Eventually the openjdk.org addresses will be live. I haven't heard a
> recent update on the timing for this. Until then, adding the email
> address as an unverified additional email address in your GitHub
On Thu, 25 Mar 2021 13:52:20 GMT, Nir Lisker wrote:
>>>
>>>
>>> Can you list the other affected methods?
>>
>> at line 211 (in the changed skinBase)
>>
>> /**
>> * Subclasses can invoke this method to register that they want to
>> listen to
>> * property change events for the
On Thu, 25 Mar 2021 13:29:44 GMT, Jeanette Winzenburg
wrote:
>> Can you list the other affected methods?
>
>>
>>
>> Can you list the other affected methods?
>
> at line 211 (in the changed skinBase)
>
> /**
> * Subclasses can invoke this method to register that they want to listen
>
On Thu, 25 Mar 2021 13:18:24 GMT, Nir Lisker wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> modules/javafx.graphics/src/main/java/javafx/scene/input/PickResult.java line
>
On Thu, 25 Mar 2021 12:29:38 GMT, Kevin Rushforth wrote:
> Simple fix to add a missing closing bracket to `PickResult::toString`. This
> includes a unit test that fails without the fix and passes with the fix.
modules/javafx.graphics/src/main/java/javafx/scene/input/PickResult.java line
204:
On Thu, 25 Mar 2021 13:14:45 GMT, Nir Lisker wrote:
>
>
> Can you list the other affected methods?
at line 211 (in the changed skinBase)
/**
* Subclasses can invoke this method to register that they want to listen to
* property change events for the given property. Registered
On Thu, 25 Mar 2021 12:29:38 GMT, Kevin Rushforth wrote:
> Simple fix to add a missing closing bracket to `PickResult::toString`. This
> includes a unit test that fails without the fix and passes with the fix.
Good catch. Test fails before and succeeds after the patch.
-
Marked
On Thu, 25 Mar 2021 11:25:18 GMT, Jeanette Winzenburg
wrote:
>> I reviewed only the public API methods.
>
> @nlisker thanks for the detailed doc review - I really like your suggestions,
> which I think are considerable improvements (I did part of it in the
> respective methods of the handler)
On Thu, 25 Mar 2021 12:02:25 GMT, Johan Vos wrote:
> Fix for JDK-8211362
>
> Compile javafx-iio native files with -f-visibiliy=hidden in order
> not to export the non-JNI symbols.
> Although this issue was about libjavafx_iio.so only (and not about
> libjavafx_iio.a), this PR allows fixing the
On Thu, 25 Mar 2021 12:02:25 GMT, Johan Vos wrote:
> Fix for JDK-8211362
>
> Compile javafx-iio native files with -f-visibiliy=hidden in order
> not to export the non-JNI symbols.
> Although this issue was about libjavafx_iio.so only (and not about
> libjavafx_iio.a), this PR allows fixing the
Simple fix to add a missing closing bracket to `PickResult::toString`. This
includes a unit test that fails without the fix and passes with the fix.
-
Commit messages:
- 8264162: PickResult.toString() is missing the closing square bracket
Changes:
Fix for JDK-8211362
Compile javafx-iio native files with -f-visibiliy=hidden in order
not to export the non-JNI symbols.
Although this issue was about libjavafx_iio.so only (and not about
libjavafx_iio.a), this PR allows fixing the static build as well.
For static builds, we also use ld -r to
On Wed, 24 Mar 2021 14:58:40 GMT, Florian Kirmaier
wrote:
> Fixing ListCell editing status is true, when index changes while editing.
good catch, yet another property that's not correctly updated on index change
:)
Quick questions:
- what are the macroscopic effects (that is in a running
On Wed, 24 Mar 2021 23:53:24 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> I reviewed only the public API methods.
@nlisker thanks
Eventually the openjdk.org addresses will be live. I haven't heard a
recent update on the timing for this. Until then, adding the email
address as an unverified additional email address in your GitHub profile
is the way to go.
-- Kevin
On 3/24/2021 9:37 PM, John Neffenger wrote:
I noticed
30 matches
Mail list logo
