Re: [jfx11u] RFR: 8240539: Upgrade gradle to version 6.3

2021-05-07 Thread Kevin Rushforth
On Fri, 7 May 2021 14:35:48 GMT, Ambarish Rapte wrote: > jfx11u uses gradle 5.3 for build, it needs to be upgraded to gradle 6.3 same > as jfx mainline. > This PR backports three fixes: > > 1. [JDK-8240539](https://bugs.openjdk.java.net/browse/JDK-8240539): Upgrade > gradle to version 6.3 >

Re: RFR: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-07 Thread Kevin Rushforth
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote: > As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip > bundle for javadoc offline processing. This missing entry is causing a build > failure on my system (which will soon propagate to our CI builds). One of the

RFR: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-07 Thread Kevin Rushforth
As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip bundle for javadoc offline processing. This missing entry is causing a build failure on my system (which will soon propagate to our CI builds). - Commit messages: - 8266757: Add entry for

Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3

2021-05-07 Thread Alessadro Parisi
On Fri, 7 May 2021 16:00:31 GMT, John Neffenger wrote: > I also think that we should remove it. If you read its history on the mailing > list, it was added to the repository in part as a solution to the `WINSDK_DIR > not defined` error. See the message ["Problems building openjfx"][1] on the

Re: RFR: JDK-8266396: Add VSCMD_DEBUG for solving WINSDK_DIR build error

2021-05-07 Thread John Neffenger
On Fri, 7 May 2021 13:42:49 GMT, Kevin Rushforth wrote: > It would be more convenient to ask the developer set `VSCMD_DEBUG` via an env > variable, rather than asking them to edit `win.gradle`. Thanks, Kevin. That is the most direct approach. I didn't document it that way for the following

Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3

2021-05-07 Thread John Neffenger
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see >

[jfx11u] RFR: 8240539: Upgrade gradle to version 6.3

2021-05-07 Thread Ambarish Rapte
jfx11u uses gradle 5.3 for build, it needs to be upgraded to gradle 6.3 same as jfx mainline. This PR backports three fixes: 1. [JDK-8240539](https://bugs.openjdk.java.net/browse/JDK-8240539): Upgrade gradle to version 6.3 2. [JDK-8232063](https://bugs.openjdk.java.net/browse/JDK-8232063):

Re: RFR: JDK-8266396: Add VSCMD_DEBUG for solving WINSDK_DIR build error

2021-05-07 Thread Kevin Rushforth
On Thu, 6 May 2021 20:39:11 GMT, John Neffenger wrote: > The Windows build calls a series of batch files to get the Visual Studio > paths and environment variables. The batch files are a black box: any > messages they print are discarded. If anything goes wrong, the only signs are > a vague

[jfx11u] RFR: 8204568: Relative CSS-Attributes don't work all time

2021-05-07 Thread Ambarish Rapte
Backport had a minor merge conflict of copyright year in the file `Labeled.java`. Rest of the changes are clean backport - Commit messages: - 8204568: Relative CSS-Attributes don't work all time Changes: https://git.openjdk.java.net/jfx11u/pull/6/files Webrev:

Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3

2021-05-07 Thread Johan Vos
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see >