RFR: 8267819: CoInitialize/CoUninitialize should be called on same thread

2021-05-26 Thread Alexander Matveev
JDK-8264737 introduced new code for audio device removal/arrival notifications which calls CoInitialize/CoUninitialize on separate threads. CoInitialize/CoUninitialize should be called on same thread, since initialization is per thread. Doing it on separate thread will result in unloading COM

Re: RFR: 8239138: StyleManager should use a BufferedInputStream

2021-05-26 Thread Ambarish Rapte
On Tue, 25 May 2021 12:36:54 GMT, Kevin Rushforth wrote: > I also prefer approach 3, since the body of the try/finally loop is then > identical to that of `NativeLibLoader::calculateCheckSum`. > Can you add a unit test to validate the checksum method? Hello Kevin, Thanks for the review, I have

Re: RFR: 8239138: StyleManager should use a BufferedInputStream [v2]

2021-05-26 Thread Ambarish Rapte
> `StyleManager.calculateCheckSum()` uses a raw InputStream as the input to a > `DigestInputStream` and reads one byte at a time. This is slower in > performance and should be changed, either to use `BufferedInputStream` or > read byte buffer of 4096 from the stream or use both. > > I have

RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.

2021-05-26 Thread Jose Pereda
This PR adds several resource bundles with High Contrast Scheme possible values for several locales. These values have been found by installing the required language packages on Windows 10 Pro 20H2 (build 19042.985), enabling Settings->High Contrast and finding the high contrast scheme values

Re: TimePicker

2021-05-26 Thread Davide Perini
Thank you for the answer, I appreciate it. I love Scene Builder and most of the things that you can include from elsewhere are not compatible with Scene Builder, this is the reason why I asked. In any case, long live JavaFX, I really enjoy using it. :) Thanks, Davide Il 26/05/2021 16:47,

Re: Unknown command v - for a list of valid commands use /help.

2021-05-26 Thread John Neffenger
On 5/25/21 2:26 PM, John Neffenger wrote:   Unknown command v - for a list of valid commands use /help. Just to follow up, there's a Skara bug report for this glitch: SKARA-755: Anything starting with a "/" is treated as a command https://bugs.openjdk.java.net/browse/SKARA-755 John

Re: RFR: 8267551: Support loading images from inline data-URIs [v13]

2021-05-26 Thread Michael Strauß
> This PR adds support for loading images from [inline data > URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely > supported by web browsers. This enables developers to package small images in > CSS files, rather than separately deploying the images alongside the CSS

Re: RFR: 8267551: Support loading images from inline data-URIs [v12]

2021-05-26 Thread Michael Strauß
> This PR adds support for loading images from [inline data > URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely > supported by web browsers. This enables developers to package small images in > CSS files, rather than separately deploying the images alongside the CSS

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v6]

2021-05-26 Thread Michael Strauß
On Wed, 26 May 2021 08:54:30 GMT, Jeanette Winzenburg wrote: > You mean `selectedIndices` not reporting truthfully? Yes, I meant `selectedIndices`. I'm not quite sure I understand what you're getting at. Are you suggesting to apply the changes reported by `selectedIndices` to our copy of the

Re: TimePicker

2021-05-26 Thread Tom Eugelink
Because OpenJFX does not have any? :-D Also if you want a stand alone datepicker instead of one attached to a text field you're out of luck. But there is nothing wrong with not having everything in one library, and including what you need from elsewhere. OpenJFX has enough work to do in other

Re: TimePicker

2021-05-26 Thread Davide Perini
But why I need JFXtras to have a timepicker? O_o Il 26/05/2021 16:14, Tom Eugelink ha scritto: JFXtras has one. https://github.com/JFXtras/jfxtras/blob/11/jfxtras-controls/src/main/java/jfxtras/scene/control/LocalTimePicker.java On 2021-05-26 15:03, Davide Perini wrote: Hi guys, is

Re: TimePicker

2021-05-26 Thread Tom Eugelink
JFXtras has one. https://github.com/JFXtras/jfxtras/blob/11/jfxtras-controls/src/main/java/jfxtras/scene/control/LocalTimePicker.java On 2021-05-26 15:03, Davide Perini wrote: Hi guys, is there a simple time picker in JavaFX? I only see DatePicker but not TimePicker. Thanks Davide

TimePicker

2021-05-26 Thread Davide Perini
Hi guys, is there a simple time picker in JavaFX? I only see DatePicker but not TimePicker. Thanks Davide

Integrated: 8267314: Loading some animated GIFs fails with ArrayIndexOutOfBoundsException: Index 4096 out of bounds for length 4096

2021-05-26 Thread Jose Pereda
On Fri, 21 May 2021 13:02:14 GMT, Jose Pereda wrote: > This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in > `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some > animated GIFs, to the maximum size of the tables used (4096). > > In some

Re: RFR: 8267314: Loading some animated GIFs fails with ArrayIndexOutOfBoundsException: Index 4096 out of bounds for length 4096 [v2]

2021-05-26 Thread Ambarish Rapte
On Fri, 21 May 2021 19:24:19 GMT, Jose Pereda wrote: >> This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in >> `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some >> animated GIFs, to the maximum size of the tables used (4096). >> >> In some

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v18]

2021-05-26 Thread Nir Lisker
> Added a SpotLight only to the D3D pipeline currently. > > ### API discussion points > > - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also > be a subclass of `PointLight` as it's a point light with direction and extra > factors. I saw that

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v17]

2021-05-26 Thread Nir Lisker
> Added a SpotLight only to the D3D pipeline currently. > > ### API discussion points > > - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also > be a subclass of `PointLight` as it's a point light with direction and extra > factors. I saw that

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

2021-05-26 Thread Nir Lisker
On Tue, 25 May 2021 14:40:28 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update documentation > > modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 171: > >> 169: *

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

2021-05-26 Thread Nir Lisker
On Tue, 25 May 2021 14:35:14 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update documentation > > modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 142: > >> 140: >>

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

2021-05-26 Thread Nir Lisker
On Tue, 25 May 2021 11:30:25 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update documentation > > modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 49: > >> 47: * >>

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v6]

2021-05-26 Thread Jeanette Winzenburg
On Sun, 23 May 2021 15:07:04 GMT, Michael Strauß wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/SelectedItemsReadOnlyObservableListTest.java >> line 120: >> >>> 118: assertEquals(change(replaced(0, range("foo"), range("bar"))), >>> changes.get(0));

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

2021-05-26 Thread Nir Lisker
On Tue, 25 May 2021 10:53:37 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update documentation > > modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGShape3D.java > line 167: >

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v6]

2021-05-26 Thread Jeanette Winzenburg
On Sun, 23 May 2021 15:03:21 GMT, Michael Strauß wrote: > This was my first thought, too. However, it doesn't work because > `SelectedItemsReadOnlyObservableList` doesn't truthfully report its changes, > so we can't simply replay its reported changes onto our copy of the items > list. You