On Mon, 21 Jun 2021 13:22:07 GMT, Jeanette Winzenburg
wrote:
>> Issue was that the cancel event carried the listView's editingIndex at the
>> time of firing the event - that's wrong nearly always (because the list's
>> editing state/index might have changed between start and cancel, f.i. due t
On Thu, 17 Jun 2021 14:52:53 GMT, Kevin Rushforth wrote:
> The JavaFX WebKit build fails with Xcode 12.5 + MacOS 11.3 SDK. This is
> related to the added C++20 support where some of the system include files now
> do `#include `. Because the macOS file system is case insensitive,
> it matches a
On Tue, 22 Jun 2021 06:28:49 GMT, Marius Hanl wrote:
>> This PR enables Tree- and TableCells to also check the row editability when
>> an edit should happen. With this a Tree- or TableCell is not editable, when
>> the row where the cell is in is not.
>>
>> While this PR fixes the problem descr
On Thu, 17 Jun 2021 14:52:53 GMT, Kevin Rushforth wrote:
> The JavaFX WebKit build fails with Xcode 12.5 + MacOS 11.3 SDK. This is
> related to the added C++20 support where some of the system include files now
> do `#include `. Because the macOS file system is case insensitive,
> it matches a
> This PR extends data URI support to allow stylesheets to be loaded from data
> URIs.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
simplified branch in StyleManager.loadStylesheetUnPrivileged
-
Changes:
- all: h
On Mon, 21 Jun 2021 15:04:26 GMT, Michael Strauß wrote:
>> An overloaded method with a new signature is still a new method that adds to
>> the public API, although in an easy to understand way. I agree that the same
>> argument could be made for it as for `loadBinary(URL)`, but if neither are
On Sat, 19 Jun 2021 13:46:54 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
On Tue, 22 Jun 2021 10:28:16 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated float constant registers
>
> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main.vert
> lin
This is a fix for the assertion error message that is printed to the console on
macOS 10.15 or later when an application calls `Platform.exit` while a `Stage`
is showing.
The root cause is a latent bug in the JavaFX glass code that was revealed by an
apparent change of behavior in macOS. A few
On Mon, 21 Jun 2021 13:22:07 GMT, Jeanette Winzenburg
wrote:
>> Issue was that the cancel event carried the listView's editingIndex at the
>> time of firing the event - that's wrong nearly always (because the list's
>> editing state/index might have changed between start and cancel, f.i. due t
When I am doing a review and want to test a PR, I do something similar
to what Johan mentioned. I download the PR to my local fork, verify it
(often with manual testing in addition to the provided tests), and then
backout the code changes to see whether the provided automated test
would catch t
On Tue, 22 Jun 2021 15:36:04 GMT, Johan Vos wrote:
>
>
> This looks the correct approach indeed. Tests fail before and succeed after.
> That is, the first test succeeds before as well, but it makes sense as there
> is no action that would change the index. So I don't think it is accidentally
On Mon, 21 Jun 2021 13:22:07 GMT, Jeanette Winzenburg
wrote:
>> Issue was that the cancel event carried the listView's editingIndex at the
>> time of firing the event - that's wrong nearly always (because the list's
>> editing state/index might have changed between start and cancel, f.i. due t
I also thought it would be useful for the bot to run the tests after the
patch and notify on a failure. I didn't think about applying the new tests
to the old code with "hopes" for a failure, I like this idea. Providing 2
downloads is also useful.
One thing we need to be careful with is that an ol
Hi,
I really like the automation that Skara is providing. It saves time for
committers as well as for reviewers. In order to increase productivity even
more (without decreasing quality), there might be an additional step we
might somehow automate. Many PR's contain changes in java code and in test
On Mon, 21 Jun 2021 11:24:39 GMT, Ajit Ghaisas wrote:
> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation"
> warnings. I have created separate commits for each type of warnings for the
> ease of review.
>
> `gradle --info -PLINT="deprecation,removal"` -- results in war
On Wed, 16 Jun 2021 13:29:03 GMT, Ambarish Rapte wrote:
>> I also see the same problem as Ambarish does when I run it on my older
>> MacBook Pro with integrated graphics. I tracked it down to a bug in the
>> newly added `computeLight` method in the GLSL shaders. See my inline
>> comments. When
On Fri, 18 Jun 2021 10:23:33 GMT, Jeanette Winzenburg
wrote:
> > I created a follow-up issues for fixing all the sub Tree- and TableCell
> > implementation which do not count the row editability in:
> > [JDK-8268295](https://bugs.openjdk.java.net/browse/JDK-8268295)
>
> as already commented in
On Tue, 22 Jun 2021 11:25:42 GMT, Ambarish Rapte wrote:
> Both Point and Spot light are not correctly applied to Mesh when number of
> faces is increased to more than 60.
> Following are steps to reproduce with Point light with existing source
> without this PR.
> As this is an existing issue w
On Sat, 19 Jun 2021 13:46:54 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
20 matches
Mail list logo
