On Wed, 6 May 2020 11:46:27 GMT, Jeanette Winzenburg
wrote:
>> some skins have not been guarding themselves against multiple calls to
>> dispose (see issue for details)
>>
>> Fixed by backing out off dispose if skinnable is null. Added test
>> (parameterized in control class) for all controls
On Fri, 8 May 2020 11:25:03 GMT, Jose Pereda wrote:
> There is a visual glitch when the scrollbar controls are laid out on touch
> enabled devices.
>
> The first time they are laid out in the wrong location (20 px from right or
> bottom), while the next passes are correct
> (8 px from right or
On Fri, 1 May 2020 12:33:36 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in comment
>
> Marked as reviewed by kcr (Lead).
@hjohn, this PR is ready to be merged.
You need to commen
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244418
>
> Root Cause :
> Incorrect assumption about menu list size.
>
> Fix :
> Added check for empty menu list before trying to access it.
>
> Test :
> Added a unit test that fails before fix and passes af
On Fri, 8 May 2020 13:51:34 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review_fixes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ski
Issue :
https://bugs.openjdk.java.net/browse/JDK-8244418
Root Cause :
Incorrect assumption about menu list size.
Fix :
Added check for empty menu list before trying to access it.
Test :
Added a unit test that fails before fix and passes after it.
-
Commit messages:
- 8244418_fix
On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg
wrote:
> The issue is that ChoiceBox didn't sync its value to the replaced
> SelectionModel's selectedItem if the item is null.
>
> Fixed by removing the constraint from selectionModel property.
>
> Added tests that failed before and passed
On Tue, 5 May 2020 16:49:09 GMT, Jose Pereda wrote:
> `VirtualFlow` makes use of `VirtualScrollBar` controls, that are laid out
> next to the clipped container region, by
> default.
> However, when touch is supported, these scrollBars are floating controls laid
> out over the container. Therefo
On Mon, 4 May 2020 09:07:53 GMT, Ajit Ghaisas wrote:
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244110
>
> Root Cause :
> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
> code to remove accelerators from a scene
> in Scene
these tests
> passes after the fix
> Special Thanks to @kleopatra for most of the test digging and fix guidance.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
Make ChangeListener Final
-
Changes:
- all: https
On Mon, 4 May 2020 15:46:57 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make ChangeListener Final
>
> modules/javafx.controls/src/main/
Issue :
https://bugs.openjdk.java.net/browse/JDK-8244110
Root Cause :
Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
code to remove accelerators from a scene
in Scene property listener of MenuButtonSkinBase. That fix uses getSkinnable()
in listener. It turned out th
On Tue, 28 Apr 2020 15:36:53 GMT, Jeanette Winzenburg
wrote:
> The issue is that the toggles is not reliably unselected if an uncontained
> value is set.
>
> The root is ChoiceBoxSelectionModel which doesn't update the index on
> selecting an uncontained item, in particular it
> fails to keep
On Tue, 28 Apr 2020 20:44:01 GMT, Kevin Rushforth wrote:
>> The issue is that the toggles is not reliably unselected if an uncontained
>> value is set.
>>
>> The root is ChoiceBoxSelectionModel which doesn't update the index on
>> selecting an uncontained item, in particular it
>> fails to kee
pr-2020, at 8:17 PM, Jeanette Winzenburg
> wrote:
>
> On Mon, 27 Apr 2020 11:57:58 GMT, Ajit Ghaisas wrote:
>
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
>>
>> Root cause : When a MenuItem is removed from a Scene, if any accelerator has
>>
On Tue, 28 Apr 2020 09:38:56 GMT, Jeanette Winzenburg
wrote:
>> The issue is that ChoiceBoxSkin
>> a) doesn't update the text of the label if the value is not contained in the
>> items
>> b) doesn't respect converter for label text
>>
>> Fixed by
>> - listening to value changes to update the l
On Mon, 27 Apr 2020 11:19:33 GMT, Ambarish Rapte wrote:
>> The issue is that ChoiceBoxSkin
>> a) doesn't update the text of the label if the value is not contained in the
>> items
>> b) doesn't respect converter for label text
>>
>> Fixed by
>> - listening to value changes to update the label
>
On Mon, 27 Apr 2020 14:02:42 GMT, John Hendrikx wrote:
>> This is a solution for 8242548. There was zero test coverage, so I added a
>> few tests for this as well.
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
registered accelerators from
> Scene.
>
> Testing : Added a unit test that fails before the fix and passes with it.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
spelling_correction
-
Changes:
- all: https
On Thu, 23 Apr 2020 11:32:26 GMT, John Hendrikx wrote:
>> This is a solution for 8242548. There was zero test coverage, so I added a
>> few tests for this as well.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental
> vie
Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
Root cause : When a MenuItem is removed from a Scene, if any accelerator has
been set on MenuItem, it does not get
removed from Scene's list of accelerators.
Fix : If Scene changes for a Menu, remove the registered accelerators from
Scene
On Tue, 21 Apr 2020 12:48:37 GMT, Kevin Rushforth wrote:
>> @aghaisas can you review this?
>
> @aghaisas can you also review this?
I tested with the test program in the bug and can confirm that this PR fixes
the reported issue.
I found that the unit test (together with stub) passes without the
On Sun, 12 Apr 2020 21:21:07 GMT, John Hendrikx wrote:
> This is a solution for 8242548. There was zero test coverage, so I added a
> few tests for this as well.
Marked as reviewed by aghaisas (Reviewer).
-
PR: https://git.openjdk.java.net/jfx/pull/173
On Wed, 22 Apr 2020 15:54:09 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
>> line 426:
>>
>>> 425:
>>> 426: height += lineSpacing;
>>> 427:
>>
>> Modifying 'height' parameter seems incorrect as this parameter is used in
On Sun, 12 Apr 2020 21:21:07 GMT, John Hendrikx wrote:
> This is a solution for 8242548. There was zero test coverage, so I added a
> few tests for this as well.
modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
line 426:
> 425:
> 426: height += lineS
On Mon, 13 Apr 2020 06:59:08 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8193286
>
> Root Cause :
> Incorrect implementation.
> Current implementation of int wrapValue(int,int,int) in Spinner.java works
> well if min is 0.
> Hence this impl
On Wed, 22 Apr 2020 09:06:09 GMT, Jeanette Winzenburg
wrote:
>> I checked and there is a case that (mostly) works today that will break with
>> your proposed fix. I left a couple inline
>> comments.
>> I wonder if it is better to wait and fix it completely in
>> [JDK-8242553](https://bugs.openj
;>>
>>> - I read your suggestion (in
>>> https://bugs.openjdk.java.net/browse/JDK-8242553) to imply f.i. that being
>>> at value and incrementing a full-cycle (that is max -min +1), I will land
>>> on value again
>>> - for me the doc seeme
On Thu, 9 Apr 2020 09:37:30 GMT, Craig Cavanaugh
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8129123
>
> This pull request fixes JDK-8129123. This bug also effects Windows and Linux
> platforms.
> Also, I believe JDK-8196037 is a duplicate of this issue.
>
> I've tested this against Ope
On Fri, 17 Apr 2020 09:21:25 GMT, Craig Cavanaugh
wrote:
>> The following should work:
>>
>> $ git rebase -i master
>>
>> If the rebase is successful, it will pop you into your EDITOR. You then
>> select "pick" for the first commit (which is
>> already selected by default) and "s"quash or "f"
On Fri, 10 Apr 2020 10:22:29 GMT, Jeanette Winzenburg
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8129123
>>
>> This pull request fixes JDK-8129123. This bug also effects Windows and Linux
>> platforms.
>> Also, I believe JDK-8196037 is a duplicate of this issue.
>>
>> I've tested this
On Thu, 16 Apr 2020 15:04:53 GMT, Jeanette Winzenburg
wrote:
>> Macroscopic issue is that initially, the toggle is not sync'ed to the
>> selection state. Root reason is an missing else
>> block when updating toggle selection state (see report for details).
>> Fixed by introducing the else block
On Wed, 15 Apr 2020 23:18:46 GMT, Kevin Rushforth wrote:
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8193286
>>
>> Root Cause :
>> Incorrect implementation.
>> Current implementation of int wrapValue(int,int,int) in Spinner.java works
>> well if min is 0.
>> Hence this implementation wo
On Wed, 15 Apr 2020 10:02:47 GMT, Jeanette Winzenburg
wrote:
>> Macroscopic issue is that initially, the toggle is not sync'ed to the
>> selection state. Root reason is an missing else
>> block when updating toggle selection state (see report for details).
>> Fixed by introducing the else block
On Mon, 13 Apr 2020 10:36:51 GMT, Jeanette Winzenburg
wrote:
> Macroscopic issue is that initially, the toggle is not sync'ed to the
> selection state. Root reason is an missing else
> block when updating toggle selection state (see report for details).
> Fixed by introducing the else block and
e doc literally ..
>
> -- Jeanette
>
> Zitat von Ajit Ghaisas :
>
>> Hi,
>>
>> Once I fix JDK-8193286, I would like to take up JDK-8242553
>> (IntegerSpinner does not wrap around values correctly if amountToStepBy is
>> larger than total number
Hi,
Once I fix JDK-8193286, I would like to take up JDK-8242553 (IntegerSpinner
does not wrap around values correctly if amountToStepBy is larger than total
numbers between Max and Min)
The current implementation is not as per what is documented.
Refer :
https://openjfx.io/javadoc/14/
Issue : https://bugs.openjdk.java.net/browse/JDK-8193286
Root Cause :
Incorrect implementation.
Current implementation of int wrapValue(int,int,int) in Spinner.java works well
if min is 0.
Hence this implementation works with ListSpinnerValueFactory, but fails with
IntegerSpinnerValueFactory.
F
On Tue, 7 Apr 2020 11:40:09 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8241710
>>
>> Root Cause : A menu can have empty submenu. This was not checked while
>> processing RIGHT arrow key.
>>
>> Fix : Added the null check for s
> Bug : https://bugs.openjdk.java.net/browse/JDK-8241710
>
> Root Cause : A menu can have empty submenu. This was not checked while
> processing RIGHT arrow key.
>
> Fix : Added the null check for submenu. Added a unit test case which fails
> without fix and passes with
On Tue, 7 Apr 2020 10:13:39 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor review fixes
>
> modules/javafx.controls/src/main/jav
Bug : https://bugs.openjdk.java.net/browse/JDK-8241710
Root Cause : A menu can have empty submenu. This was not checked while
processing RIGHT array key.
Fix : Added the null check for submenu. Added a unit test case which fails
without fix and passes with it.
-
Commit messages:
Hi Craig,
Here is how I run the ButtonMnemonicPositionTest.
$ export FX_LIB=/Users/AG/aaa/jfx/build/sdk/lib
$ cd /Users/AG/aaa/jfx/tests/manual/UI
$ javac --module-path $FX_LIB --add-modules javafx.controls
ButtonMnemonicPositionTest.java
$ java --module-path $FX_LIB --add-mo
On Thu, 2 Apr 2020 09:11:57 GMT, Jeanette Winzenburg
wrote:
>> Several controls with selection/focusModels leave memory leaks on replacing
>> the model.
>>
>> Added tests for all such, those for the misbehaving models fail before and
>> pass after the fix.
>>
>> for convenience, the bug refe
Bug : https://bugs.openjdk.java.net/browse/JDK-8230809
Root Cause :
Turned out to be a simpler issue than thought.
Atomicity check was missed while updating toolbar state (which in turn updates
styles).
Fix :
Added the missed atomicity check at two places that handle text selection using
keyboa
Vote: YES
Regards,
Ajit
> On 26-Mar-2020, at 5:14 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Arun Joseph [1] to OpenJFX Committer.
>
> Arun is a member of JavaFX team at Oracle, who has contributed 13 commits
> [2][3] to OpenJFX.
>
> Votes are due by April 9, 2020.
>
> Only current
On Wed, 25 Mar 2020 19:05:42 GMT, Rony G. Flatscher
wrote:
>> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
>
> Rony G. Flatscher has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove jcheck whitespace erro
On Thu, 26 Mar 2020 11:37:06 GMT, Jeanette Winzenburg
wrote:
>
> Not included would be memory leaks introduced by whacky listening of
> ChoiceBoxSkin and TabPaneSkin to properties of the
> selectionModel. The former will (most probably) be fixed as a side-effect of
> https://bugs.openjdk.java.
lating
> mnemonic position.
>
> **Testing :**
> Existing manual test is modified to test RTL buttons as well.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
fix file header comment
-
Changes:
- all: https://
**Bug :**
https://bugs.openjdk.java.net/browse/JDK-8089828
**Root Cause :**
RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position
calculation.
**Fix :**
Corrected code to consider RIGHT_TO_LEFT NodeOrientation while calculating
mnemonic position.
**Testing :**
Existing manu
On Fri, 13 Mar 2020 15:15:39 GMT, Kevin Rushforth wrote:
>> Is there anything I can do to keep the ball rolling ?
>
> I just need time to do final testing of this, along with the review of the
> updated test.
>
> @aghaisas will also review.
The changes look good to me.
I verified that the test
On Thu, 27 Feb 2020 15:56:25 GMT, Rony G. Flatscher
wrote:
>> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
>
> Rony G. Flatscher has updated the pull request incrementally with one
> additional commit since the last revision:
>
> corrected wrong test string
**Issue**
https://bugs.openjdk.java.net/browse/JDK-8089134
**Fix**
Added a fix to modify selection direction based on NodeOrientation of the
ToolBar.
**Testing**
Added a unit test to test common focus movement scenarios using tab and arrow
keys for the ToolBar.
-
Commit messages:
ess
> tests have been modified to address LTR and RTL orientations.
> Note : If this test modification is acceptable, I would like to address other
> similar tests separately. (I will create
> a test JBS issue and address later)
Ajit Ghaisas has updated the pull request incrementally
On Mon, 16 Mar 2020 13:00:32 GMT, Jeanette Winzenburg
wrote:
>> Good catch!!!
>> It definitely would have unintentional side effect of incorrect orientation
>> in subsequent tests.
>> I updated the test to restore the orientation at the end of the test. Also
>> documented the same.
>
> hmm ...
ess
> tests have been modified to address LTR and RTL orientations.
> Note : If this test modification is acceptable, I would like to address other
> similar tests separately. (I will create
> a test JBS issue and address later)
Ajit Ghaisas has updated the pull request incrementally
On Thu, 12 Mar 2020 12:39:16 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> extra space removed
>
> modules/javafx.controls/src/test/
On Fri, 6 Mar 2020 19:53:04 GMT, Kevin Rushforth wrote:
>> Please ignore this comment as well, it is also for debugging issues with
>> Skara and mailman :email: 😠
>
> @aghaisas can you review this?
I executed these tests without this patch. They did not hang on my Macbook.
I applied patch and
On Tue, 3 Mar 2020 22:51:43 GMT, Kevin Rushforth wrote:
> While testing JavaFX using gradle 6.3-nightly and JDK 14, I ran into what
> turned out to be a latent test bug in the
> AppJSCallback* apps that are launched by ModuleLauncherTest. The launched
> apps construct a WebView instance, obtain
On Sun, 1 Mar 2020 12:24:06 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra is right about the need to handle the case where the orientation
>> of a node changes. As for the test, I think the idea of parameterizing it
>> with LTR, RTL is good. I haven't reviewed it in detail, but added one minor
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
On Tue, 3 Mar 2020 13:06:52 GMT, Ambarish Rapte wrote:
>> The selection model of ListView stores a strong reference to the most
>> recently changed item in
>> `SelectedItemsReadOnlyObservableList.itemsListChange`, which causes a leak.
>>
>> Fix:
>> The below member variables and method of cla
On Fri, 28 Feb 2020 12:00:23 GMT, Ajit Ghaisas wrote:
>> Also, I'm a bit weary about the "else if" (vs a simple "else") - wouldn't it
>> be some kind of setup error if the node orientation is neither rtl nor ltr?
>> If so, I would add a test t
On Tue, 25 Feb 2020 15:10:50 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
>> line 1141:
>>
>>> 1140: keyboard.doLeftArrowPress(KeyModifier.getShortcutKey());
>>> 1141: }
>>> 1142: keybo
On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote:
>> This is a fix for an intermittent test failure affecting
>> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in
>> `test.javafx.scene.CssStyleHelperTest`, which was added as part of
>> [JDK-8237469](https://bu
On Sat, 15 Feb 2020 14:59:30 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
> line 102:
>
>> 101:
>> 102: private NodeOrientation orientation;
>> 103:
On Fri, 14 Feb 2020 11:18:12 GMT, Jeanette Winzenburg
wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java
> line 139:
>
>> 138: boolean rtl = isRTL();
>> 139:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
On Sat, 15 Feb 2020 14:54:50 GMT, Kevin Rushforth wrote:
>> thanks, Kevin - that's what I tried, but it refused to accept the second ..
>> so sticking with single comments until I feel like digging into this
>> weirdness.
>
> Regarding the fix, it seems that you need to eliminate the `rtl` var
On Tue, 4 Feb 2020 22:41:37 GMT, Kevin Rushforth wrote:
>> @aghaisas can you review this?
>
> I pushed a new commit that reverts the changes to the stored binary index
> files. There is no need to regenerate them when upgrading to a new version
> where only the `bugfix` number (the third digit
On Tue, 4 Feb 2020 22:47:18 GMT, Kevin Rushforth wrote:
>> Update the version of Lucene used by Ensemble to the latest release of
>> Lucene 7 which is version 7.7.2.
>>
>> Per the instructions in
>> [`UPDATING-lucene.txt`](https://github.com/openjdk/jfx/blob/master/apps/samples/Ensemble8/UPDAT
Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
Fix : Added the missed out RTL checks to the key mappings in
TableViewBehaviorBase class.
Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a
parameter. The Left/Right key press tests have been modified to addres
On Fri, 10 Jan 2020 08:17:12 GMT, Ambarish Rapte wrote:
> `ListView` does not get GCed because `SelectedItemsReadOnlyObservableList`
> adds a `ListChangeListener` to the (`ObservableList`) items of `ListView`.
>
> Adding a `WeakListChangeListener` instead of `ListChangeListener` fixes the
> is
On Fri, 7 Feb 2020 10:54:44 GMT, Johan Kaving
wrote:
>> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that
>> we leave the
>> current system menubar alone when other menubars are changed.
>>
>> It also adds a test case that reproduces the problem before the fix.
>
> P
On Wed, 5 Feb 2020 11:07:39 GMT, Ambarish Rapte wrote:
> Issue:
> Dragging a tab and dropping it back to it's original position causes an
> incorrect reordering of tabs. Incorrect order of tabs can be observed using
> arrow key traversal through tabs.
>
> Cause:
> Below mechanism of identifyi
On Tue, 28 Jan 2020 09:47:33 GMT, Dean Wookey wrote:
>> Everything passes with the fix and 5 of the new tests fail without the fix.
>>
>> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
>> movingBranchToDifferentBranchGetsNewCssVariableTest
>> removingThenAddingNodeToDifferentBranchG
On Tue, 28 Jan 2020 09:08:35 GMT, Dean Wookey wrote:
>> Everything passes with the fix and 5 of the new tests fail without the fix.
>>
>> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
>> movingBranchToDifferentBranchGetsNewCssVariableTest
>> removingThenAddingNodeToDifferentBranchG
On Tue, 28 Jan 2020 09:03:40 GMT, Ambarish Rapte wrote:
>> This PR is a fix for
>> [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824)
>> This issue is regression of
>> [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074).
>>
>> Issue.
>> - `Parent.viewOrderChildren` is
Changeset: d2d44b4a
Author:Jeanette Winzenburg
Committer: Ajit Ghaisas
Date: 2019-12-17 11:44:42 +
URL: https://git.openjdk.java.net/jfx/commit/d2d44b4a
8207759: VK_ENTER not consumed by TextField when default Button exists
Reviewed-by: aghaisas, kcr
!
modules
On Mon, 16 Dec 2019 11:47:15 GMT, Hadzic Samir wrote:
>> Allright, this is a fix for JDK-8207957
>
> The pull request has been updated with 1 additional commit.
-
Marked as reviewed by aghaisas (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/6
On Mon, 16 Dec 2019 08:53:10 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
>
On Tue, 10 Dec 2019 12:26:27 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
>
Changeset: 71ca899f
Author:Jeanette Winzenburg
Committer: Ajit Ghaisas
Date: 2019-12-09 08:08:34 +
URL: https://git.openjdk.java.net/jfx/commit/71ca899f
8220722: ProgressBarSkin: adds strong listener to control's width property
Reviewed-by: aghaisas, arapte
!
mo
Changeset: 07af89a9
Author:Jeanette Winzenburg
Committer: Ajit Ghaisas
Date: 2019-12-06 11:25:18 +
URL: https://git.openjdk.java.net/jfx/commit/07af89a9
8221334: TableViewSkin: must initialize flow's cellCount in constructor
Reviewed-by: aghaisas
!
modules/javafx.con
On Fri, 6 Dec 2019 09:42:05 GMT, Jeanette Winzenburg
wrote:
>> fix for https://bugs.openjdk.java.net/browse/JDK-8220722
>>
>> - replaces the manually registered listener with registerChangeListener(...)
>> - added test that's failing before and passing after the fix (plus a sanity
>> test that
On Fri, 29 Nov 2019 15:08:16 GMT, Jeanette Winzenburg
wrote:
> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8221334
>
> - fixed as outlined in the bug report: added updateItemCount() in skin
> constructor (that's what all sibling skins are doing)
> - added test which fails for Ta
On Fri, 29 Nov 2019 15:08:16 GMT, Jeanette Winzenburg
wrote:
> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8221334
>
> - fixed as outlined in the bug report: added updateItemCount() in skin
> constructor (that's what all sibling skins are doing)
> - added test which fails for Ta
Changeset: 83eb0a7c
Author:Ajit Ghaisas
Date: 2019-11-27 07:05:15 +
URL: https://git.openjdk.java.net/jfx/commit/83eb0a7c
8193445: JavaFX CSS is applied redundantly leading to significant performance
degradation
Reviewed-by: kcr, dgrieve
! modules/javafx.graphics/src/main
On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote:
> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote:
>
>> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve
>> wrote:
>>
>>> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote:
>>>
>>&
On Tue, 26 Nov 2019 09:22:02 GMT, Geoff
wrote:
> On Tue, 26 Nov 2019 09:22:02 GMT, Ajit Ghaisas wrote:
>
>> On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote:
>>
>>> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote:
>>>
>>>>
The pull request has been updated with additional changes.
Added commits:
- 2054da4c: Address review comments on test
- 4dade6e5: Simpler fix + System test corrections
- bd4a306a: Revert commit1 and commit 2
Changes:
- all: https://git.openjdk.java.net/jfx/pull/34/files
-
On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve
wrote:
> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote:
>
>> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote:
>>
>>> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote:
>>>
>>>>
On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote:
> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote:
>
>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote:
>>
>>> **Issue :**
>>> https://bugs.openjdk.java.net/browse/JDK-8193445
&
Changeset: e37cb370
Author:Ajit Ghaisas
Date: 2019-11-17 17:29:26 +
URL: https://git.openjdk.java.net/jfx/commit/e37cb370
8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and
TextInputControlTest
Reviewed-by: kcr
!
modules/javafx.controls/src/test
On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote:
> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote:
>
>> **Issue :**
>> https://bugs.openjdk.java.net/browse/JDK-8193445
>>
>> **Background :**
>> The CSS performance improve
On Thu, 14 Nov 2019 18:49:18 GMT, Kevin Rushforth wrote:
> On Thu, 14 Nov 2019 09:33:39 GMT, Ajit Ghaisas wrote:
>
>> This PR is to address ignored tests in ComboBoxTest, LabeledTest,
>> HyperLinkTest and TextInputControlTest.
>>
>> strategy is as follows -
>
On Wed, 13 Nov 2019 22:54:01 GMT, Kevin Rushforth wrote:
> This fixes [JDK-8234110](https://bugs.openjdk.java.net/browse/JDK-8234110) by
> moving `SwingFXUtilsTest` from the `:swing` project to the `:systemTests`
> project. As explained in the JBS issue, `SwingFXUtilsTest` must be run in its
>
This PR is to address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest
and TextInputControlTest.
strategy is as follows -
1) Enable tests marked with @Ignore by removing that tag
2) Run the test
3) If test Passes - remove the @Ignore tag
4) If test fails - if test is invalid - remove it
301 - 400 of 459 matches
Mail list logo
