Re: How to set WM_CLASS for GNOME?

2022-06-09 Thread Abhinay Agarwal
Hi Alex, Do you have the following entry in the .desktop file of your application[1]: StartupWMClass=com.foo.bar.FooApplication -Abhinay [1] https://github.com/gluonhq/scenebuilder/pull/407 From: openjfx-dev on behalf of Alex Orlov Sent: Thursday, May 26,

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v2]

2022-06-09 Thread Christian Heilmann
On Tue, 6 Jul 2021 15:12:23 GMT, Florian Kirmaier wrote: >> It's "a bit" complicated. >> In some situations, getRuns get's called because listeners on bounds are set. >> This causes TextFlow to layout to compute the runs. >> Afterward, the bounds of the parents get updated. >> This triggers a

Re: RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v3]

2022-06-09 Thread Christian Heilmann
On Mon, 10 Jan 2022 12:29:04 GMT, Florian Kirmaier wrote: >> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added >> a unit-test for it. >> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397 >> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v5]

2022-06-09 Thread Christian Heilmann
On Thu, 27 Jan 2022 14:50:16 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v8]

2022-06-09 Thread Florian Kirmaier
On Thu, 14 Oct 2021 17:14:11 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8273485 >> Added check for null when calling initScreens > >

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v8]

2022-06-09 Thread Christian Heilmann
On Mon, 15 Nov 2021 10:05:10 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-06-09 Thread Christian Heilmann
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v4]

2022-06-09 Thread Christian Heilmann
On Tue, 11 Jan 2022 19:04:56 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which

Re: Updating printers while application is running?

2022-06-08 Thread Tobias Oelgarte
On 08.06.22 21:14, Philip Race wrote: I am referring to windows native code we have in Java 2D. It is completely invisible at the API level of Java 2D. I understand that the public API does not provide this feature. Java 2D itself listens to the events from Windows and updates the array of

Re: Updating printers while application is running?

2022-06-08 Thread Philip Race
On 6/8/22 11:34 AM, Tobias Oelgarte wrote: I don't know if there is an common event available in the Java2D backend to detect added/removed printers directly. So far i could not see anything like that. I am referring to windows native code we have in Java 2D. It is completely invisible

Re: Updating printers while application is running?

2022-06-08 Thread Tobias Oelgarte
I don't know if there is an common event available in the Java2D backend to detect added/removed printers directly. So far i could not see anything like that. Every PrintService instance should implement the equals() [1] method to determine uniqueness. This could be used to compare/intersect

Re: Updating printers while application is running?

2022-06-07 Thread Tobias Oelgarte
I already thought about using PrintServiceLookup. I could use it to show the user the currently available printers, but I can't use it to create a javafx.print.Printer instance without reflective access (JPMS). At the moment I'm stuck with a an unmodifiable OberservableSet that never updates.

Re: Updating printers while application is running?

2022-06-07 Thread Thiago Milczarek Sayão
Hi, I use it through the javax.print API: ObservableList printServices = FXCollections.observableArrayList( PrintServiceLookup.lookupPrintServices(null, null)); Maybe it may help for now, but to me it seems it should not be static. Em ter., 7 de jun. de

Re: Updating printers while application is running?

2022-06-07 Thread Philip Race
Ahem .. well .. I guess we (I) forgot to get back to that. Since the current implementation on Windows wraps the Java 2D printing code and it registers with windows to be told about changes in printers then the calls being made in the method with that comment would (well, should) provide the

Updating printers while application is running?

2022-06-07 Thread Tobias Oelgarte
Is there some way to update the ObservableSet of Printers once the Application is running? Calling Printer.getAllPrinters() always returns the same OberservableSet and it does not change - ever. [1] We have an JavaFx based application running under Windows 10/11 that is used to print on

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v2]

2022-06-01 Thread Laurent Bourgès
On Tue, 31 May 2022 22:25:23 GMT, Kevin Rushforth wrote: >> Hi, >> Time is going short before openjfx 19... >> >> 2 options: >> - keep dpqs for corner cases and keep my coding life simple >> - disable or remove dpqs code in marlinFX for openjfx, so my branches will >> diverge... >> >> Any

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-06-01 Thread Michael Ennen
On Mon, 2 May 2022 19:55:28 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >>

Integrated: 8277756: DatePicker listener might not be added when using second constructor

2022-06-01 Thread Marius Hanl
On Tue, 24 May 2022 21:35:15 GMT, Marius Hanl wrote: > The `valueProperty()` and `chronologyProperty()` listener are now added in > the second constructor of `DatePicker` > (`public DatePicker(LocalDate localDate)`) instead of the first one (`public > DatePicker()`). > Therefore, both

Re: RFR: 8277756: DatePicker listener might not be added when using second constructor

2022-05-31 Thread Ajit Ghaisas
On Tue, 24 May 2022 21:35:15 GMT, Marius Hanl wrote: > The `valueProperty()` and `chronologyProperty()` listener are now added in > the second constructor of `DatePicker` > (`public DatePicker(LocalDate localDate)`) instead of the first one (`public > DatePicker()`). > Therefore, both

Integrated: 8284654: Modal behavior returns to wrong stage

2022-05-31 Thread Thiago Milczarek Sayao
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao wrote: > When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee >

Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]

2022-05-31 Thread Kevin Rushforth
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-05-31 Thread Kevin Rushforth
On Wed, 25 May 2022 07:37:38 GMT, Laurent Bourgès wrote: > keep dpqs for corner cases and keep my coding life simple I think this approach is fine. Diverging the code would likely make it less stable, and you answered the question about the provenance of the code, so there's no issue there.

Integrated: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView

2022-05-31 Thread Jose Pereda
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail

Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView [v2]

2022-05-31 Thread Ajit Ghaisas
On Tue, 24 May 2022 09:51:29 GMT, Jose Pereda wrote: >> This PR fixes an issue with selection of multiple items in TableView and >> TreeTableView controls that gets moved unexpectedly when new items are added >> even way below the selected items. >> >> A couple of tests have been added. They

Re: JDK-8091393: Observable collections for ObservableMap views

2022-05-30 Thread Nir Lisker
Then maybe a solution would be around adding new methods like observableKeySet(). These will need to be default methods, and the implementation could test if keySet() already returns an ObservableSet, in which case it returns it, and if not it wraps the Set in an ObservableSetWrapper or something

Integrated: 8088420: JavaFX WebView memory leak via EventListener

2022-05-30 Thread Jay Bhaskar
On Thu, 19 May 2022 13:13:01 GMT, Jay Bhaskar wrote: > This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When

Re: JDK-8091393: Observable collections for ObservableMap views

2022-05-30 Thread John Hendrikx
Sorry, I misunderstood, I missed that the methods weren't already defined in ObservableMap, so no existing signature is changed. --John On 30/05/2022 09:39, Tom Schindl wrote: Hi, Well the binary compat IMHO is not a problem. If your subtype overwrites the return type of a method the

Re: RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v7]

2022-05-30 Thread Johan Vos
> When the size of a ListCell is changed and a scrollTo method is invoked > without having a layout calculation in between, the old (wrong) size is used > to calculcate the total estimate. This happens e.g. when the size is changed > in the `updateItem` method. > This PR will immediately resize

Re: JDK-8091393: Observable collections for ObservableMap views

2022-05-30 Thread Tom Schindl
Hi, Well the binary compat IMHO is not a problem. If your subtype overwrites the return type of a method the compiler will inserts a bridge method: Take this example package bla; import java.util.ArrayList; import java.util.Collection; import java.util.List; public class Test {

Re: JDK-8091393: Observable collections for ObservableMap views

2022-05-30 Thread John Hendrikx
It's not binary compatible, as changing the return type results in a new method that compiled code won't be able to find. See also "change result type (including void)" here: https://wiki.eclipse.org/Evolving_Java-based_APIs_2#Evolving_API_interfaces_-_API_methods --John On 30/05/2022

JDK-8091393: Observable collections for ObservableMap views

2022-05-29 Thread Nir Lisker
Hi, Picking up an old issue, JDK-8091393 [1], I went ahead and looked at the work needed to implement it. keySet() and entrySet() can both be made to return ObservableSet rather easily. values() will probably require an ObservableCollection type. Before discussing these details, my question is:

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-28 Thread Ambarish Rapte
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-28 Thread John Hendrikx
On Fri, 27 May 2022 23:31:42 GMT, Kevin Rushforth wrote: > I reviewed the public API changes, and this looks like a great addition to > JavaFX bindings. I think there might be time to get this into JavaFX 19, > presuming that there are no issues with the testing or implementation, so > let's

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v15]

2022-05-28 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-27 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-27 Thread Kevin Rushforth
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-27 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Jay Bhaskar
On Fri, 27 May 2022 15:42:09 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change for unregisterDomWindow function and code cleanup > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Kevin Rushforth
On Fri, 27 May 2022 12:13:43 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-27 Thread Jay Bhaskar
On Thu, 26 May 2022 17:00:46 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding space for map include > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-26 Thread Kevin Rushforth
On Thu, 26 May 2022 07:26:38 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-26 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v6]

2022-05-26 Thread danielpeintner
On Thu, 26 May 2022 07:08:59 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v6]

2022-05-26 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-26 Thread Jay Bhaskar
On Wed, 25 May 2022 14:57:13 GMT, Ambarish Rapte wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments applied > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-26 Thread Jay Bhaskar
On Wed, 25 May 2022 12:45:59 GMT, Ambarish Rapte wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments applied > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-26 Thread Tomator
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-25 Thread Kevin Rushforth
On Tue, 24 May 2022 15:20:01 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JGObject in plave of raw jni object > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-25 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Kevin Rushforth
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: Jpopupmenu Bug/Glitch When Showing Submenu

2022-05-25 Thread Davide Perini
I opened a bug report but they closed it by saying that they can't reproduce. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8286713 They test on Windows 10, can this be the cause why they are not able to reproduce? Here a gist where the code is better formatted.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Ambarish Rapte
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-05-25 Thread Laurent Bourgès
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

RFR: 8277756: DatePicker listener might not be added when using second constructor

2022-05-24 Thread Marius Hanl
The `valueProperty()` and `chronologyProperty()` listener are now added in the second constructor of `DatePicker` (`public DatePicker(LocalDate localDate)`) instead of the first one (`public DatePicker()`). Therefore, both listener are now added no matter which constructor is used.

Re: RFR: 8218826: TableRowSkinBase: horizontal layout broken if row has padding

2022-05-24 Thread Marius Hanl
On Tue, 24 May 2022 21:25:23 GMT, Marius Hanl wrote: > This PR fixes a problem, where the layout is broken when a `(Tree)TableRow` > has padding. > As also mentioned in the ticket, the `layoutChildren` method in > `TableRowSkinBase` is implemented wrong. > > The `layoutChildren` method is

RFR: 8218826: TableRowSkinBase: horizontal layout broken if row has padding

2022-05-24 Thread Marius Hanl
This PR fixes a problem, where the layout is broken when a `(Tree)TableRow` has padding. As also mentioned in the ticket, the `layoutChildren` method in `TableRowSkinBase` is implemented wrong. The `layoutChildren` method is responsible for layouting all the `(Tree)TableCells`. When the row

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-24 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

[jfx17u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:34:25 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 1835d1f5 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/1835d1f59104136d6cb34090bd69091433ddac00 Stats: 5484

[jfx17u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:33:57 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 7b1637f8 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/7b1637f8f617639ddc0c93e15589824c6a0d71b1 Stats: 21664

[jfx11u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:31:58 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: f89a5139 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/f89a513980c2c2637c4f3d2b80f0708fd6f9e252 Stats: 5484

[jfx11u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx11u/pull/102/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=102=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283869

[jfx11u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8286256: Update libxml2 to 2.9.14 Changes: https://git.openjdk.java.net/jfx11u/pull/101/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=101=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21664

[jfx11u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:31:27 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: 8504dad2 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/8504dad26ac0f0dcbf7cb62ac58642dc8a91f02e Stats: 21664

[jfx17u] RFR: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx17u/pull/62/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=62=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283869 Stats:

[jfx17u] RFR: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8286256: Update libxml2 to 2.9.14 Changes: https://git.openjdk.java.net/jfx17u/pull/61/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=61=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21664 lines

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Jay Bhaskar
On Tue, 24 May 2022 14:54:19 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JGObject in plave of raw jni object > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v6]

2022-05-24 Thread Florian Kirmaier
On Mon, 23 May 2022 20:44:47 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size is changed >> in

Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView

2022-05-24 Thread Jose Pereda
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail

Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView [v2]

2022-05-24 Thread Jose Pereda
> This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail without this PR (first selected > item gets

Re: RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v6]

2022-05-23 Thread Johan Vos
On Mon, 23 May 2022 20:44:47 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size is changed >> in

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v6]

2022-05-23 Thread Johan Vos
> When the size of a ListCell is changed and a scrollTo method is invoked > without having a layout calculation in between, the old (wrong) size is used > to calculcate the total estimate. This happens e.g. when the size is changed > in the `updateItem` method. > This PR will immediately resize

Integrated: JDK-8286256 : Update libxml2 to 2.9.14

2022-05-23 Thread Hima Bindu Meda
On Tue, 17 May 2022 12:32:17 GMT, Hima Bindu Meda wrote: > Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , >

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]

2022-05-23 Thread Johan Vos
On Wed, 18 May 2022 13:39:12 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows

Re: @font-face question

2022-05-23 Thread Thiago Milczarek Sayão
Hi, After further investigation, I think there's a bug that font-family is not working (defining a font family name). Because regardless of the font-family I use, the font name within the font is used. It's openjfx 17.0.2 -- Thiago. Em sex., 20 de mai. de 2022 às 18:06, Thiago Milczarek Sayão

Integrated: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

2022-05-22 Thread Jose Pereda
On Fri, 6 May 2022 10:16:41 GMT, Jose Pereda wrote: > This PR extends the check if a treeItem is expanded to all its ancestors, as > in case one ancestor is collapsed, all its children will be hidden. > > 4 tests are included, two for TreeView and two for TreeTableView. This pull request has

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-22 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-22 Thread Jay Bhaskar
On Thu, 19 May 2022 21:45:00 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-22 Thread Jay Bhaskar
On Thu, 19 May 2022 21:34:54 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v3]

2022-05-22 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

@font-face question

2022-05-20 Thread Thiago Milczarek Sayão
Hi, I want to have one font that is "regular" and a variation of the same font as "bold", used when specified "-fx-font-weight: bold". @font-face { font-family: 'Gotham Condensed'; src: url('../fonts/GothamCondensed-Book.otf'); } @font-face { font-family: 'Gotham Condensed Bold';

Re: RFR: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

2022-05-20 Thread Ajit Ghaisas
On Fri, 6 May 2022 10:16:41 GMT, Jose Pereda wrote: > This PR extends the check if a treeItem is expanded to all its ancestors, as > in case one ancestor is collapsed, all its children will be hidden. > > 4 tests are included, two for TreeView and two for TreeTableView. This looks good to me.

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-20 Thread Kevin Rushforth
On Thu, 19 May 2022 22:01:31 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > >

Integrated: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-05-20 Thread Robert Lichtenberger
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. This pull request has now been integrated. Changeset: 18b2366f Author:Robert Lichtenberger Committer: Ajit Ghaisas URL:

Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]

2022-05-20 Thread Ambarish Rapte
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 15:57:46 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Jay Bhaskar
> This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When WebView goes out of scope (disposed from app) , its

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Jay Bhaskar
On Thu, 19 May 2022 15:22:08 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 13:13:01 GMT, Jay Bhaskar wrote: > This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Ajit Ghaisas
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger wrote: >> Separate test class added for TreeTableView case. >> Fix is analogous to JDK-8251480. > > Robert Lichtenberger has updated the pull request incrementally with two > additional commits since the last revision: > > - 8285197:

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Marius Hanl
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger wrote: >> Separate test class added for TreeTableView case. >> Fix is analogous to JDK-8251480. > > Robert Lichtenberger has updated the pull request incrementally with two > additional commits since the last revision: > > - 8285197:

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Robert Lichtenberger
On Thu, 12 May 2022 05:22:38 GMT, Ajit Ghaisas wrote: >> Robert Lichtenberger has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8285197: TableColumnHeader: calc of cell width must respect row styling >> (TreeTableView) >> >>

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-05-19 Thread Robert Lichtenberger
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Finally found the time to cleanup the test class... - PR: https://git.openjdk.java.net/jfx/pull/779

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Robert Lichtenberger
> Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Robert Lichtenberger has updated the pull request incrementally with two additional commits since the last revision: - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

RFR: 8088420: JavaFX WebView memory leak via EventListener

2022-05-19 Thread Jay Bhaskar
This PR is new implementation of JavaEvent listener memory management. Issue [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) 1. Calling remove event listener does not free jni global references. 2. When WebView goes out of scope (disposed from app) , its Event Listeners

Re: RFR: 8090522: Allow support for disabling stage iconification (minimization)

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 12:44:44 GMT, Paweł Kruszczyński wrote: > `Stage` minimalizing (iconified state) cannot be disabled for the user. The > same for `Stage` closable state. > PR adds these features without breaking backward compatibility. Marking this as "Draft" since it is not ready for

Re: RFR: 8090522: Allow support for disabling stage iconification (minimization)

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 12:44:44 GMT, Paweł Kruszczyński wrote: > `Stage` minimalizing (iconified state) cannot be disabled for the user. The > same for `Stage` closable state. > PR adds these features without breaking backward compatibility. @xardif It is premature to review this PR. Please read

RFR: 8090522: Allow support for disabling stage iconification (minimization)

2022-05-19 Thread Paweł Kruszczyński
`Stage` minimalizing (iconified state) cannot be disabled for the user. The same for `Stage` closable state. PR adds these features without breaking backward compatibility. - Commit messages: - 8090522: Allow support for disabling stage iconification (minimization) Changes:

  1   2   3   4   5   6   7   8   9   10   >