Changeset: 9cd6f791
Author:Kevin Rushforth
Date: 2020-02-27 12:14:17 +
URL: https://git.openjdk.java.net/jfx/commit/9cd6f791
8196586: Remove use of deprecated finalize methods from javafx property objects
Reviewed-by: nlisker, arapte
!
modules/javafx.base/src/main/java/com/s
On Thu, 20 Feb 2020 20:43:22 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` -- that
On Thu, 20 Feb 2020 20:43:22 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` -- that
> This patch removes the `finalize` methods from the `Property` classes in the
> `javafx.base` module.
>
> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
> methods -- `asObject` and `xProperty` -- that create a `Property`
> object from a primitive `XProperty`
On Thu, 20 Feb 2020 07:10:11 GMT, Nir Lisker wrote:
>>> > the referent to the created property object has been garbage collected
>>> > before the `finalize` method is called
>>>
>>> I'm confused. What is that referent exactly and why is it guaranteed to
>>> have been GC'd before finalization?
> This patch removes the `finalize` methods from the `Property` classes in the
> `javafx.base` module.
>
> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
> methods -- `asObject` and `xProperty` -- that create a `Property`
> object from a primitive `XProperty`
On Fri, 14 Feb 2020 14:23:45 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` -- that
On Thu, 20 Feb 2020 18:50:04 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.base/src/test/java/test/javafx/beans/property/ObjectPropertyLeakTest.java
> line 111:
>
>> 110: origRefs.add(new WeakReference<>(origProp));
>> 111:
On Fri, 14 Feb 2020 14:23:45 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` -- that
On Tue, 18 Feb 2020 20:09:59 GMT, Kevin Rushforth wrote:
>>> the referent to the created property object has been garbage collected
>>> before the `finalize` method is called
>>
>> I'm confused. What is that referent exactly and why is it guaranteed to have
>> been GC'd before finalization?
>
On Sun, 16 Feb 2020 01:24:43 GMT, Nir Lisker wrote:
>> I'll be the 2nd reviewer.
>
>> the referent to the created property object has been garbage collected
>> before the `finalize` method is called
>
> I'm confused. What is that referent exactly and why is it guaranteed to have
> been GC'd b
On Fri, 14 Feb 2020 20:47:04 GMT, Nir Lisker wrote:
>> @arapte I request you to be one of the reviewers of this PR.
>
> I'll be the 2nd reviewer.
> the referent to the created property object has been garbage collected before
> the `finalize` method is called
I'm confused. What is that refere
On Thu, 13 Feb 2020 23:13:06 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` -- that
> This patch removes the `finalize` methods from the `Property` classes in the
> `javafx.base` module.
>
> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
> methods -- `asObject` and `xProperty` -- that create a `Property`
> object from a primitive `XProperty`
This patch removes the `finalize` methods from the `Property` classes in the
`javafx.base` module.
The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
methods -- `asObject` and `xProperty` -- that create a `Property`
object from a primitive `XProperty` object and v
On Thu, 13 Feb 2020 23:10:28 GMT, Kevin Rushforth wrote:
> This patch removes the `finalize` methods from the `Property` classes in the
> `javafx.base` module.
>
> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
> methods -- `asObject` and `xProperty` -- that crea
16 matches
Mail list logo
