On Fri, 7 May 2021 11:10:41 GMT, Ambarish Rapte wrote:
> Backport had a minor merge conflict of copyright year in the file
> `Labeled.java`.
> Rest of the changes are clean backport
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx11u/pull/6
Backport had a minor merge conflict of copyright year in the file
`Labeled.java`.
Rest of the changes are clean backport
-
Commit messages:
- 8204568: Relative CSS-Attributes don't work all time
Changes: https://git.openjdk.java.net/jfx11u/pull/6/files
Webrev: https://webrevs.open
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not
>> computed correctly when the reference `-fx-font-size` is also specified
>> relatively and is nested.
>>
>> Fix is a slight variation of an earlier suggestion
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not
>> computed correctly when the reference `-fx-font-size` is also specified
>> relatively and is nested.
>>
>> Fix is a slight variation of an earlier suggestion
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not
>> computed correctly when the reference `-fx-font-size` is also specified
>> relatively and is nested.
>>
>> Fix is a slight variation of an earlier suggestion
On Sat, 6 Mar 2021 16:36:27 GMT, Kevin Rushforth wrote:
> Two additional comments, and otherwise looks good to me.
Thanks for the review, both the comments are addressed in next commit. Please
take a look.
-
PR: https://git.openjdk.java.net/jfx/pull/397
> Issue is that the size of properties that are relatively(`em`) sized is not
> computed correctly when the reference `-fx-font-size` is also specified
> relatively and is nested.
>
> Fix is a slight variation of an earlier suggestion in [the
> PR](https://github.com/javafxports/openjdk-jfx/pul
On Sat, 6 Mar 2021 16:10:18 GMT, Ambarish Rapte wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not
>> computed correctly when the reference `-fx-font-size` is also specified
>> relatively and is nested.
>>
>> Fix is a slight variation of an earlier suggestion
On Sat, 6 Mar 2021 01:47:28 GMT, Kevin Rushforth wrote:
> I left a few wording suggestions inline.
Thanks for the review comments. Please take a look at new commit. I have
rephrased comment statements and made corrections as per review comments.
-
PR: https://git.openjdk.java.net/
> Issue is that the size of properties that are relatively(`em`) sized is not
> computed correctly when the reference `-fx-font-size` is also specified
> relatively and is nested.
>
> Fix is a slight variation of an earlier suggestion in [the
> PR](https://github.com/javafxports/openjdk-jfx/pul
On Fri, 5 Mar 2021 17:42:25 GMT, Ambarish Rapte wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not
>> computed correctly when the reference `-fx-font-size` is also specified
>> relatively and is nested.
>>
>> Fix is a slight variation of an earlier suggestion
> Issue is that the size of properties that are relatively(`em`) sized is not
> computed correctly when the reference `-fx-font-size` is also specified
> relatively and is nested.
>
> Fix is a slight variation of an earlier suggestion in [the
> PR](https://github.com/javafxports/openjdk-jfx/pul
On Thu, 4 Mar 2021 21:56:49 GMT, Kevin Rushforth wrote:
> 1. The new method is only needed for Labeled because of the way it
> constructs the child graph, right? Is there anything that would preclude some
> other control from using this in the future, if a similar situation would
> arise?
On Thu, 4 Mar 2021 04:01:03 GMT, Ambarish Rapte wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not
>> computed correctly when the reference `-fx-font-size` is also specified
>> relatively and is nested.
>>
>> Fix is a slight variation of an earlier suggestion
On Tue, 9 Feb 2021 01:33:06 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update to recalculate properties when font size changes
>
> This is taking me longer to review than I expected, bec
> Issue is that the size of properties that are relatively(`em`) sized is not
> computed correctly when the reference `-fx-font-size` is also specified
> relatively and is nested.
>
> Fix is a slight variation of an earlier suggestion in [the
> PR](https://github.com/javafxports/openjdk-jfx/pul
On Mon, 8 Feb 2021 11:37:35 GMT, Ambarish Rapte wrote:
> Issue is that the size of properties that are relatively(`em`) sized is not
> computed correctly when the reference `-fx-font-size` is also specified
> relatively and is nested.
>
> Fix is a slight variation of an earlier suggestion in [
On Mon, 8 Feb 2021 11:37:35 GMT, Ambarish Rapte wrote:
> Issue is that the size of properties that are relatively(`em`) sized is not
> computed correctly when the reference `-fx-font-size` is also specified
> relatively and is nested.
>
> Fix is a slight variation of an earlier suggestion in [
Issue is that the size of properties that are relatively(`em`) sized is not
computed correctly when the reference `-fx-font-size` is also specified
relatively and is nested.
Fix is a slight variation of an earlier suggestion in [the
PR](https://github.com/javafxports/openjdk-jfx/pull/94).
Fix
19 matches
Mail list logo
