On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary
wrote:
>> Added missing explicit no-arg constructors to classes in package
>> javafx.scene, javafx.css and javafx.stage.
>
> Bhawesh Choudhary has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 26 Aug 2020 17:22:36 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated comments as per JDK Convention
>
> Looks good. I also verified that the only two class without an expli
On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary
wrote:
>> Added missing explicit no-arg constructors to classes in package
>> javafx.scene, javafx.css and javafx.stage.
>
> Bhawesh Choudhary has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
Bhawesh Choudhary has updated the pull request incrementally with one
additional commit since the last revision:
Updated comments as per JDK Convention
-
Changes:
-
On Wed, 26 Aug 2020 15:21:48 GMT, Bhawesh Choudhary
wrote:
>> Added missing explicit no-arg constructors to classes in package
>> javafx.scene, javafx.css and javafx.stage.
>
> Bhawesh Choudhary has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Tue, 25 Aug 2020 09:42:16 GMT, Nir Lisker wrote:
> Since it will require an additional cleanup issue anyway, I don't think it
> matters when we do it, but since we're here
> I see no reason not to start already.
Agreed.
Let's adopt the same language as the JDK. If there are configurable par
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
Bhawesh Choudhary has updated the pull request incrementally with one
additional commit since the last revision:
Updated comments as per JDK convention
-
Changes:
-
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
Bhawesh Choudhary has updated the pull request incrementally with one
additional commit since the last revision:
Reverted changes for class Selector and ShapeConverter as per review
On Wed, 19 Aug 2020 00:12:01 GMT, Kevin Rushforth wrote:
> I think that two of the classes have implicit constructors that are there by
> accident. Once we get agreement, I'll file
> a follow-on bug for those, and those changes should be reverted.
I finished reviewing the rest of the classes an
On Tue, 18 Aug 2020 23:41:23 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Preloader.java line
>> 121:
>>
>>> 120: public Preloader() {
>>> 121: }
>>> 122:
>>
>> Not sure that "default" means anything here. I don't see any configuration.
>
> Ri
On Tue, 18 Aug 2020 23:47:07 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/PseudoClass.java line 83:
>>
>>> 82:
>>> 83: /**
>>> 84: * There is only one PseudoClass instance for a given pseudoClass.
>>
>> 1. Is having a public constructor for this class
On Tue, 18 Aug 2020 23:31:42 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TableFocusModel.java
>> line 51:
>>
>>> 50:
>>> 51: /**
>>> 52: * Causes the item at the given index to receive the focus.
>>
>> Please add a missing `)` for the clas
On Wed, 19 Aug 2020 00:12:01 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Marked few class constructor as deprecated as per review
>
> I think that two of the classes have implicit cons
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
Bhawesh Choudhary has updated the pull request incrementally with one
additional commit since the last revision:
Marked few class constructor as deprecated as per review
--
On Mon, 17 Aug 2020 12:31:14 GMT, Nir Lisker wrote:
>> Added missing explicit no-arg constructors to classes in package
>> javafx.scene, javafx.css and javafx.stage.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TableFocusModel.java
> line 51:
>
>> 50:
>> 51: /**
>> 52:
On Mon, 17 Aug 2020 11:16:55 GMT, Bhawesh Choudhary
wrote:
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
I think that two of the classes have implicit constructors that are there by
accident. Once we get agreement, I'll file
a
On Tue, 18 Aug 2020 17:49:06 GMT, Nir Lisker wrote:
> The classes should be inspected to see if one is needed and if its doc is
> suitable.
This is an excellent point. One of the main reasons for not relying on
implicit, no-arg constructors is that you might
get a public constructor where one
On Mon, 17 Aug 2020 11:16:55 GMT, Bhawesh Choudhary
wrote:
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
@nlisker raises some good issues, so they should be addressed
-
Changes requested by kcr (Lead).
PR: https:/
On Mon, 17 Aug 2020 11:16:55 GMT, Bhawesh Choudhary
wrote:
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
I've completed a partial review. I think that just mechanically adding a
constructor with the same doc everywhere is
not a
On Mon, 17 Aug 2020 11:16:55 GMT, Bhawesh Choudhary
wrote:
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/283
Added missing explicit no-arg constructors to classes in package javafx.scene,
javafx.css and javafx.stage.
-
Commit messages:
- 8251353: Many javafx scenegraph classes have implicit no-arg constructors
Changes: https://git.openjdk.java.net/jfx/pull/283/files
Webrev: https://webre
21 matches
Mail list logo
