On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add module version to `graphics` and `web` project's compiler a
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add module version to `graphics` and `web` project's compiler a
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add module version to `graphics` and `web` project's compiler a
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add module version to `graphics` and `web` project's compiler a
On Mon, 23 Aug 2021 18:40:55 GMT, Johan Vos wrote:
>> OK, that seems reasonable, and I can't think of any downside.
>
> The only thing that makes me slightly nervous is seeing that this is needed
> on a number of places, leading to more code duplication (and the build.gradle
> is already rather
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add module version to `graphics` and `web` project's compiler a
On Mon, 23 Aug 2021 16:43:34 GMT, Kevin Rushforth wrote:
>> Seeing version information in stack traces of failed tests can be helpful.
>> ;-)
>
> OK, that seems reasonable, and I can't think of any downside.
The only thing that makes me slightly nervous is seeing that this is needed on
a numbe
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add module version to `graphics` and `web` project's compiler a
> https://bugs.openjdk.java.net/browse/JDK-8267472
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Add module version to `graphics` and `web` project's compiler args
-
Changes:
- all: https://git.openjdk.java.net/jf
On Mon, 23 Aug 2021 14:21:28 GMT, Christian Stein wrote:
> Aren't they covered by the allprojects { ... } and
No. These options are used for the `compileJava` task in all projects. They do
not affect the two compile tasks I mentioned. You can see that if you look at
the following temporary bui
On Mon, 23 Aug 2021 14:17:20 GMT, Christian Stein wrote:
>> build.gradle line 3929:
>>
>>> 3927: options.compilerArgs.addAll([
>>> 3928: '-implicit:none',
>>> 3929: '--module-version', "$RELEASE_VERSION_SHORT",
>>
>> I'm not sure this is needed (altho
On Mon, 23 Aug 2021 14:10:56 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Pass module version also to `jmod`
> I think there may be two
On Mon, 23 Aug 2021 14:06:31 GMT, Kevin Rushforth wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Pass module version also to `jmod`
>
> build.gradle line 3929:
>
>> 3927: options.compilerArgs.addAl
On Mon, 23 Aug 2021 14:10:56 GMT, Christian Stein wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Pass module version also to `jmod`
I think there may be two ot
> https://bugs.openjdk.java.net/browse/JDK-8267472
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Pass module version also to `jmod`
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/608/files
- new: https:
On Mon, 23 Aug 2021 10:48:23 GMT, Christian Stein wrote:
> https://bugs.openjdk.java.net/browse/JDK-8267472
The submit workflow just started:
https://github.com/sormuras/jfx/actions/runs/1158948963
I'm not sure, if passing `--module-version` to `jmod` is needed (as the
`module-info.class` sho
On Mon, 23 Aug 2021 12:59:46 GMT, Joeri Sykora wrote:
> [...] I'm not sure if this is more elegant? With Gradle 7, this option is
> also no longer incubating.
As long as `--module-source-path` et al aren't supported by Gradle, I'd suggest
to keep Java module related options at a single place.
On Mon, 23 Aug 2021 13:57:36 GMT, Christian Stein wrote:
> Enabled actions on my fork - do I need to do something to trigger them now
> manually?
You need to push a (possibly empty) commit to your branch.
-
PR: https://git.openjdk.java.net/jfx/pull/608
On Mon, 23 Aug 2021 10:48:23 GMT, Christian Stein wrote:
> https://bugs.openjdk.java.net/browse/JDK-8267472
Enabled actions on my fork - do I need to do something to trigger them now
manually? They don't seem to start:
https://github.com/sormuras/jfx/actions/workflows/submit.yml
-
On Mon, 23 Aug 2021 10:48:23 GMT, Christian Stein wrote:
> https://bugs.openjdk.java.net/browse/JDK-8267472
@sormuras Can you enable GitHub actions runs for your personal fork of `jfx`?
That way we can see the test results as part of the review of this PR. See
[Checks](https://github.com/openj
On Mon, 23 Aug 2021 10:48:23 GMT, Christian Stein wrote:
> https://bugs.openjdk.java.net/browse/JDK-8267472
Looks good to me. Only, since gradle 6.4 (see
https://github.com/gradle/gradle/issues/2177), you can directly set the module
version like this:
project.compileJava {
...
On Mon, 23 Aug 2021 10:48:23 GMT, Christian Stein wrote:
> https://bugs.openjdk.java.net/browse/JDK-8267472
This looks good. I'm running the build process and will report once finished.
-
PR: https://git.openjdk.java.net/jfx/pull/608
On Mon, 23 Aug 2021 10:48:23 GMT, Christian Stein wrote:
> https://bugs.openjdk.java.net/browse/JDK-8267472
Even though this is a straightforward change, I'd like two reviewers.
-
PR: https://git.openjdk.java.net/jfx/pull/608
https://bugs.openjdk.java.net/browse/JDK-8267472
-
Commit messages:
- Compile version information into modules
Changes: https://git.openjdk.java.net/jfx/pull/608/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=608&range=00
Issue: https://bugs.openjdk.java.net/browse/J
24 matches
Mail list logo
