On Fri, 29 Oct 2021 22:18:58 GMT, John Hendrikx wrote:
>> This PR does not add any additional feature. It restores the behavior of
>> jfx16, where any character is acceptable as a mnemonic, and the first
>> mnemonic is selected.
>
> Okay, the wording of the JBS ticket suggested something else,
On Sat, 30 Oct 2021 14:18:42 GMT, Michael Strauß wrote:
> there is no need for the class rename, is there?
>
> Even though it's formally internal api, I think we shouldn't do code breaking
> changes except if there's a very compelling reason - there are too many apps
> out in the wild that
On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Sat, 30 Oct 2021 14:12:17 GMT, Jeanette Winzenburg
wrote:
> there is no need for the class rename, is there?
>
> Even though it's formally internal api, I think we shouldn't do code breaking
> changes except if there's a very compelling reason - there are too many apps
> out in the wild
On Sat, 30 Oct 2021 09:46:13 GMT, Jeanette Winzenburg
wrote:
>> I don't see an easy way to do that, and I'm not in favor of making private
>> implementation details package-public just to test some internal state. Of
>> course, mnemonic support should have been designed in a way that is more
On Sat, 30 Oct 2021 09:46:13 GMT, Jeanette Winzenburg
wrote:
>> I don't see an easy way to do that, and I'm not in favor of making private
>> implementation details package-public just to test some internal state. Of
>> course, mnemonic support should have been designed in a way that is more
On Fri, 29 Oct 2021 23:14:07 GMT, Michael Strauß wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
>> line 2162:
>>
>>> 2160: label.autosize();
>>> 2161: skin.updateDisplayedText();
>>> 2162: assertEquals("foo _bar _qux",
On Fri, 29 Oct 2021 20:19:02 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed javadoc
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
> line
On Fri, 29 Oct 2021 20:54:04 GMT, Michael Strauß wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java
>> line 188:
>>
>>> 186: int i = 0;
>>> 187:
>>> 188: // Parse the input string and stop after the first mnemonic.
>>
>>
On Fri, 29 Oct 2021 20:26:56 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed javadoc
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java
>
On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Fri, 29 Oct 2021 13:45:24 GMT, Ajit Ghaisas wrote:
>> Done.
>
> The corresponding comment for the method isSimpleMnemonic() also needs
> correction.
> You can limit it to -
>
> /**
> * Determines whether the string contains a simple mnemonic at the
> specified position.
> * A
> This PR fixes an issue with mnemonic parsing by removing the restriction that
> a mnemonic symbol must be a letter. Now, it can be any character except
> whitespace.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
changed
16 matches
Mail list logo
