On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()* listener*
>> - Null check
On Thu, 8 Jul 2021 21:05:51 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
>> line 324:
>>
>>> 322:
>>> 323: comboBox.layout();
>>> 324:
>>
>> KISS again :)
>>
>> - buttonCell is unrelated
>> - setting the value is a not
On Sun, 11 Jul 2021 18:28:24 GMT, Marius Hanl wrote:
>>>
>>>
>>> Hmm, but leaving a test without an assert is also bad. You have any
>>> suggestions?
>>
>> Not aware of such a rule - if we fix code throwing an exception there is not
>> much to assert, except that it fails before and passes
On Fri, 9 Jul 2021 09:58:38 GMT, Jeanette Winzenburg
wrote:
>> Hmm, but leaving a test without an assert is also bad. You have any
>> suggestions?
>> I may can add another editable test, which will pass before and after.
>
>>
>>
>> Hmm, but leaving a test without an assert is also bad. You
On Thu, 8 Jul 2021 21:04:44 GMT, Marius Hanl wrote:
>
>
> Hmm, but leaving a test without an assert is also bad. You have any
> suggestions?
Not aware of such a rule - if we fix code throwing an exception there is not
much to assert, except that it fails before and passes after. And
On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()* listener*
>> - Null check
On Thu, 8 Jul 2021 10:52:06 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fixed NPE for setEditable() and layoutChildren()
>> - removed unneeded button cell in test
>
>
On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()* listener*
>> - Null check
On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()* listener*
>> - Null check
> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null.
>
> ChoiceBox:
> - Null check in **valueProperty()** listener
>
> ComboBox:
> - Null check in **valueProperty()** listener
> - Null check in **ComboBoxListViewSkin#updateValue()**
>
> The tests checks, that no NPE
10 matches
Mail list logo
