Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v4]

2021-11-03 Thread Michael Strauß
On Fri, 16 Apr 2021 10:45:18 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v4]

2021-04-16 Thread Kevin Rushforth
On Fri, 16 Apr 2021 10:45:18 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Kevin Rushforth
On Fri, 16 Apr 2021 08:46:49 GMT, Johan Vos wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 1305: >> >>> 1303: // Otherwise, our goal is to leave the index of the cell >>> at the >>> 1304: // top consistent, with the

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v4]

2021-04-16 Thread Ajit Ghaisas
On Fri, 16 Apr 2021 10:45:18 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v4]

2021-04-16 Thread Johan Vos
> This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in related issues) is that the > VirtualFlow implementation depends on

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v3]

2021-04-16 Thread Johan Vos
On Fri, 16 Apr 2021 10:03:07 GMT, Ajit Ghaisas wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java >

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v3]

2021-04-16 Thread Ajit Ghaisas
On Fri, 16 Apr 2021 09:00:19 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Ajit Ghaisas
On Fri, 16 Apr 2021 08:47:42 GMT, Johan Vos wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java >> line 1315: >> >>> 1313: s1 = sb.getLayoutY(); >>> 1314: newDelta = newPosition - position; >>> 1315:

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v3]

2021-04-16 Thread Johan Vos
> This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in related issues) is that the > VirtualFlow implementation depends on

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Johan Vos
On Thu, 15 Apr 2021 07:53:50 GMT, Ajit Ghaisas wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Johan Vos
On Mon, 12 Apr 2021 13:10:44 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Johan Vos
On Thu, 15 Apr 2021 07:22:29 GMT, Ajit Ghaisas wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java >

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-15 Thread Ajit Ghaisas
On Mon, 12 Apr 2021 09:41:03 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-15 Thread Ajit Ghaisas
On Mon, 12 Apr 2021 09:41:03 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-12 Thread Kevin Rushforth
On Mon, 12 Apr 2021 09:41:03 GMT, Johan Vos wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-12 Thread Kevin Rushforth
On Mon, 12 Apr 2021 09:32:27 GMT, Johan Vos wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 2972: >> >>> 2970: // Make sure we have enough space in the cache to store this >>> index >>> 2971: while (idx >=

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:12:54 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-12 Thread Johan Vos
> This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in related issues) is that the > VirtualFlow implementation depends on

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Tue, 9 Feb 2021 12:21:28 GMT, Johan Vos wrote: > This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in related issues)

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:32:28 GMT, Kevin Rushforth wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:29:39 GMT, Kevin Rushforth wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:27:47 GMT, Kevin Rushforth wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-09 Thread Kevin Rushforth
On Tue, 9 Feb 2021 12:21:28 GMT, Johan Vos wrote: > This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in related issues)