On Fri, 11 Jun 2021 11:38:33 GMT, Ambarish Rapte wrote:
>> Hello Nir, could you please merge this branch with latest master.
>
>> I think so too. Did you test on Win? Does @arapte want to test these
>> functions too?
>
> Yes, I shall test too, and get back to the review...
> @arapte If you
On Tue, 25 May 2021 09:36:55 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> Hello Nir, could you please merge this branch with latest master.
> I think so too. Did you
On Tue, 25 May 2021 14:40:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 171:
>
>> 169: *
On Tue, 25 May 2021 14:35:14 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 142:
>
>> 140:
>>
On Tue, 25 May 2021 11:30:25 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 49:
>
>> 47: *
>>
On Tue, 25 May 2021 10:53:37 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGShape3D.java
> line 167:
>
On Mon, 24 May 2021 05:08:13 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
On Mon, 24 May 2021 05:08:13 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that
