On Thu, 28 May 2020 15:23:38 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 402:
>>
>>> 401: */
>>> 402: private void doSetCurrentRate(double value) {
>>> 403: if (currentRate != null || !areNearEqual(value,
>>> DEFAULT_
On Thu, 28 May 2020 15:16:03 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 332:
>>
>>> 331: }
>>> 332: if (isNearZero(newRate)) {
>>> 333: if (isRunning()) {
>>
>> The code
On Tue, 26 May 2020 21:53:44 GMT, Kevin Rushforth wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 26 May 2020 21:12:07 GMT, Kevin Rushforth wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Fri, 24 Apr 2020 00:58:30 GMT, Nir Lisker wrote:
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with `EPSI
On Mon, 11 May 2020 04:44:27 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal w
On Wed, 13 May 2020 12:29:03 GMT, Kevin Rushforth wrote:
>> I agree that these methods are better suited there, but I'm not sure the
>> same epsilon value will be suitable for other
>> places that will want to use these. That value is somewhat arbitrary anyway
>> I think.
>
> Either is fine wit
On Wed, 13 May 2020 00:38:03 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/MultiLoopClipEnvelope.java
>> line 48:
>>
>>> 47:
>>> 48: protected boolean autoReverse() {
>>> 49: return autoReverse;
>>
>> I would suggest the name to b
On Thu, 7 May 2020 08:50:23 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal wi
On Wed, 13 May 2020 00:17:17 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
>> line 46:
>>
>>> 45: */
>>> 46: public abstract class ClipEnvelope {
>>> 47:
>>
>> I think the removal of line 46 was unintended change.
>
> I thi
On Tue, 5 May 2020 05:47:30 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal wi
On Mon, 11 May 2020 04:30:28 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal w
On Wed, 6 May 2020 14:18:06 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal wi
On Tue, 5 May 2020 11:19:55 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal wi
On Fri, 24 Apr 2020 00:58:30 GMT, Nir Lisker wrote:
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with `EPSI
On Fri, 24 Apr 2020 00:58:30 GMT, Nir Lisker wrote:
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with `EPSI
16 matches
Mail list logo
