On Thu, 28 Oct 2021 13:50:40 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The
On Thu, 28 Oct 2021 13:50:40 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Wed, 27 Oct 2021 09:36:20 GMT, Ambarish Rapte wrote:
>> Andreas Heger has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8255015: testScene variable must be volatile and new line at the end of
>> the file added
>
>
On Tue, 26 Oct 2021 19:48:41 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The
On Tue, 26 Oct 2021 19:48:41 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The
On Mon, 25 Oct 2021 23:50:09 GMT, Kevin Rushforth wrote:
>> Andreas Heger has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>>
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Sun, 24 Oct 2021 17:23:40 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The
On Sun, 24 Oct 2021 16:04:40 GMT, Andreas Heger wrote:
> I tried to use the Node.snapshot method, but in this case the taken snapshot
> always had the correct illumination, no matter what display was used and even
> though the scene on the display showed the wrong illumination. I guess the
>
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Mon, 20 Sep 2021 14:11:50 GMT, Kevin Rushforth wrote:
>> @kevinrushforth
>>> The fix looks good. I tested it both in isolation and with PR #334 and it
>>> works on both a retina and non-retina display.
>>>
>>> If you have time to write an automated test, that would be useful, but if
>>>
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Mon, 20 Sep 2021 14:11:50 GMT, Kevin Rushforth wrote:
>> @kevinrushforth
>>> The fix looks good. I tested it both in isolation and with PR #334 and it
>>> works on both a retina and non-retina display.
>>>
>>> If you have time to write an automated test, that would be useful, but if
>>>
On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger
wrote:
>> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix
>> looks promising. Have you tested this on Windows with Hi-DPI to make sure
>> there is no impact? Would you be able add an automated test case that fails
>>
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger
wrote:
> Ok, I will try to write an automated test case which draws a sphere in a
> SubScene and then calculates the average color of the generated image. The
> test will be passed if the calculated average does not differ from the
> excepted
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The
On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger
wrote:
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
>
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
> I intend to test this alone and in connection with your PR.
Alright. I'll keep an eye on this PR.
-
PR: https://git.openjdk.java.net/jfx/pull/531
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix looks
> promising. Have you tested this on Windows with Hi-DPI to make sure there is
> no impact?
No, I only have got MacOS on retina / non retina and a non Hi-DPI
On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger
wrote:
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
>
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
30 matches
Mail list logo
