On Wed, 31 Mar 2021 13:20:09 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java
>> line 42:
>>
>>> 40:
>>> 41: import static junit.framework.Assert.assertEquals;
>>> 42:
>>
>> shouldn't that be `org.junit.Assert.*` ?
>
>
On Wed, 31 Mar 2021 12:32:02 GMT, Jeanette Winzenburg
wrote:
>
>
> Fix looks good, verified failing/passing test before/after fix. Left minor
> comments inline.
>
> As to the test - good to increase test coverage by including tests for
> invisible columns, IMO :)
>
> Two thingies you
On Wed, 31 Mar 2021 12:18:54 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8258663: Using VirtualFlowTestUtils in tests now instead of own solution
>> -> cleaner code
>
>
On Wed, 31 Mar 2021 12:00:39 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8258663: Using VirtualFlowTestUtils in tests now instead of own solution
>> -> cleaner code
>
>
On Tue, 30 Mar 2021 15:54:37 GMT, Marius Hanl
wrote:
>> This PR fixes an issue, where table cells are not removed from the table row
>> when the corresponding table column got removed. This will lead to empty
>> "ghost" cells laying around in the table.
>> This bug only occurs, when a fixed
On Tue, 30 Mar 2021 13:27:21 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8258663: Using VirtualFlowTestUtils in tests now instead of own solution
>> -> cleaner code
>
>
> This PR fixes an issue, where table cells are not removed from the table row
> when the corresponding table column got removed. This will lead to empty
> "ghost" cells laying around in the table.
> This bug only occurs, when a fixed cell size is set to the table.
>
> I also added 3 more tests
