On Wed, 31 Mar 2021 13:20:09 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java >> line 42: >> >>> 40: >>> 41: import static junit.framework.Assert.assertEquals; >>> 42: >> >> shouldn't that be `org.junit.Assert.*` ? > > I don't think @kleopatra was referring to whether or not to use a wild-card > import, but rather that the `Assert` class should be imported from the > `org.junit` package instead of `junit.framework`. We are inconsistent in our > usage in some of the older tests, but yes, we should use `org.junit`. Oh, alright, didn't saw that. I will change it. :) ------------- PR: https://git.openjdk.java.net/jfx/pull/444
