On Wed, 31 Mar 2021 12:18:54 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8258663: Using VirtualFlowTestUtils in tests now instead of own solution >> -> cleaner code > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java > line 42: > >> 40: >> 41: import static junit.framework.Assert.assertEquals; >> 42: > > shouldn't that be `org.junit.Assert.*` ? I don't think @kleopatra was referring to whether or not to use a wild-card import, but rather that the `Assert` class should be imported from the `org.junit` package instead of `junit.framework`. We are inconsistent in our usage in some of the older tests, but yes, we should use `org.junit`. ------------- PR: https://git.openjdk.java.net/jfx/pull/444
