[10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8185634 -- Thanks, Alexander.

[webkit][10] Review request - 8187726: Copy and Paste of Image not resulting in expected behavior

Hi all, Please review a patch for fixing Copy and Paste functionality in FX WebView. Details in JBS. JBS : https://bugs.openjdk.java.net/browse/JDK-8187726 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187726/webrev.00/ Thanks, Rajath

[webkit][10] Review request - 8187671: Drag and Drop of text or html results in an image

Hi all, Please review a bug fix done for `Drag and Drop use case in WebView` explained in the JBS JBS : https://bugs.openjdk.java.net/browse/JDK-8187671 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187671/webrev.00/ Thanks, Rajath

[10] Review request : JDK-8089265 : [ProgressIndicator] behaves itself wrong, when aligned

Hi Jonathan, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8089265 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089265/webrev.0/ Regards, Ajit

[webkit][10] Review request - 8089124: HTML5: Number input allows non-numeric input

Hi all, Please review the patch for enabling HTML5 form validation. With this enabled, WebKit would by default show validation specific error message dialogs using Shadow DOM + CSS styled web elements. This will serve as a placeholder until the FX platform implementation

[10] Review request: 8187043: JavaFX fails to launch on some Windows platforms due to missing VS2017 libraries

Please review the following fix for a critical regression introduced in 10 (and 9.x) due to the VS 2017 compiler upgrade that was done as part of the recent WebKit update: https://bugs.openjdk.java.net/browse/JDK-8187043 http://cr.openjdk.java.net/~kcr/8187043/webrev.00/ -- Kevin

[webkit][10] Review request: 8170955: HTML5 canvas shadow properties should not be affected by transform

Hi Arun & Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8170955 <https://bugs.openjdk.java.net/browse/JDK-8170955> webrev : http://cr.openjdk.java.net/~ghb/8170955/webrev.00/ <http://cr.openjdk.java.net/~ghb/8170955/webrev.00/> Thanks, Guru

[webkit][10] Review request - 8185314: Remove unused third-party python scripts from WebKit sources

Hi Guru\Arun, Please review this simple cleanup of unused third-party library download scripts. JBS : https://bugs.openjdk.java.net/browse/JDK-8185314 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8185314/webrev.00/ Thanks, Rajath

Re: Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

is about. > Seems like you should close it as a dup. and return to the previous bug ? > > -phil. > > On 8/18/17, 2:05 AM, Manajit Halder wrote: >> Hi Phil, >> >> Please review the fix. >> >> Regards, >> Manajit >> >>> On 08

Re: Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

Hi Phil, Please review the fix. Regards, Manajit > On 08-Aug-2017, at 4:52 PM, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Kindly review the following JavaFx fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8185954 > <https:/

[10] Review request: 8186237 Refactor jdk.packager to legacy package

Victor, Please review this refactor to get ready for the new CLI. JIRA: https://bugs.openjdk.java.net/browse/JDK-8186237 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8186237/webrev.00/ Chris

Re: [10] Review request : JDK-8090462 : CSS performance: Link style helpers together to avoid going through parent chain looking for parent style helpers

Ajit, I have provided some comments in the bug. On 8/10/17 8:45 AM, Ajit Ghaisas wrote: Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8090462 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8090462/webrev.2/ Regards

[10] Review request for 8185970: Possible crash due to use-after-free

  Hi, Please review the below fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185970   Webrev: http://cr.openjdk.java.net/~mbilla/8185970/webrev.00/   Thanks, Murali

Re: [Review request] 8185767: Fix broken links in Javadocs

I've scanned through it, and it looks generally OK to me. -- Jon On 08/03/2017 05:33 PM, Jonathan Giles wrote: Jon, Kevin and / or Phil, Please review the webrev below. It improves the JavaFX javadocs such that there are (hopefully) no bad links any longer. https://bugs.openjdk.java.net

Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

Hi All, Kindly review the following JavaFx fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8185954 <https://bugs.openjdk.java.net/browse/JDK-8185954> Webrev: http://cr.openjdk.java.net/~mhalder/fx/8185954/webrev.02/ <http://cr.openjdk.java.net/~mhalder/fx/8185954/webrev.02/> No

[10] Review request for 8182977: NullPointerException with HTMLEditor when changing the scene graph

  Hi, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182977   Webrev: http://cr.openjdk.java.net/~mbilla/8182977/webrev.00/   Thanks, Murali

[10] Review request for 8183928: [Linux] Remove Warnings [-Wunused-parameter]

  Hi, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8183928   Webrev: http://cr.openjdk.java.net/~mbilla/8183928/webrev.00/   Thanks, Murali

[10] Review request: 8185804: rpath is not set properly in OSX build

Hi, Please review the simple fix for the following bug, https://bugs.openjdk.java.net/browse/JDK-8185804 Detailed analysis and fix is updated as JBS comment. Thanks, Arun

Review Request 8176813: Mac: Failure to exit full-screen programmatically in some cases

Please review the webrev below which tries to fix the issue of GetApplication processed for Null values. Any alternatives or suggestions are welcome. This fixes the issue presented by the description. https://bugs.openjdk.java.net/browse/JDK-8176813 <https://bugs.openjdk.java.net/browse/

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

Hi Kevin, Hi Jonathan, Request you to review the fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.04/ Regards, Ambarish

[Review request] 8178519: Consider removing two-level focus support from UI controls

Kevin, Phil, Could you please review the webrev below, which aims to remove the unused two-level focus code that presently ships in JDK 9 and earlier releases. https://bugs.openjdk.java.net/browse/JDK-8178519 http://cr.openjdk.java.net/~jgiles/8178519/ Thanks, -- -- Jonathan

[10] Review request for 8185691: MediaPlayer reports error with HTTP Live Streams instead of EOS

Hi Kevin and David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8185691 Fixed issue when error was send instead of EOS for HTTP Live Streaming. Thanks, Alexander

[10] Review request for 8183530: JavaFX charts peg rendering thread as more data is added

JBS: https://bugs.openjdk.java.net/browse/JDK-8183530 webrev: http://cr.openjdk.java.net/~flar/JDK-8183530/webrev.03/ ...jim

[10] Review request for 8184453: [Win] DRT crashes for imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html

  Hi, Please review the below fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184453 Webrev: http://cr.openjdk.java.net/~mbilla/8184453/webrev.00/ Thanks, Murali

Review request for JDK-8130904: disabled tabs in a inner tabpane show like enabled

Hi Jonathan, Hi Ajit, Request you to review this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8130904 Webrev: http://cr.openjdk.java.net/~arapte/fx/8130904/webrev.00/ Regards, Ambarish

[10] Review request: 8184448: Crash while loading gif images with more frames

Hi, Please review the following changset, Webrev: http://cr.openjdk.java.net/~arajkumar/8184448/webrev.01 Bug: https://bugs.openjdk.java.net/browse/JDK-8184448 Detailed analysis is updated as JBS comment. Thanks, Arun

[10] Review request: 8185132: window.requestAnimationFrame API is not working

Hi, Please review the following changset, Webrev: http://cr.openjdk.java.net/~arajkumar/8185132/webrev Bug: https://bugs.openjdk.java.net/browse/JDK-8185132 Detailed analysis is updated as JBS comment. Thanks, Arun

[10] Review request for 8185138: Build hangs and fills up disk on Windows with VS 2013 or 2010

  Hi Kevin, Arun, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185138 Webrev: http://cr.openjdk.java.net/~mbilla/8185138/webrev.00/   Thanks, Murali

[10] Review request: 8183292: Update to 604.1 version of WebKit

/main/native", it will be useful only for review. 2. rt.changeset.gz — Actual changeset file in compressed format which contains all the changes from “rt” directory, uncompress before using it(gunzip rt.changeset.gz) and do the following steps. $ cd rt $ hg import --no-commit rt.change

Re: [10] Review request: 8185017 Fix Bad Characters

+1 Although I am puzzled why I did not hit this before. -phil. On 7/20/17, 4:34 PM, Chris Bensen wrote: Phil, Please review this fix to remove the bad characters. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185017 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8185017/webrev.00/ Chris

[10] request for review 8181779: Memory leak in FX Glass Embedded Window

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181779/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181779 -- Thanks, Alexander.

[10] Review request: 8184688: Single Instance Example

Chris, Please review my changes about adding single instance example. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184688 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184688/webrev.00/ --Victor

[10] Review request: 8184797: Copy DumpRenderTreeJava.dll from bin to lib directory

Hi Arun & Murali, Please review the fix for: JBS : https://bugs.openjdk.java.net/browse/JDK-8184797 <https://bugs.openjdk.java.net/browse/JDK-8184797> Webrev : http://cr.openjdk.java.net/~ghb/8184797/webrev.00/ <http://cr.openjdk.java.net/~ghb/8184797/webrev.00/> Thanks, Guru

[10] Review request: 8184769 Static Link to SHGetKnownFolderPath

Victor, Please review this change to remove the LoadLibray. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184769 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8184769/webrev.00/ Chris

[10] Review request: 8184301: Add new projects for jdk.packager.services and jdk.packager

Chris, Please review my changes about adding new projects for jdk.packager.services and jdk.packager JIRA: https://bugs.openjdk.java.net/browse/JDK-8184301 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184301/webrev.00 --Victor

[10] Review request: 8184077: Resolve Singleton TODO

Chris, Please review my changes about removing getSessionSpecificString() JIRA: https://bugs.openjdk.java.net/browse/JDK-8184077 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184077/webrev.0/ --Victor

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

Hi Jonathan, Please review the below fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.00/ Regards, Ambarish

[10] Review request: 8183246 Remove Platform::GetSystemJRE()

Victor, Please review this change to remove the dead code related to acquiring the system JRE for a packaged app. JIRA: https://bugs.openjdk.java.net/browse/JDK-8183246 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8183246/webrev.00/ Chris

[10] Review request: 8181291: Singleton for javapackager

Kevin, Chris, Please review my changes about Single Instance for Java Packager (compared to previous webrev, the code was modified according to CSR JDK-8181293) JIRA: https://bugs.openjdk.java.net/browse/JDK-8181291 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8175574/webrev.06

[10] Review request: 8182615: Check registry paths

Chris, Please review my changes about correcting registry paths JIRA: https://bugs.openjdk.java.net/browse/JDK-8182615 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8182615/webrev.00/ --Victor

[10] Review request: 8091418 Evaluate TODOs in code, either removing or filing issues as appropriate

Victor, Please review these changes related to the TODOs and FIXMEs in the java packager code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8091418 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8091418/webrev.00/ Chris

Re: Review Request: JDK-8176319: [macosx] problems with Character Viewer

Hi All, Please review the modified fix which is more efficient than the initial fix: http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.01/ <http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.01/> Regards, Manajit > On 30-Jun-2017, at 3:13 PM, Manajit Halder <manajit.hal..

[10] Review request: 8178360: Build and integrate ICU from source

Hi Kevin, Arun and Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8178360 <https://bugs.openjdk.java.net/browse/JDK-8178360> Webrev : http://cr.openjdk.java.net/~ghb/8178360/webrev.07 <http://cr.openjdk.java.net/~ghb/8178360/webrev.07> (Modified S

[10] Review request: 8182778 Debug JDK Additions

Kevin, Victor, Please review these additions to the Java Packager debug JDK. This change will bundle the jdk.packager.services module with the resulting application and cleans up the gradle sourceSet. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182778 Webrev: http://cr.openjdk.java.net

[10] Review Request : JDK-8167139 Menu's selection disappears on collapsing

Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8167139 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167139/webrev.00/ Regards, Prem

[10] Review Request: JDK-8179399 - Call trim() when loaded jre.list (Vivek Rao)

Hi, Chris, Victor, Please review the following change for fixing the “stripComments” method for redistributableModules. Bug URL: https://bugs.openjdk.java.net/browse/JDK-8179399 <https://bugs.openjdk.java.net/browse/JDK-8179399> Webrev: http://cr.openjdk.java.net/~vrao/JDK-8179399/

[10] Review request: JDK-8181738 Remove com.sun.tools.jdeps to jdk.packager

Kevin, Victor, Please review this change following JDK-8179445 to remove the qualified exports of com.sun.tools.jdeps: <https://bugs.openjdk.java.net/browse/JDK-8179445> JIRA: https://bugs.openjdk.java.net/browse/JDK-JDK-8181738 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-JDK-8181738/

Re: [9] Review request: 8180338: Additional HTML5 cleanup

e outdated "faq.html" is removed. http://cr.openjdk.java.net/~kcr/8180338/webrev.02/ -- Kevin Kevin Rushforth wrote: Hi Jon, Can you review this simple change to the three .html files (other than package.html) in the FX docs? https://bugs.openjdk.java.net/browse/JDK-8180338 http://cr.o

[10] Review request: JDK-8181976 - Specifying desired dimensions for Image with HiDPI (@2x) variant gets the size wrong

JBS: https://bugs.openjdk.java.net/browse/JDK-8181976 webrev: http://cr.openjdk.java.net/~flar/JDK-8181976/webrev.00/ Simple fix is to carry the double "size requested" values all the way down to where the image pixel scale is determined (not strictly required, but important for precision) and

[10] Review request: JDK-8179445: Use jdeps ToolProvider

Chris, Kevin Please review my changes about jdeps ToolProvider JIRA: https://bugs.openjdk.java.net/browse/JDK-8179445 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8179445/webrev.00/ --Victor

[9] Review request: 8181829: Broken link to css reference guide in Background documentation

Phil or Jonathan, Please review the simple fix for a broken javadoc link: https://bugs.openjdk.java.net/browse/JDK-8181829 The diff for the proposed fix, which is also in JBS, is: diff --git a/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java b/modules

[9] Review request: 8181828: Broken Image link in documentation for Tangent interpolator

Jim or Phil, Please review the simple fix to move tangent_interpolator.png to the correct module. https://bugs.openjdk.java.net/browse/JDK-8181828 The diff for the proposed fix, which is also in JBS

[10] Review request: JDK-8167209 Menu bar is not selected by right ALT key

Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8167209 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167209/webrev.00/ Regards, Prem

[10] Review request: JDK-8087978 : ProgressIndicator text disappears when using a larger font

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8087978 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8087978/webrev.1/ Regards, Ajit

[10] Review request for 8089283 : Padding property of the select tag is incorrect in WebView

Hi Kevin, Please review the proposed fix: Webrev : http://cr.openjdk.java.net/~asrivastava/dipak/8089283/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8089283 DRT and unit test cases are running fine with this change. Many thanks, Dipak

[10] Review request for 8181476 [macos] Stages with StageStyle.UTILITY are always on-top when initialized without an owner

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181476/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181476 -- Thanks, Alexander.

[Review request] 8181169: Block comments mistakenly used in place of missing javadoc comments

Kevin, Could you please review the javadoc fix here: https://bugs.openjdk.java.net/browse/JDK-8181169 http://cr.openjdk.java.net/~jgiles/8181169/index.html Thanks -- -- Jonathan

Review request : JDK-8181213 : [Tab] Tab content is not disabled when tab is disabled before content is set

Hi Jonathan & Ajit, Request you to review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8181213 Webrev: http://cr.openjdk.java.net/~arapte/fx/8181213/webrev.00/ Regards, Ambarish

[10] Review request: JDK-8088389 : [CSS, HighContrast] Menu - All the menu items look disabled on Mouse Click / Roll Over

Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8088389 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8088389/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/fx/8088389/webrev.00/ Regards, Prem

[10] Review request : JDK-8089310 : [ContextMenu] Disabled Menu Rollover never receives Mouse hover

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089310 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089310/webrev.0/ Regards, Ajit

[9] Review request: 8179644: Update copyright header for files modified in 2017

Hi Chien, Please review the following simple fix to update the copyright header dates: https://bugs.openjdk.java.net/browse/JDK-8179644 http://cr.openjdk.java.net/~kcr/8179644/webrev/ Thanks. -- Kevin

[9] Review request: 8180338: Additional HTML5 cleanup

Hi Jon, Can you review this simple change to the three .html files (other than package.html) in the FX docs? https://bugs.openjdk.java.net/browse/JDK-8180338 http://cr.openjdk.java.net/~kcr/8180338/webrev.00/ Thanks. -- Kevin

[9] Review request: 8180070: Fix additional typos in API docs

Jonathan, Please review the following fixes to various typos in the javadoc-generated API docs: https://bugs.openjdk.java.net/browse/JDK-8180070 http://cr.openjdk.java.net/~kcr/8180070/webrev.00/ Thanks. -- Kevin

[9] Review request: JDK-8180368: javapackager.exe fails to launch: Unrecognized option: -m

Kevin, Please review my changes about removing the code that constructs java cmd based on JAVA_HOME. JIRA: https://bugs.openjdk.java.net/browse/JDK-8180368 Webrev: webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8180368/webrev.00/ --Victor

[9] Review request: 8180064: Add missing copyright headers to package.html files

Jonathan, Please review the following simple fix to add proper copyright headers to each package.html file and also the three other .html files in our doc-files directories: https://bugs.openjdk.java.net/browse/JDK-8180064 http://cr.openjdk.java.net/~kcr/8180064/webrev/ Thanks. -- Kevin

Re: [8] Code Review Request For 8180180: [Mac] WebView renders icons instead of letters on some sites

Hi Dipak, Since this is the backport for JDK-8088205 the review should ideally be in a folder with that bug ID. Note that the commit message *must* use the base bugID and *never* the backport ID. Nothing should ever reference the backport ID, and the only thing that would go into the JBS

[9] Review request: 8180337: JavaFX 9 msg drop 40 l10n resource file update

I am posting this review on behalf of Leo Jiang (ljiang). https://bugs.openjdk.java.net/browse/JDK-8180337 http://cr.openjdk.java.net/~kcr/8180337/webrev/ This is the last planned translation drop for localized resource message for FX in JDK 9. -- Kevin

[8] Code Review Request For 8180180: [Mac] WebView renders icons instead of letters on some sites

Hi Philip, Kevin and Arun, Please review the below changes: JBS: https://bugs.openjdk.java.net/browse/JDK-8180180 Webrev: http://cr.openjdk.java.net/~arajkumar/dipak/8180180/webrev/ Please note that this is a backport for JBS - HYPERLINK "https://bugs.openjdk.java.net/brows

[10] Review request: 8179673: JVM Crash in WebPage.setBackgroundColor() during webpage navigation (Non Public API)

Hi Arun, Murali & Kevin, Please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8179673 <https://bugs.openjdk.java.net/browse/JDK-8179673> Webrev : http://cr.openjdk.java.net/~ghb/8179673/webrev.00/ <http://cr.openjdk.java.net/~ghb/8179673/webrev.00/> Thanks, Guru

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Hi Kevin, On 05/10/2017 03:19 AM, Kevin Rushforth wrote: inline Peter Levart wrote: Hi Kevin, On 05/02/2017 02:21 AM, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK

Review Request: JDK-8179514: [macosx] Maximize button is enabled for non-resizable parent window when child window is opened

Hi All, Kindly review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8179514 <https://bugs.openjdk.java.net/browse/JDK-8179514> Webrev: http://cr.openjdk.java.net/~aniyogi/8179514/webrev.00/ <http://cr.openjdk.java.net/~aniyogi/8179514/webrev.00/> With Regards, Avik Niyogi

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

that change this late in 9). Thanks again. -- Kevin Mandy Chung wrote: On May 9, 2017, at 6:52 PM, Kevin Rushforth <kevin.rushfo...@oracle.com <mailto:kevin.rushfo...@oracle.com>> wrote: Thanks for the review. We currently don't use package-info.java anywhere, but I can file a

[10] Review request : JDK-8089840 : Disabled menu items are invisible with 100% contrast display settings

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089840 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089840/webrev.0/ Regards, Ajit

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

> On May 9, 2017, at 6:52 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > Thanks for the review. We currently don't use package-info.java anywhere, but > I can file a separate bug for converting all of our package.html to > package-info.java. That

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

Thanks for the review. We currently don't use package-info.java anywhere, but I can file a separate bug for converting all of our package.html to package-info.java. I can add the the missing copyright headers at the same time. -- Kevin Mandy Chung wrote: On May 9, 2017, at 6:08 PM, Kevin

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

> On May 9, 2017, at 6:08 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > Please review the following to exclude jdk.packager module from the JDK docs > bundle: > > https://bugs.openjdk.java.net/browse/JDK-8180040 > http://cr.openjdk.java.net/~kcr/

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

Looks ok to me. /Erik On 2017-05-09 18:08, Kevin Rushforth wrote: Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

inline Peter Levart wrote: Hi Kevin, On 05/02/2017 02:21 AM, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-8177566 http://cr.openjdk.java.net/~kcr/8177566/webrev.00

[10] Review request: JDK-8179946 - Objects are not rendered for certain rotation angle and cache hint combinations

JBS: https://bugs.openjdk.java.net/browse/JDK-8179946 webrev: http://cr.openjdk.java.net/~flar/JDK-8179946/webrev.00/ This should get back-ported to 9 as well, as soon as makes sense... ...jim

[9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package description for the jdk.packager.services package

[9] Review request: 8177341: Fix typos in FX API docs

Please review the following accumulated javadoc changes: https://bugs.openjdk.java.net/browse/JDK-8177341 http://cr.openjdk.java.net/~kcr/8177341/webrev.00/ Thanks. -- Kevin

Re: [10] Review request for 8179597: Handle cut and paste of 1, 2 and 4 byte characters

yes, that was a typo. Actually, the fix is for 10. --Semyon On 5/8/2017 8:20 AM, Kevin Rushforth wrote: Please review the fix for jfx9: I presume this is a typo and you meant to say jfx10? -- Kevin Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: h

Re: [10] Review request for 8179597: Handle cut and paste of 1, 2 and 4 byte characters

Please review the fix for jfx9: I presume this is a typo and you meant to say jfx10? -- Kevin Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8179597 webrev: http://cr.openjdk.java.net/~ssadetsky/8179597/we

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Hi Kevin, On 05/02/2017 02:21 AM, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-8177566 http://cr.openjdk.java.net/~kcr/8177566/webrev.00/complete-webrev/ Details

[10] Review request for 8179597: Handle cut and paste of 1, 2 and 4 byte characters

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8179597 webrev: http://cr.openjdk.java.net/~ssadetsky/8179597/webrev.00/ --Semyon

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

This seems like something that could be useful, although at this point in the release we would more likely do it for JDK 10. I do note that including the class that made the illegal access is generally a good idea when that class is attempting the access on its own behalf. For frameworks such

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

If there is not already such an exception, it would seem like a good idea to have an exception that formats such a message from constructor parameters providing the details so that it’s the same everywhere, and so that it can be changed in once place if needed. Gregg > On May 3, 2017, at 9:48

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Mandy Chung wrote: Looks good. Thank you for your help on this and for your review. "Deploying an Application as a Module” section is duplicated in several JavaBean*Property classes. One alternative is to move it to the package summary. I have no objection to leave it as is.

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

n the tests > > * Delta webrev for the doc changes: > > http://cr.openjdk.java.net/~kcr/8177566/webrev.01/delta-doc-only.00/ > > * The sparse javadocs are also updated here: > > http://cr.openjdk.java.net/~kcr/8177566/webrev.01/javadoc/ > > -- Kevin > > > Kevin Rushforth

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

.00/ * The sparse javadocs are also updated here: http://cr.openjdk.java.net/~kcr/8177566/webrev.01/javadoc/ -- Kevin Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Forgot to respond to this: Also in MethodUtil::invoke 61if (!module.isExported(packageName)) { You can do this check only if module.isNamed. No, this check will work fine on an unnamed module. Module::isExported and Module::isOpen always return true for Module::unnamed. --

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

OK, I'll create a more informative message. I think it will be more clear in the message to just say that it needs to "open" the package to javafx.base, since that would be the recommendation for a package that isn't already exported unconditionally. I'll send out a new webrev this morning

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

> On May 2, 2017, at 2:22 PM, Kevin Rushforth > wrote: > > Here is the message: > > IllegalAccessException: class com.sun.javafx.property.MethodHelper cannot > access class com.foo (in module foo.app) because module foo.app does not open > com.foo to javafx.base

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Hi Kevin, > On May 1, 2017, at 5:21 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > This review is being cross-posted to both openjfx-dev and jigsaw-dev. > > Please review the proposed fix for: > > https://bugs.openjdk.java.net/browse/JDK-817756

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

017 01:21, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-8177566 http://cr.openjdk.java.net/~kcr/8177566/webrev.00/complete-webrev/ Details of the fix as well as notes to reviewers

[9] Code Review Request For 8179321: WebEngine.getDocument().getDocumentURI() no longer returns null for loading a String of HTML

Hi Kevin, Guru, Please review the following fix, JIRA: https://bugs.openjdk.java.net/browse/JDK-8179321 <https://bugs.openjdk.java.net/browse/JDK-8179321> Webrev: http://cr.openjdk.java.net/~arajkumar/8179321/webrev/ <http://cr.openjdk.java.net/~arajkumar/8179321/webrev/> Thanks, Arun

[9] Review request: 8179363 Errors in Redistributable Module List

Kevin, Victor, Please review this change to fix the redistributable file list. JIRA: https://bugs.openjdk.java.net/browse/JDK-8179363 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8179363/webrev.00/ Chris

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

OK. I'll make that change as part of JDK-8177341. -- Kevin Alex Buckley wrote: Yes, I recommend not pointing ordinary consumers of JavaFX to java.lang.reflect.Module::add* methods. If open-ness is ever mentioned (and as you know, I do like it to be acknowledged), then it can be

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

Yes, I recommend not pointing ordinary consumers of JavaFX to java.lang.reflect.Module::add* methods. If open-ness is ever mentioned (and as you know, I do like it to be acknowledged), then it can be parenthetical. Alex On 4/21/2017 4:08 PM, Kevin Rushforth wrote: OK, so you recommend

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

OK, so you recommend changing module-info.class to module-info.java and removing the reference to Module#addExports entirely, right? I can fix this as part of a general cleanup JBS issue [1] that is left open to pick up various typos, etc. Would you recommend the same for the FXML annotation,

<    1   2   3   4   5   6   7   8   9   10   >