Re: CFV: New OpenJFX Committer: Jerome Cambon
Vote: yes Artem On 5/14/2014 9:39 PM, Stephen F Northover wrote: I hereby nominate Jerome Cambon to be an OpenJFX Committer. Jerome Cambon is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Inspector Panel as well as the CSS Panel. Jerome has been working on SB for more than 3 years, and during last year has been responsible for approximately 500 commits to the SB 2.0 repository that we are converting to Open Source. Jerome is part of the team that has collectively done the Scene Builder 2.0 product, which is a complete re-implementation of the code base, over a period of roughly 12 months. The new code base is more than 70,000 lines of code, spread over approximately 4000 commits. Scene Builder 2.0 is in the process of being converted to the OpenJFX repository, and will be maintained out of that repository after the conversion. Votes are due by May 29, 2014. Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in [3]. [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus [3] http://openjdk.java.net/projects#project-committer
Re: CFV: New OpenJFX Committer: Eric Le Ponner
Vote: yes Artem On 5/14/2014 9:33 PM, Stephen F Northover wrote: I hereby nominate Eric Le Ponner to be an OpenJFX Committer. Eric Le Ponner is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the architect of the SB Kit API as well as the designated owner of the Content Panel. Eric has been working on SB for more than 3 years, and during last year has been responsible for approximately 1620 commits to the internal SB 2.0 repository that we are converting to Open Source. Eric is part of the team that has collectively done the Scene Builder 2.0 product, which is a complete re-implementation of the code base, over a period of roughly 12 months. The new code base is more than 70,000 lines of code, spread over approximately 4000 commits. Scene Builder 2.0 is in the process of being converted to the OpenJFX repository, and will be maintained out of that repository after the conversion. Votes are due by May 29, 2014. Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in [3]. [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus [3] http://openjdk.java.net/projects#project-committer
Re: CFV: New OpenJFX Committer: Sandra Lions-Piron
Vote: yes Artem On 5/14/2014 9:48 PM, Stephen F Northover wrote: I hereby nominate Sandra Lions-Piron to be an OpenJFX Committer. Sandra Lions-Piron is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Hierarchy Panel as well as all menu commands. Sandra has been working on SB since its inception 4 years ago, and during last year has been responsible for approximately 750 commits to the SB 2.0 repository that we are converting to Open Source. Sandra is part of the team that has collectively done the Scene Builder 2.0 product, which is a complete re-implementation of the code base, over a period of roughly 12 months. The new code base is more than 70,000 lines of code, spread over approximately 4000 commits. Scene Builder 2.0 is in the process of being converted to the OpenJFX repository, and will be maintained out of that repository after the conversion. Votes are due by May 29, 2014. Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in [3]. [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus [3] http://openjdk.java.net/projects#project-committer
Re: CFV: New OpenJFX Committer: Yves Joan
Vote: yes Artem On 5/14/2014 9:48 PM, Stephen F Northover wrote: I hereby nominate Yves Joan to be an OpenJFX Committer. Yves Joan is a significant contributor of the JavaFX Scene Builder 2.0 product, and is the designated owner of the Library Panel, Document Panel and product packaging. Yves has been working on SB since its inception 4 years ago, and during last year has been responsible for approximately 960 commits to the SB 2.0 repository that we are converting to Open Source. Yves is part of the team that has collectively done the Scene Builder 2.0 product, which is a complete re-implementation of the code base, over a period of roughly 12 months. The new code base is more than 70,000 lines of code, spread over approximately 4000 commits. Scene Builder 2.0 is in the process of being converted to the OpenJFX repository, and will be maintained out of that repository after the conversion. Votes are due by May 29, 2014. Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in [3]. [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus [3] http://openjdk.java.net/projects#project-committer
Re: CFV: New OpenJFX Committer: Mo Chicharro
Vote: yes Artem On 5/14/2014 9:48 PM, Stephen F Northover wrote: I hereby nominate Mo Chicharro to be an OpenJFX Committer. Mo Chicharro is a significant contributor of the JavaFX Scene Builder 2.0 product, and, as the visual and interaction designer, he is the designated owner of all FXML and CSS content. Mo has been working on SB since its inception 4 years ago, and during last year has been responsible for approximately 160 commits to the SB 2.0 repository that we are converting to Open Source. Mo is part of the team that has collectively done the Scene Builder 2.0 product, which is a complete re-implementation of the code base, over a period of roughly 12 months. The new code base is more than 70,000 lines of code, spread over approximately 4000 commits. Scene Builder 2.0 is in the process of being converted to the OpenJFX repository, and will be maintained out of that repository after the conversion. Votes are due by May 29, 2014. Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in [3]. [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus [3] http://openjdk.java.net/projects#project-committer
hg: openjfx/8u-dev/rt: [TEST ONLY] fix NPE in tearDown code if a test is skipped
Changeset: 56356cc2339d Author:kcr Date: 2014-05-16 06:00 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/56356cc2339d [TEST ONLY] fix NPE in tearDown code if a test is skipped ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewMouseInputTest.java
hg: openjfx/8u-dev/rt: [BUILD] correcting a typo in armv7hf.gradle
Changeset: 4a4226fffb64 Author:ddhill Date: 2014-05-16 09:31 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4a4226fffb64 [BUILD] correcting a typo in armv7hf.gradle ! buildSrc/armv7hf.gradle
hg: openjfx/8u-dev/rt: [BUILD] removing obsolete comments from armv?.gradle
Changeset: da8449c57b89 Author:ddhill Date: 2014-05-16 10:10 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/da8449c57b89 [BUILD] removing obsolete comments from armv?.gradle ! buildSrc/armv5sf.gradle ! buildSrc/armv6hf.gradle ! buildSrc/armv6sf.gradle ! buildSrc/armv7hf.gradle ! buildSrc/armv7sf.gradle
Javadocs and CSS
Should a better cross-reference or mention of CSS properties in the Javadocs? Many properties can be set via calling methods or through CSS, but when browsing the Javadocs the related CSS properties are not mentioned (at least not in most cases). The package docs for javafx.scene mention the CSS Reference Guide at the end of the description, and careful reading of that document mentions the convention used to go from JavaFX variable names to CSS property. (last paragraph of http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#introscenegraph) I think all that is needed is to mention in the JavaDocs if the property is configurable from CSS or not. Or at least mention the exceptions to the rule. For example most properties of Labeled are configurable via CSS, but "lineSpacing" and "mnemonicParsing" are *not* mentioned among the CSS properties. (http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#labeled) Scott
Re: Javadocs and CSS
Would you mind creating a bug for this? On 5/16/14, 10:38 AM, Scott Palmer wrote: Should a better cross-reference or mention of CSS properties in the Javadocs? Many properties can be set via calling methods or through CSS, but when browsing the Javadocs the related CSS properties are not mentioned (at least not in most cases). The package docs for javafx.scene mention the CSS Reference Guide at the end of the description, and careful reading of that document mentions the convention used to go from JavaFX variable names to CSS property. (last paragraph of http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#introscenegraph) I think all that is needed is to mention in the JavaDocs if the property is configurable from CSS or not. Or at least mention the exceptions to the rule. For example most properties of Labeled are configurable via CSS, but "lineSpacing" and "mnemonicParsing" are *not* mentioned among the CSS properties. (http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#labeled) Scott
Re: Javadocs and CSS
Well that would work for properties on controls but many of them are in the Skin classes and those could be different from platform to platform and theme to theme and so are an implementation detail. Tom Von meinem iPhone gesendet > Am 16.05.2014 um 16:38 schrieb Scott Palmer : > > Should a better cross-reference or mention of CSS properties in the Javadocs? > > Many properties can be set via calling methods or through CSS, but > when browsing the Javadocs the related CSS properties are not > mentioned (at least not in most cases). > > The package docs for javafx.scene mention the CSS Reference Guide at > the end of the description, and careful reading of that document > mentions the convention used to go from JavaFX variable names to CSS > property. (last paragraph of > http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#introscenegraph) > > I think all that is needed is to mention in the JavaDocs if the > property is configurable from CSS or not. Or at least mention the > exceptions to the rule. For example most properties of Labeled are > configurable via CSS, but "lineSpacing" and "mnemonicParsing" are > *not* mentioned among the CSS properties. > (http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#labeled) > > > Scott
Re: Javadocs and CSS
Created https://javafx-jira.kenai.com/browse/RT-37168 On Fri, May 16, 2014 at 10:57 AM, David Grieve wrote: > Would you mind creating a bug for this? > > > On 5/16/14, 10:38 AM, Scott Palmer wrote: >> >> Should a better cross-reference or mention of CSS properties in the >> Javadocs? >> >> Many properties can be set via calling methods or through CSS, but >> when browsing the Javadocs the related CSS properties are not >> mentioned (at least not in most cases). >> >> The package docs for javafx.scene mention the CSS Reference Guide at >> the end of the description, and careful reading of that document >> mentions the convention used to go from JavaFX variable names to CSS >> property. (last paragraph of >> >> http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#introscenegraph) >> >> I think all that is needed is to mention in the JavaDocs if the >> property is configurable from CSS or not. Or at least mention the >> exceptions to the rule. For example most properties of Labeled are >> configurable via CSS, but "lineSpacing" and "mnemonicParsing" are >> *not* mentioned among the CSS properties. >> >> (http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#labeled) >> >> >> Scott > >
[8u20] Review request for RT-32597: [SwingNode]: support high DPI displays
Jim, Kevin, Anton, Sergey, Please review: https://javafx-jira.kenai.com/browse/RT-32597 -- best regards, Anthony
Re: Javadocs and CSS
I'm not sure what you mean. I'm only talking about documentation for the public API. It's just a clarification for the existing docs. On a side note, a search of the code shows that "-fx-line-spacing" is a CSS property.. but it isn't mentioned anywhere in the CSS Reference Guide. I've created https://javafx-jira.kenai.com/browse/RT-37170 to cover that case. Scott On Fri, May 16, 2014 at 11:00 AM, Tom Schindl wrote: > Well that would work for properties on controls but many of them are in the > Skin classes and those could be different from platform to platform and theme > to theme and so are an implementation detail. > > Tom > > Von meinem iPhone gesendet > >> Am 16.05.2014 um 16:38 schrieb Scott Palmer : >> >> Should a better cross-reference or mention of CSS properties in the Javadocs? >> >> Many properties can be set via calling methods or through CSS, but >> when browsing the Javadocs the related CSS properties are not >> mentioned (at least not in most cases). >> >> The package docs for javafx.scene mention the CSS Reference Guide at >> the end of the description, and careful reading of that document >> mentions the convention used to go from JavaFX variable names to CSS >> property. (last paragraph of >> http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#introscenegraph) >> >> I think all that is needed is to mention in the JavaDocs if the >> property is configurable from CSS or not. Or at least mention the >> exceptions to the rule. For example most properties of Labeled are >> configurable via CSS, but "lineSpacing" and "mnemonicParsing" are >> *not* mentioned among the CSS properties. >> (http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#labeled) >> >> >> Scott
hg: openjfx/8u-dev/rt: 2 new changesets
Changeset: 9352ac09d39a Author:shemnon Date: 2014-05-16 08:02 -0600 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9352ac09d39a RT-37082: incorrect rpm package naming Summary: Allow file system names of the bundles to keep upper case, but otherwise bring the names into coformance for the command line when automatically setting. ! modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxAppBundler.java ! modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxDebBundler.java ! modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxRpmBundler.java ! modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/LinuxAppBundler.properties ! modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.deb.init.script ! modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.desktop ! modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.postinst ! modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.rpm.init.script ! modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.spec ! modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxAppBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxDebBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxRpmBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppStoreBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacDmgBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacPkgBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinAppBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinExeBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinMsiBundlerTest.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinServiceBundlerTest.java Changeset: c9f32dfad4c9 Author:Felipe Heidrich Date: 2014-05-16 09:05 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c9f32dfad4c9 RT-37131: [Font] java.util.ConcurrentModificationException ! modules/graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
Re: Javadocs and CSS
Maintaining the css ref is a real pain. All those tables should be given over to an automated process. On 5/16/14, 12:03 PM, Scott Palmer wrote: I'm not sure what you mean. I'm only talking about documentation for the public API. It's just a clarification for the existing docs. On a side note, a search of the code shows that "-fx-line-spacing" is a CSS property.. but it isn't mentioned anywhere in the CSS Reference Guide. I've created https://javafx-jira.kenai.com/browse/RT-37170 to cover that case. Scott On Fri, May 16, 2014 at 11:00 AM, Tom Schindl wrote: Well that would work for properties on controls but many of them are in the Skin classes and those could be different from platform to platform and theme to theme and so are an implementation detail. Tom Von meinem iPhone gesendet Am 16.05.2014 um 16:38 schrieb Scott Palmer : Should a better cross-reference or mention of CSS properties in the Javadocs? Many properties can be set via calling methods or through CSS, but when browsing the Javadocs the related CSS properties are not mentioned (at least not in most cases). The package docs for javafx.scene mention the CSS Reference Guide at the end of the description, and careful reading of that document mentions the convention used to go from JavaFX variable names to CSS property. (last paragraph of http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#introscenegraph) I think all that is needed is to mention in the JavaDocs if the property is configurable from CSS or not. Or at least mention the exceptions to the rule. For example most properties of Labeled are configurable via CSS, but "lineSpacing" and "mnemonicParsing" are *not* mentioned among the CSS properties. (http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#labeled) Scott
hg: openjfx/8u-dev/rt: [Cleanup] mark PrismFontFactory#loadEmbeddedFont0() private
Changeset: f5364c52b59a Author:Felipe Heidrich Date: 2014-05-16 11:19 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f5364c52b59a [Cleanup] mark PrismFontFactory#loadEmbeddedFont0() private ! modules/graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
hg: openjfx/8u-dev/rt: [TEST-ONLY] RT-35628: Application Bundlers
Changeset: e50fa5e34167 Author:shemnon Date: 2014-05-16 13:04 -0600 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e50fa5e34167 [TEST-ONLY] RT-35628: Application Bundlers Summary: don't run deb tests if dpkg-deb is not present ! modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxDebBundler.java ! modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxDebBundlerTest.java
Code Review Request For RT-37129: [Linux] Need to blacklist old ATI X1nnn series cards
Hi Kevin and Vadim, Please review the proposed fix: https://javafx-jira.kenai.com/browse/RT-37129 Thanks, - Chien
hg: openjfx/8u-dev/rt: [SAMPLES] RT-36463: set progress start value to zero in timeline in ProgressIndicatorApp
Changeset: d599602552d0 Author:David Grieve Date: 2014-05-16 17:40 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d599602552d0 [SAMPLES] RT-36463: set progress start value to zero in timeline in ProgressIndicatorApp ! apps/samples/Ensemble8/src/samples/java/ensemble/samples/controls/progressindicator/ProgressIndicatorApp.java
[8u] review request: RT-37075: Application.runLater throws IllegalStateException if called from ShutdownHook
Steve & Anthony, Please review the following fix. Details in JIRA. https://javafx-jira.kenai.com/browse/RT-37075 -- Kevin
Javadoc: docklet, properties, getters and setters
As far as I'm aware, with Java SE 8 you don't have to specify a docklet anymore. The default docklet already supprts JavaFX properties. But when I generate the Javadoc, the section "Property description: ..." is missing in the getters and the setters. I noticed however, that the JavaFX 8 Javadoc does have these sections (e.g. see Button.setDefaultButton: http://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/Button.html#setDefaultButton-boolean- ) How did you manage to generate these sections? Thanks for some hints. -Florian
Re: Javadoc: docklet, properties, getters and setters
Try: javadoc -javafx ... -- Kevin Florian Brunner wrote: As far as I'm aware, with Java SE 8 you don't have to specify a docklet anymore. The default docklet already supprts JavaFX properties. But when I generate the Javadoc, the section "Property description: ..." is missing in the getters and the setters. I noticed however, that the JavaFX 8 Javadoc does have these sections (e.g. see Button.setDefaultButton: http://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/Button.html#setDefaultButton-boolean- ) How did you manage to generate these sections? Thanks for some hints. -Florian
