Re: Error while pushing changeset

2018-01-09 Thread Kevin Rushforth
> I also note that tith simple javadoc changes... "with" simple ... -- Kevin Kevin Rushforth wrote: Nir Lisker wrote: > This shows a lack of understanding about our processes Yes it does, which is why I asked about it yesterday. I'll send a webrev. Ah, I haven't gotten to your email

Re: Error while pushing changeset

2018-01-09 Thread Kevin Rushforth
Nir Lisker wrote: > This shows a lack of understanding about our processes Yes it does, which is why I asked about it yesterday. I'll send a webrev. Ah, I haven't gotten to your email from yesterday, since I was on vacation and am still catching up. If you can send a webrev, and a pointer

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
> > If there isn't an existing JBS issue, then please file one I thought I would point to "8188314: Fix typos in FX API docs" even though the exact changes I'm proposing are not listed there, but I can submit a new bug just for those if it really matters (it will be another Fix Typos issue). >

Re: Error while pushing changeset

2018-01-09 Thread Kevin Rushforth
Nir Lisker wrote: If there isn't an existing JBS issue, then please file one I thought I would point to "8188314: Fix typos in FX API docs" even though the exact changes I'm proposing are not listed there, but I can submit a new bug just for those if it really matters (it will be

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
> This shows a lack of understanding about our processes Yes it does, which is why I asked about it yesterday. I'll send a webrev. Thanks, Nir On Tue, Jan 9, 2018 at 8:50 PM, Kevin Rushforth wrote: > Why would you even try to push a changeset without getting it

[11] Review request for 8193590: Memory leak when using WebView with Tooltip

2018-01-09 Thread Murali Billa
  Hi, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8193590   Webrev: http://cr.openjdk.java.net/~mbilla/8193590/webrev.01/   Thanks, Murali

Error while pushing changeset

2018-01-09 Thread Nir Lisker
Iv'e created a small documentation fix and tried to push it to http://hg.openjdk.java.net/openjfx/jfx-dev/rt. I got an error: abort: push creates new remote head 2152a80ee902! hint: pull and merge or see 'hg help push' for details about pushing new heads [command returned code 255 Tue Jan 09

Re: Error while pushing changeset

2018-01-09 Thread Kevin Rushforth
Why would you even try to push a changeset without getting it reviewed first??? This shows a lack of understanding about our processes and policies. Only committers have permission to push changesets, and only after review. Please familiarize yourself with the policies and procedures

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
Submitted a new bug with ID: 9052190. On Tue, Jan 9, 2018 at 10:51 PM, Kevin Rushforth wrote: > > > Nir Lisker wrote: > > If there isn't an existing JBS issue, then please file one > > > I thought I would point to "8188314: Fix typos in FX API docs" even though >