Re: Instructions for working on OpenJFX

2018-01-19 Thread Lennart Börjeson
19 jan. 2018 kl. 01:10 skrev Kevin Rushforth >: #2. You should be able to build just the FX bits (outside your IDE) using: gradle sdk -or- gradle javadoc When building on my Mac, I've found that I must specify gradle

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-19 Thread Semyon Sadetsky
Hi Phil, Dipak, The 8021961 fix was about invisible parent window. The current fix is independent from it so the change looks good. --Semyon On 01/17/2018 09:48 PM, Dipak Kumar wrote: Hi Semyon, Could you please review the changes (also have a look at Phil's comment in trailing mail) and

Re: Instructions for working on OpenJFX

2018-01-19 Thread Kevin Rushforth
What version of gradle are you using? gradle 4.3, which is what we recommend / use in production, does not do parallel task execution by default. Are you enabling it in your gradle.properties file? Or maybe using a later version of gradle? -- Kevin Lennart Börjeson wrote: 19 jan. 2018 kl.

Re: [11] Review request for 8191446: [Linux] Build and deliver the libav media stubs for openjfx build

2018-01-19 Thread Kevin Rushforth
Sure, I'll review/test it when I get a chance. As a note to other reviewers, this patch adds a new "BUILD_LIBAV_STUBS" flag to build.gradle to support building the libav stubs in support of running on multiple Linux systems that may have different versions of libav. Currently we only build

Re: Instructions for working on OpenJFX

2018-01-19 Thread Kevin Rushforth
Sure we could add that to the Wiki. I'll put this on the list for next time I update it to incorporate other feedback. I'd guess that you are just getting lucky on Linux. -- Kevin Lennart Börjeson wrote: 19 jan. 2018 kl. 15:37 skrev Kevin Rushforth : What

Re: Instructions for working on OpenJFX

2018-01-19 Thread Lennart Börjeson
> 19 jan. 2018 kl. 15:37 skrev Kevin Rushforth : > > What version of gradle are you using? gradle 4.3, which is what we recommend > / use in production, does not do parallel task execution by default. Are you > enabling it in your gradle.properties file? Or maybe