> The issue occurs because the key events are consumed by the `ListView` in
> `Popup`, which displays the items.
> This is a regression of
> [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change
> aadded several
> `KeyMapping`s for focus traversals to `ListView`, which con
On Wed, 9 Sep 2020 11:49:55 GMT, Jeanette Winzenburg
wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rename tests
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ListViewBehavior.
On Wed, 9 Sep 2020 11:59:35 GMT, Jeanette Winzenburg
wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rename tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
> line 134
On Wed, 9 Sep 2020 12:23:32 GMT, Jeanette Winzenburg
wrote:
> Left some minor comments inline.
Updated PR with corrections, please take a look.
-
PR: https://git.openjdk.java.net/jfx/pull/172
On Thu, 10 Sep 2020 17:20:07 GMT, Kevin Rushforth wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added code comment as requested in review
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control
> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce
> a memory leak, NPE on replacing the
> listView and incorrect update of internal state (see bug report for details)
> Fixed by removing the listeners (and the internal state had been copied from
> listView on change)
On Fri, 11 Sep 2020 09:22:00 GMT, Ambarish Rapte wrote:
>> The issue occurs because the key events are consumed by the `ListView` in
>> `Popup`, which displays the items.
>> This is a regression of
>> [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change
>> aadded severa
On Fri, 11 Sep 2020 09:41:46 GMT, Ambarish Rapte wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
>> line 1347:
>>
>>> 1345: final ComboBox cb = new
>>> ComboBox<>(FXCollections.observableArrayList("a", "b", "c"));
>>> 1346: cb.setEdit
On Wed, 9 Sep 2020 12:15:51 GMT, Jeanette Winzenburg
wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rename tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
> line 151
On Fri, 11 Sep 2020 09:57:09 GMT, Jeanette Winzenburg
wrote:
>> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce
>> a memory leak, NPE on replacing the
>> listView and incorrect update of internal state (see bug report for details)
>> Fixed by removing the listeners
On Fri, 11 Sep 2020 09:57:09 GMT, Jeanette Winzenburg
wrote:
>> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce
>> a memory leak, NPE on replacing the
>> listView and incorrect update of internal state (see bug report for details)
>> Fixed by removing the listeners
On Thu, 10 Sep 2020 17:10:41 GMT, Kevin Rushforth wrote:
>> something similar as I'm seeing - that's good :) Uploaded my [play
>> code](https://gist.github.com/kleopatra/37ac1bffa0e2ad7580cd55344237cdca) to
>> gist: the idea is to do something (like
>> f.i. moving the selection), then press f1 t
On Wed, 10 Jun 2020 12:25:04 GMT, Jeanette Winzenburg
wrote:
> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce
> a memory leak, NPE on replacing the
> listView and incorrect update of internal state (see bug report for details)
> Fixed by removing the listeners (and
The `.jcheck/conf` file is configured to check the same set of files as the old
HG jcheck, namely files with the
following extensions:
.java, .c, .h, .cpp, .hpp
The Skara git jcheck allows us to evolve the rules for white space checking
compatibly.
This PR adds the following additional fil
On Fri, 11 Sep 2020 18:17:30 GMT, Kevin Rushforth wrote:
> As discussed in [this
> message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-July/027049.html)
> on
> openjfx-dev I propose to remove the old netbeans-specific files from the
> source repository. They were originally done
As discussed in [this
message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-July/027049.html)
on
openjfx-dev I propose to remove the old netbeans-specific files from the source
repository. They were originally done
for NetBeans 8 / FX 8,. They sort of worked (but not well) with FX 9
On Sun, 30 Aug 2020 16:09:14 GMT, Nir Lisker wrote:
> Moving implementation details about lazy evaluation and equality checking to
> `@implSpec`.
I left a couple suggestions below.
modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java line
42:
> 40: * An implementation o
On Mon, 31 Aug 2020 23:28:51 GMT, Nir Lisker wrote:
> Correction to the order of transforms specified in the docs of `Node`.
The updated text look good, although there is a javadoc error that causes the
build to fail. I left a few comments
below.
modules/javafx.graphics/src/main/java/javafx/sc
18 matches
Mail list logo
