javafx-maven-plugin eclipse java version

2021-03-26 Thread Tom Eugelink
To prevent me from going on a long search-and-rescue, I figured I'd post a small question here. I'm trying to run an application with the javafx-maven-plugin on top of JDK 15. Works fine. But the moment I do javafx:run from within Eclipse, it complains about the classfile versions: it says the

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v4]

2021-03-26 Thread Florian Kirmaier
> Fixing a memory leak. > A node hard references its old parent after CSS layout and getting removed. > This shouldn't be the case, this is very counterintuitive. > > The fix uses a WeakReference in CSSStyleHelper for firstStyleableAncestor. > This should be fine because the CSS should only depe

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v3]

2021-03-26 Thread Florian Kirmaier
On Tue, 23 Mar 2021 09:57:11 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8263402 >> Rewrote the style memoryleak test > > Provided few comments on test. I've added the requested chang

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing

2021-03-26 Thread Jeanette Winzenburg
On Thu, 25 Mar 2021 23:11:28 GMT, Florian Kirmaier wrote: > > Handling the logic from the ListView seems wrong to me, looks like I was unclear, because that's a 100% me-too :) Reformulating my second sentence in test snippets: A: cell.updateIndex(1); list.edit(1); cell.

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v9]

2021-03-26 Thread Nir Lisker
On Thu, 25 Mar 2021 02:02:25 GMT, Nir Lisker wrote: >>> I the rotation needs to apply to whatever the direction vector is: whether >>> that's implicitly (0,0,1) if we don't provide a separate direction vector >>> or whether it's the user provided direction vector, it would be odd to >>> ignore

Re: Implementing a shader API

2021-03-26 Thread Jacky Guo
Regarding the shader API, if an error occurs during shader compilation, should it simply default to the basic Phong shaders or throw an Exception (likely in a new package with other shader stuff)? I'm also very clueless as to how JavaFX links D3D shaders at runtime. Can someone give me a quick run

Re: Implementing a shader API

2021-03-26 Thread Nir Lisker
Let's keep the discussion in the openjfx-disc...@openjdk.java.net list for now. I'm sending this mail on the dev list just for continuity. I'm also very clueless as to how JavaFX links D3D shaders at runtime. Can > someone give me a quick rundown on that? > The D3D shader pointers are in D3DPhong

Re: Not really a nice comment but a real issue?

2021-03-26 Thread Nir Lisker
There's no question that the JBS is the way to go for handling existing reports. As for incoming reports, I dislike the GitHub issues as they are just a text dump, and many reporters are not careful about giving you versions (Java/JavaFX/OS...) or working environment details. You can help GitHub w

Re: javafx-maven-plugin eclipse java version

2021-03-26 Thread Nir Lisker
What is "javafx:run"? If you run it from within Eclipse (the green "play" button), does it work? On Fri, Mar 26, 2021 at 10:08 AM Tom Eugelink wrote: > To prevent me from going on a long search-and-rescue, I figured I'd post a > small question here. > > I'm trying to run an application with the