On Tue, 26 Oct 2021 12:09:19 GMT, Marius Hanl wrote:
> This problem can happen when using multiple instances with different jfx
> early access (ea) versions.
>
> Example:
> Instance 1 uses 18-ea+4 and Instance 2 uses 18-ea+1.
> Instance 1 is started (and will cache and use libraries), then in
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
> Cleanup of Tree-/TableRowSkin to support switching skins
>
> The misbehavior/s
> - memory leaks due to manually registered listeners that were not removed
> - side-effects due to listeners still active on old skin (like NPEs)
>
> Fix
> - use skin api for all listener registration (for automatic
On Tue, 26 Oct 2021 12:07:23 GMT, Ajit Ghaisas wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> re-added forgotten code comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSki
On Tue, 26 Oct 2021 19:48:41 GMT, Andreas Heger wrote:
>> The inconsistent illumination happens on Macs with retina displays only if
>> the 3D shape is placed in a SubScene. The light sources are located with
>> wrong coordinates in sub scenes and this causes a different illumination.
>> The w
On Wed, 27 Oct 2021 09:50:32 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkin.java
>> line 134:
>>
>>> 132: // that when it changes, we can appropriately add /
>>> remove cells that may or may not
>>> 133:
On Wed, 27 Oct 2021 09:56:46 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
>
On Tue, 26 Oct 2021 09:54:43 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - Ther
On Wed, 20 Oct 2021 15:45:52 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> Took a quick look at the new docs. I didn't check the resulting HTML or the
> corrected of the d
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Wed, 27 Oct 2021 08:12:05 GMT, Johan Vos wrote:
> This looks like a good solution, and I agree it fixes the issue. I have 2
> minor concerns:
>
> 1. Are we sure there are no platform-specific restrictions when using a `+`
> in a filename?
> 2. Testing this is probably difficult. We can only
On Wed, 27 Oct 2021 15:58:38 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.graphics/src/main/java/javafx/stage/Window.java line 790:
>
>> 788: * If the
On Tue, 26 Oct 2021 09:54:43 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - Ther
On Tue, 26 Oct 2021 06:24:35 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-82
14 matches
Mail list logo
