Re: Why can Scene's only be constructed on the UI thread?

The patch tries to solve the issue by deferring the construction of Scene in PopupWindow, but the issues I ran into just show that it's not enough. In order to fix RT-17716, we need Scene construction outside of the thread. Looking at the Scene code, it seems that there are not that many place

hg: openjfx/8u-dev/rt: Fix RT-36790: dirty region optimization loses background if back buffer is lost due to low vram condition.

Changeset: 13ecb2d726ab Author:flar Date: 2014-04-28 23:20 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/13ecb2d726ab Fix RT-36790: dirty region optimization loses background if back buffer is lost due to low vram condition. Reviewed by: Kevin ! modules/graphics/sr

hg: openjfx/8u-dev/rt: 2 new changesets

Changeset: 0da5df134799 Author:Martin Sladecek Date: 2014-04-29 08:08 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0da5df134799 RT-36842 OpenJFX no longer builds with OpenJDK Reviewed by: kcr ! .idea/base.iml ! build.gradle ! modules/base/.classpath + modules/base/s

hg: openjfx/8u-dev/rt: 3 new changesets

Changeset: c4d8457b7064 Author:jgiles Date: 2014-04-29 13:27 +1200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c4d8457b7064 RT-36855: [TableView, TreeTableView] Auto sizing of TableColumn should take into account header text / graphic ! modules/controls/src/main/java/co

hg: openjfx/8u-dev/rt: RT-36885: [TreeView, TreeTableView] Focus doesn't follow the selection after adding children

Changeset: 143503528295 Author:jgiles Date: 2014-04-29 12:13 +1200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/143503528295 RT-36885: [TreeView, TreeTableView] Focus doesn't follow the selection after adding children ! modules/controls/src/main/java/javafx/scene/control/

hg: openjfx/8u-dev/rt: RT-36714: Flickering empty rows while updating a cell in a ListView

Changeset: da036c46b124 Author:jgiles Date: 2014-04-29 10:13 +1200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/da036c46b124 RT-36714: Flickering empty rows while updating a cell in a ListView ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ListViewSkin

Re: Cleaning up Control codebase - How to deal with StyleableProperty cast

IntelliJ says the following: = Unchecked cast: 'javafx.beans.property.BooleanProperty' to 'javafx.css.StyleableProperty' *JDK 5.0 only.* Signals places where an unchecked warning is issued by the compiler, for example: |void f(HashMap map) { map.put("key", "val

Re: Cleaning up Control codebase - How to deal with StyleableProperty cast

This seems to look fine - IntelliJ still complains about an unnecessary cast, but it is better than having an unchecked cast. I'm happy for this to be done, but I think it would be best to get David Grieve's +1 first too. Thanks for your help so far - it is making the JavaFX code base much n

Re: Cleaning up Control codebase - How to deal with StyleableProperty cast

Hi, Interesting is that only the Eclipse Java Compiler shows a warning. javac is fine with original code. Let me see what the Eclipse compiler guys have to say about that! Tom On 28.04.14 23:33, Tom Schindl wrote: > Hi, > > I've been cleaning up the warnings inside the controls code base and o

Re: Setup IDE for development instructions

I fixed the wiki to warn Eclipse users not to do this. Steve On 2014-04-28 4:55 PM, Stephen F Northover wrote: Thanks Tom. Felipe ran into this way back when. Initially, the repo was in the workspace, but having outside allows is how most people develop and so I moved it out. Steve On 201

Cleaning up Control codebase - How to deal with StyleableProperty cast

Hi, I've been cleaning up the warnings inside the controls code base and one of the warnings left (beside many generic problems in the *View-classes) is the casting from *Property to *StyleableProperty. > final StyleableProperty prop = > (StyleableProperty)focusTraversableProperty(); now I thin

hg: openjfx/8u-dev/rt: RT-36889: Array out of bounds in VirtualFlow (caused by fix for RT-36714)

Changeset: 38c1ea45f8be Author:kcr Date: 2014-04-28 14:04 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/38c1ea45f8be RT-36889: Array out of bounds in VirtualFlow (caused by fix for RT-36714) Backed out changeset 410ba5840447 Backed out changeset 682a4407c437 ! module

Re: Setup IDE for development instructions

Thanks Tom. Felipe ran into this way back when. Initially, the repo was in the workspace, but having outside allows is how most people develop and so I moved it out. Steve On 2014-04-28 4:45 PM, Tom Schindl wrote: Hi, Just to finish this. The real problem with is that I've clone the hg-rep

hg: openjfx/8u-dev/rt: RT-36886: [VirtualFlow] NPE in VirtualFlow.layoutChildren with filtered list view.

Changeset: 410ba5840447 Author:kcr Date: 2014-04-28 13:32 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/410ba5840447 RT-36886: [VirtualFlow] NPE in VirtualFlow.layoutChildren with filtered list view. Reviewed-by: ddhill Contributed-by: Jonathan Giles ! modules/contr

Re: Setup IDE for development instructions

Hi, Just to finish this. The real problem with is that I've clone the hg-repo directly to my workspace-folder (which is the default in the Eclipse-hg-plugin) which is causing all the troubles! Once I move the clone next to the workspace-folder things started to operate the way they should. Tom

[8u] review request: RT-36745: [Mac] Visual artifacts when using SceneAntialiasing

Chien, Jim, Please review the fix for the following bug: https://javafx-jira.kenai.com/browse/RT-36745 -- Kevin

Re: Why can Scene's only be constructed on the UI thread?

Some of this was looked at while trying to solve RT-17716 (see Martin's patch). I think it would be worth considering relaxing the restriction on constructing Scene and Window (maybe Stage, but I don't think there is a benefit for that one), but

Re: Why can Scene's only be constructed on the UI thread?

Hi, Actually I don’t know of any reason why Window and Scene cannot be created and initialized on any thread. Each of these has a peer, and the *peer* we can’t update except on the right thread (or with care, these are OS specific restrictions or issues). But I don’t see any reason why the Java