Re: Instructions for working on OpenJFX

2018-01-24 Thread Nir Lisker
Submitted 9052392 to fix Eclipse config files. On Thu, Jan 25, 2018 at 1:22 AM, Kevin Rushforth wrote: > Yes, the IDE configs are for developer convenience only. You can feel free > to ignore them. > > If someone wants to cleanup the Eclipse IDE files, that would be

Re: [11] Review request for 8191446: [Linux] Build and deliver the libav media stubs for openjfx build

2018-01-24 Thread Kevin Rushforth
Anyone outside of Oracle willing to give this a test drive? In any case, I plan to finish up my review today. -- Kevin Kevin Rushforth wrote: Sure, I'll review/test it when I get a chance. As a note to other reviewers, this patch adds a new "BUILD_LIBAV_STUBS" flag to build.gradle to

Re: lipjpeg7 in static library

2018-01-24 Thread Kevin Rushforth
Hiding the symbols seems like a better solution than shipping two binaries, and is probably easier than mangling the symbols. -- Kevin Phil Race wrote: Does libjavafx_iio.a really need to export the JPEG symbols ? On Windows, or Linux, or Solaris .. there are ways to limit the exported

Re: lipjpeg7 in static library

2018-01-24 Thread Phil Race
Does libjavafx_iio.a really need to export the JPEG symbols ? On Windows, or Linux, or Solaris .. there are ways to limit the exported symbols from a library. I found this page for macos :

Re: Instructions for working on OpenJFX

2018-01-24 Thread Nir Lisker
If you're still catching up, I would like to verify that I should ignore project-level errors from the IDE. For example, Eclipse complains about the graphics project: Project 'graphics' is missing required source folder: 'build/resources/jsl-decora' Project 'graphics' is missing required source

lipjpeg7 in static library

2018-01-24 Thread Johan Vos
Hi, We are currently building a native library for javafx_iio which includes libjpeg7. As a consequence, those symbols are included in the static libjavafx_iio.a on iOS. If we add other libraries (e.g. OpenCV) this can result in duplicate symbols, as the libjpeg7 library might be included in