Re: RFR: 8087980: Add property to disable Monocle cursor

2019-11-15 Thread John Neffenger
On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green <12861109+dellgr...@users.noreply.github.com> wrote: > Often on embedded systems a cursor is not a valid input modality. On some of > these systems, when the javafx toolkit initialises the native hardware > cursor, it produces artefacts which can be

Re: RFR: 8087980: Add property to disable Monocle cursor

2019-11-15 Thread John Neffenger
On Wed, 13 Nov 2019 22:04:36 GMT, Dell Green wrote: > On Wed, 13 Nov 2019 21:34:06 GMT, John Neffenger > wrote: > >> On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green >> <12861109+dellgr...@users.noreply.github.com> wrote: >> >>> Often on embedded systems a cursor is not a valid input modality.

Re: [Rev 01] RFR: 8234239: [TEST_BUG] Reenable few ignored web tests

2019-11-15 Thread Kevin Rushforth
On Fri, 15 Nov 2019 10:01:51 GMT, Arun Joseph wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - ca460353: Remove ignore imports and update copyright > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/42/files > - new:

Re: [Approved] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Kevin Rushforth
On Fri, 15 Nov 2019 10:33:16 GMT, Ambarish Rapte wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e7856f6e: reenable some more tests and fix review comment > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/39/files >

Re: [Approved] RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

2019-11-15 Thread Kevin Rushforth
On Thu, 14 Nov 2019 09:33:39 GMT, Ajit Ghaisas wrote: > This PR is to address ignored tests in ComboBoxTest, LabeledTest, > HyperLinkTest and TextInputControlTest. > > strategy is as follows - > > 1) Enable tests marked with @Ignore by removing that tag > 2) Run the test > 3) If test Passes -

Re: Ad NashornScriptEngine (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2019-11-15 Thread Rony G. Flatscher
On 14.11.2019 22:57, Kevin Rushforth wrote: > On 11/14/2019 10:12 AM, Rony G. Flatscher wrote: >> On 14.11.2019 16:34, Rony G. Flatscher wrote: >>> On 13.11.2019 19:50, Kevin Rushforth wrote: On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: >> ... cut ... > To reproduce the testcase one

Re: Refire event while it is delivered is evil - always?!

2019-11-15 Thread Jeanette Winzenburg
*muttering to myself .. Meanwhile, my understanding evolved a bit - there are actually two refiring scenarios, both wrecking the event dispatch sequence, the first more evil than the second 1. getParent.fireEvent(receivedKeyEvent) which leads to serious misbehaviour (as reported f.i.

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-11-15 Thread Kevin Rushforth
On Fri, 15 Nov 2019 12:59:15 GMT, Jeanette Winzenburg wrote: > On Wed, 13 Nov 2019 11:26:54 GMT, Hadzic Samir wrote: > >> On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg >> wrote: >> >>> On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: >>> On Tue, 29 Oct 2019 13:19:27 GMT,

Re: To write tests or not to write tests ...

2019-11-15 Thread Jeanette Winzenburg
Zitat von Kevin Rushforth : In general, I would say it's OK to rely on existing tests for trivial refactoring, that is a refactoring where it seems fairly obvious that there are not going to be changes in behavior (even if such tests may be inadequate). For less trivial refactoring, if

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-11-15 Thread Jeanette Winzenburg
On Wed, 13 Nov 2019 11:26:54 GMT, Hadzic Samir wrote: > On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg > wrote: > >> On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: >> >>> On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: >>> On Wed, 9 Oct 2019 16:01:38 GMT, Kevin

Re: [Integrated] RFR: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

2019-11-15 Thread Ambarish Rapte
Changeset: 3d0cb496 Author:Ambarish Rapte Date: 2019-11-15 10:53:31 + URL: https://git.openjdk.java.net/jfx/commit/3d0cb496 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests Reviewed-by: kcr !

Re: RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Ambarish Rapte
On Fri, 15 Nov 2019 10:34:58 GMT, Ambarish Rapte wrote: > On Thu, 14 Nov 2019 23:55:45 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 19:56:16 GMT, Ambarish Rapte wrote: >> >>> Following graphics unit tests can be re-enabled. >>> >>> 1. >>>

Re: [Rev 01] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Ambarish Rapte
The pull request has been updated with additional changes. Added commits: - e7856f6e: reenable some more tests and fix review comment Changes: - all: https://git.openjdk.java.net/jfx/pull/39/files - new: https://git.openjdk.java.net/jfx/pull/39/files/5df00884..e7856f6e

Re: [Rev 01] RFR: 8234239: [TEST_BUG] Reenable few ignored web tests

2019-11-15 Thread Arun Joseph
The pull request has been updated with additional changes. Added commits: - ca460353: Remove ignore imports and update copyright Changes: - all: https://git.openjdk.java.net/jfx/pull/42/files - new: https://git.openjdk.java.net/jfx/pull/42/files/f2f121d9..ca460353

RFR: 8234239: [TEST_BUG] Reenable few ignored web tests

2019-11-15 Thread Arun Joseph
The following tests can be reenabled: CookieManager.testPutOverwriteExpired CookieManager.testPutPurgeDomainAfterExpiry CookieManager.testPutPurgeCookiesGlobally2 CookieManager.testPutPurgeCookiesGlobally3 CookieManager.testPutPurgeCookiesGloballyAfterExpiry CallbackTest.testCustomPopup

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-15 Thread Ajit Ghaisas
On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improvement done in >>