> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- 66cdab32: Attenuation and range changed internally to floats from doubles
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
-
On Fri, 3 Jan 2020 22:23:29 GMT, Kevin Rushforth wrote:
>> I was wondering about it myself, but all the other values are `double`s that
>> are cast to `float`s. Wouldn't it also be odd to have the API properties
>> `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of
>>
On Mon, 30 Dec 2019 11:05:55 GMT, Johan Vos wrote:
> This allows to build the JavaFX jars and native libraries for Android devices
I did a test build on Linux since there were changes to the shared Monocle
classes. I didn't really look at the `android.gradle` changes or the new
On Fri, 3 Jan 2020 22:37:06 GMT, Kevin Rushforth wrote:
>> I have added few comments, but have not run tests and sample yet.
>
>> I still need to test your sample app on Mac.
>
> I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04)
> with the same error as I reported
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- 464e8b5d: Fixed shader compilation errors for 2 and 3 lights in es2
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 3 Jan 2020 09:26:43 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> I have added few comments, but have not run tests and sample yet.
> I still need to test your sample app on Mac.
I get the error with your sample app. It fails on Mac or
On Fri, 3 Jan 2020 19:32:23 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41:
>>
>>> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}.
>>> 41: *
>>> 42: * The light's intensity can be set to decrease over distance
On Fri, 3 Jan 2020 09:25:21 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 175:
>
>> 174: lightsAttenuation[a++] = lights[i].attenuation[2];
>> 175:
On Fri, 3 Jan 2020 09:21:32 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 64:
>
>> 63:
>> 64: private double ca = DEFAULT_CA;
>> 65:
>
> The
On Fri, 3 Jan 2020 05:17:26 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41:
>
>> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}.
>> 41: *
>>
On Fri, 3 Jan 2020 05:08:33 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 43:
>
>> 42: private static final double DEFAULT_MAX_RANGE =
>>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- f66e8cf4: Addressing review comments
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
> This PR is a fix for
> [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474), a crash in
> the code that shows a file open or save dialog.
>
> In order to provide additional support for Copy (CMD-C), Cut (CMD-X), and
> Paste (CMD-V), the Glass implementation for displaying a file
On Sun, 17 Nov 2019 04:15:34 GMT, Nir Lisker wrote:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
I have added few comments, but have not run tests and sample yet.
modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
line 71:
> 70: public void
14 matches
Mail list logo
