On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8232589
>
> - Removed CoreAudio Utility classes.
> - Spectrum which was depended on CoreAudio Utility classes for doing
> computations will now run GStreamer spectrum element to do spectrum. E
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8232589
>
> - Removed CoreAudio Utility classes.
> - Spectrum which was depended on CoreAudio Utility classes for doing
> computations will now run GStreamer spectrum element to do spectrum. E
On Mon, 6 Jan 2020 23:36:50 GMT, Alexander Matveev wrote:
>> modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp
>> line 422:
>>
>>> 421: mEQBufferA = (double*)calloc(mEQBufferSize,
>>> sizeof(double));
>>> 422: mEQBufferB = (double*)cal
On Mon, 6 Jan 2020 23:21:32 GMT, Alexander Matveev wrote:
>> true, as spectrum->bps_user has #if defined (GSTREAMER_LITE) && defined
>> (OSX) around its definition.
>>
>> Even apart from that, it would make more sense and bring it at the same
>> level as line 738
>
> No need for GSTREAMER_LIT
On Fri, 20 Dec 2019 22:24:36 GMT, Kevin Rushforth wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232589
>>
>> - Removed CoreAudio Utility classes.
>> - Spectrum which was depended on CoreAudio Utility classes for doing
>> computations will now run GStreamer spectrum element to do spectrum.
Changeset: e0b45f8d
Author:Scott Palmer
Committer: Kevin Rushforth
Date: 2020-01-06 23:27:43 +
URL: https://git.openjdk.java.net/jfx/commit/e0b45f8d
8236648: javadoc warning on Text::tabSizeProperty method
Reviewed-by: kcr
! modules/javafx.graphics/src/main/java/javafx/scene
This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1)
on January 9, 2020 at 23:59 Pacific time.
Any change integrated to the default 'master' branch after that will be
for JavaFX 15. I will fork a new 'jfx14' stabilization branch early
Friday morning (Pacific time). As with
On Wed, 1 Jan 2020 19:16:33 GMT, Johan Vos wrote:
>> modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c
>> line 915:
>>
>>> 914: bpf = GST_AUDIO_FILTER_BPF (spectrum);
>>> 915: #ifdef OSX
>>> 916: if (spectrum->bps_user != 0 && spectrum
On Fri, 20 Dec 2019 13:26:05 GMT, Kevin Rushforth wrote:
>> I highly doubt that a code analysis tool will find such memoryleaks.
>
> I agree. Static analysis tools are quite limited in this regard, and are in
> now way a substitute for regression testing.
>
> So the question is how best to tes
On Mon, 6 Jan 2020 22:41:07 GMT, Kevin Rushforth wrote:
>>> Please, mark it as WIP.
>>
>> You can do this by editing the title and adding `WIP: ` as a prefix.
>
> This sort of enhancement needs to be discussed on the openjfx-dev mailing
> list first. While the WIP PR might be used to illustrat
On Mon, 6 Jan 2020 14:25:18 GMT, Kevin Rushforth wrote:
>> There are still some sizing issues that I am aware of.
>
>> Please, mark it as WIP.
>
> You can do this by editing the title and adding `WIP: ` as a prefix.
This sort of enhancement needs to be discussed on the openjfx-dev mailing list
On Mon, 6 Jan 2020 19:27:01 GMT, Scott Palmer wrote:
> Implemented suggested fix to address javadoc warning.
Looks good. This is a low-impact change so one reviewer will suffice.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/78
This is now fixed. The Skara bot successfully processed the backlog and
resolved all of the issues in question.
-- Kevin
On 1/2/2020 9:12 AM, Kevin Rushforth wrote:
The Skara commit notifications and JBS issue updates for the following
recently-integrated bugs are still pending:
https://bug
Changeset: 587f195c
Author:Kevin Rushforth
Date: 2020-01-06 21:11:20 +
URL: https://git.openjdk.java.net/jfx/commit/587f195c
8234474: [macos 10.15] Crash in file dialog in sandbox mode
Reviewed-by: arapte, prr
! modules/javafx.graphics/src/main/native-glass/mac/GlassDialogs.m
On Mon, 6 Jan 2020 21:01:25 GMT, Kevin Rushforth wrote:
>> This PR is a fix for
>> [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474), a crash in
>> the code that shows a file open or save dialog.
>>
>> In order to provide additional support for Copy (CMD-C), Cut (CMD-X), and
>>
Changeset: f1108b0a
Author:Arun Joseph
Committer: Kevin Rushforth
Date: 2020-01-06 20:58:28 +
URL: https://git.openjdk.java.net/jfx/commit/f1108b0a
8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
Reviewed-by: kcr, ghb
! modules/javafx.web/src/main/nativ
Your bug report was successfully logged into our system for triaging by
our incident team. Normally, the bugs are processed quickly and
transferred into the JDK project within a couple of days. The delay is
due to the holidays. I have transferred that one manually to the JDK
project as:
https
Implemented suggested fix to address javadoc warning.
-
Commits:
- bd81a902: 8236648: javadoc warning on Text::tabSizeProperty method
Changes: https://git.openjdk.java.net/jfx/pull/78/files
Webrev: https://webrevs.openjdk.java.net/jfx/78/webrev.00
Issue: https://bugs.openjdk.java
Changeset: 3c4d68dc
Author:Kevin Rushforth
Date: 2020-01-03 13:04:04 +
URL: https://git.openjdk.java.net/jfx/commit/3c4d68dc
8236626: Update copyright header for files modified in 2019
Reviewed-by: arapte
!
modules/javafx.graphics/src/test/java/test/javafx/scene/text/Text_cs
Changeset: 4c6ebfb4
Author:Johan Vos
Date: 2020-01-01 19:15:09 +
URL: https://git.openjdk.java.net/jfx/commit/4c6ebfb4
8236484: Compile error in monocle dispman
Reviewed-by: kcr
! modules/javafx.graphics/src/main/native-glass/monocle/dispman/DispmanScreen.c
Changeset: 8367e1a6
Author:Scott Palmer
Committer: Kevin Rushforth
Date: 2019-12-31 18:34:33 +
URL: https://git.openjdk.java.net/jfx/commit/8367e1a6
8130738: Add tabSize property to Text and TextFlow
Reviewed-by: prr, kcr
! modules/javafx.graphics/src/main/docs/javafx/scene/
Changeset: 1952606a
Author:Thiago Milczarek Sayao
Committer: Kevin Rushforth
Date: 2020-01-02 17:01:13 +
URL: https://git.openjdk.java.net/jfx/commit/1952606a
8232811: Dialog's preferred size no longer accommodates multi-line strings
Reviewed-by: kcr, arapte
! modules/javafx
Hi,
I've tried to report this JavaFX problem to the OpenJDK project (
https://bugreport.java.com/bugreport/ ), unfortunately I don’t have an account
there. And the report of me as a guest wasn’t accepted. That’s why I’m trying
to use this mailing list.
Bug description:
Since updating to macO
On Mon, 6 Jan 2020 18:21:17 GMT, Kevin Rushforth wrote:
>> Ok, fair enough for 14 ...
>
> I'll file a follow-up bug for 15 shortly.
>
> @prrace would you be willing to be the second reviewer on this fix?
I filed [JDK-8236685](https://bugs.openjdk.java.net/browse/JDK-8236685) to
remove the cus
On Mon, 6 Jan 2020 18:19:54 GMT, Phil Race wrote:
>> This is targeted for JavaFX 14, which is another reason to go with a more
>> targeted (safer) fix, since we are almost at RDP1. For JavaFX 15 it does
>> seem best to just remove the functionality entirely.
>
> Ok, fair enough for 14 ...
I'l
On Mon, 6 Jan 2020 18:11:29 GMT, Kevin Rushforth wrote:
>> Well then you'll just have to come back to it. If its not critical I'd
>> remove it now so that FX 15 (or is this for 14 ?) behaves consistently
>
> This is targeted for JavaFX 14, which is another reason to go with a more
> targeted (
On Mon, 6 Jan 2020 17:44:39 GMT, Phil Race wrote:
>> This was just added as a convenience, so it isn't critical functionality.
>>
>> Having said that, while we could just drop the subclasses now, it would
>> cause a perceived regression in behavior for users running on macOS 10.14
>> Mojave. S
On Mon, 6 Jan 2020 17:35:11 GMT, Kevin Rushforth wrote:
>> Based on my reading of https://bugs.openjdk.java.net/browse/JDK-8092977,
>> this means the support for edit operations in these dialogs is on its way
>> out ... now supportable only in non-sandboxed apps on the older macOS
>> releases.
On Mon, 6 Jan 2020 17:12:45 GMT, Phil Race wrote:
>> Looks good to me, Verified that all tests pass on Mojave 10.14.6
>
> Based on my reading of https://bugs.openjdk.java.net/browse/JDK-8092977, this
> means the support for edit operations in these dialogs is on its way out ...
> now supportab
On Mon, 6 Jan 2020 16:24:33 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> Looks good to me, Verified that all tests pass on Mojave 10.14.6
Based on my reading of https://bugs.openjdk.java.net/browse/JDK-8092977, this
means the support for edit op
On Mon, 6 Jan 2020 16:24:43 GMT, Kevin Rushforth wrote:
>> This PR is a fix for
>> [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474), a crash in
>> the code that shows a file open or save dialog.
>>
>> In order to provide additional support for Copy (CMD-C), Cut (CMD-X), and
>>
On Mon, 6 Jan 2020 14:10:52 GMT, Thiago Milczarek Sayao
wrote:
>> This proposed change does the following:
>>
>> - Ports DND target to use GTK reducing code size and adding extra text /
>> image formats (such as .gif);
>> - Use gtk signals instead of gdk events (also to reduce code size);
>> -
Btw, there is already a cleanup issue filed to target the removal of the
implementation code for applets:
https://bugs.openjdk.java.net/browse/JDK-8201538
-- Kevin
On 1/6/2020 6:05 AM, Kevin Rushforth wrote:
This code was used for running Applets. Support for applets was
removed in JDK 11, s
On Mon, 6 Jan 2020 00:28:14 GMT, Thiago Milczarek Sayao
wrote:
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simpl
This code was used for running Applets. Support for applets was removed
in JDK 11, so the code is no longer relevant.
-- Kevin
On 1/2/2020 3:18 AM, Thiago Milczarek Sayao wrote:
Ran all the robot test suite and those two classes are not touched.
I suspect they are used for web-start.
Are th
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
Hi,
If maximize property is set to true for an undecorated Stage, the following
behaviour is observed on different platforms:
* Windows: Undecorated stage is maximized
* MacOS: Undecorated stage is not maximized
* Linux(Ubuntu): Undecorated stage is not maximized
The following piece
39 matches
Mail list logo