On Fri, 17 Jan 2020 22:48:11 GMT, Kevin Rushforth wrote:
>>> So this PR may need a document change for `Animation.play()`
>>
>> Yes, and the docs need clarification in other places anyway. The [parent
>> issue](https://bugs.openjdk.java.net/browse/JDK-8210238) from which this bug
>> was
> The private field `lastPlayFinished` is responsible for 2 cases where an
> animation in `STOPPED` status does not play after `play()` is called if the
> rate is negative:
>
> 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is
> `false`. Setting a negative rate and
On Mon, 13 Jan 2020 16:49:41 GMT, Ambarish Rapte wrote:
>> This will need a second reviewer.
>>
>> @aghaisas can you review this, too?
>
>>
>>
>> @arapte - This bug looks like a good candidate for JavaFX 14. Can you
>> retarget this PR to the jfx14 branch?
>
> Thanks for guiding Kevin, PR
On Fri, 17 Jan 2020 23:18:40 GMT, Robert Lichtenberger
wrote:
>> As documented in JDK-8236912, WebView did not check whether the idMap really
>> contained a mapping for the given button, making it prone to errors, when
>> things are extended (as has happened here).
>>
>> The fix consists of
On Thu, 16 Jan 2020 01:09:56 GMT, Nir Lisker wrote:
>>> If cycleCount is set to 2 does the animation play the same number of times
>>> with or without the jumpTo both before and after this change?
>>
>> Before the change:
>> * With `jumpTo`: plays backwards 2 times.
>> * Without `jumpTo`:
On Fri, 17 Jan 2020 17:25:51 GMT, Frederic Thevenet
wrote:
>>>
>>>
>>> I tested this fix against the repro code in
>>> [javafxports/openjdk-jfx#433](https://github.com/javafxports/openjdk-jfx/issues/433)
>>> (which is
>>> [JDK-838](https://bugs.openjdk.java.net/browse/JDK-838)),
On Fri, 17 Jan 2020 19:22:24 GMT, Kevin Rushforth wrote:
>> I'm not 100% convinced this would really add much to the readability of the
>> code; I extracted the code from `doSnapshotTile` in its own method because
>> it is called twice (on both sides of the `if (height > maxTextureSize ||
>>
On Fri, 17 Jan 2020 14:09:54 GMT, Dean Wookey wrote:
> Everything passes with the fix and 5 of the new tests fail without the fix.
>
> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
> movingBranchToDifferentBranchGetsNewCssVariableTest
>
On Fri, 17 Jan 2020 18:40:34 GMT, Kevin Rushforth wrote:
>> Everything passes with the fix and 5 of the new tests fail without the fix.
>>
>> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
>> movingBranchToDifferentBranchGetsNewCssVariableTest
>>
On Fri, 17 Jan 2020 11:28:03 GMT, Frederic Thevenet
wrote:
>> I tested this fix against the repro code in
>> https://github.com/javafxports/openjdk-jfx/issues/433 (which is
>> [JDK-838](https://bugs.openjdk.java.net/browse/JDK-838)), but there
>> is still an NPE. I'm not certain that
On Thu, 16 Jan 2020 16:08:05 GMT, Nir Lisker wrote:
>> The pull request has been updated with 2 additional commits.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1316:
>
>> 1315: }
>> 1316: }
>> 1317: } else {
>
> I would extract
> This PR aims to address the following issue: JDK-8088198 Exception thrown
> from snapshot if dimensions are larger than max texture size
>
> In order to do that, it simply captures snapshots in multiple tiles of
> maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the
Everything passes with the fix and 5 of the new tests fail without the fix.
removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
movingBranchToDifferentBranchGetsNewCssVariableTest
removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
Since this is a P3 bug, you can target this to jfx14 as long as the fix
is safe. The reviewers might ask for it to be retargeted to master, but
that won't be a problem (going the other way is the direction that
requires more care and a possible rebase).
-- Kevin
On 1/16/2020 11:29 PM,
AFAIK, use master. They will decide to backport to a point release or not.
De: openjfx-dev em nome de Robert
Lichtenberger
Enviado: sexta-feira, 17 de janeiro de 2020 04:29
Para: openjfx-dev@openjdk.java.net Mailing
Assunto: Correct branch for PR?
I have a
On Thu, 16 Jan 2020 17:00:32 GMT, Nir Lisker wrote:
>> The pull request has been updated with 2 additional commits.
>
> I tested this fix against the repro code in
> https://github.com/javafxports/openjdk-jfx/issues/433 (which is
>
Hi David,
Thanks, I wrote that test as a graphics module test and it does fail.
https://gist.github.com/DeanWookey/2624945e3ba037f00c39c0bfd0b22cef
It passes if you move
node.styleHelper.firstStyleableAncestor = findFirstStyleableAncestor(node);
(line 134)
to line 321. I imagine there is some
17 matches
Mail list logo
