Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-02 Thread John Neffenger
On Fri, 2 Apr 2021 17:45:38 GMT, John Neffenger wrote: >> Media makefiles look fine. > >> Silly question, is the difference with Windows just the nature of the native >> support on each platform (Unix based vs Windows) and libraries used as part >> of that? > > That's a good question. I'm

Re: RFR: 8262366: Update glib to version 2.66.7

2021-04-02 Thread Alexander Matveev
On Thu, 1 Apr 2021 23:47:15 GMT, Kevin Rushforth wrote: >> All my testing looks good on all three platforms. I'll take a look at the >> diffs next. >> >> One thing I did spot is that you need to update `gstreamer.md` and `glib.md` >> to bump the version numbers. > > It now builds for me on my

RFR: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-02 Thread mstr2
This PR fixes incorrect parsing of mnemonic symbols in the following cases: 1. an escaped double underscore incorrectly shows up as a double underscore in displayed text 2. an extended mnemonic incorrectly removes a part of adjacent text As a side effect, this PR also fixes another undocumented

Integrated: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Arun Joseph
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote: > WebKit crashes during JavaScriptCore initialization code for Apple Silicon. This pull request has now been integrated. Changeset: b2f842de Author:Arun Joseph URL: https://git.openjdk.java.net/jfx/commit/b2f842de Stats: 1 line

Re: RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Johan Vos
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote: > WebKit crashes during JavaScriptCore initialization code for Apple Silicon. The other required changes required to build for M1 can easily be passed as build parameters using gradlew -P Hence, this change contains all that is needed to be

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-02 Thread John Neffenger
On Thu, 1 Apr 2021 23:21:55 GMT, Alexander Matveev wrote: >> John Neffenger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Include media shared libraries for Windows >> >> Enable reproducible builds of the native media shared

Re: RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Kevin Rushforth
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote: > WebKit crashes during JavaScriptCore initialization code for Apple Silicon. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/452

Re: RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Kevin Rushforth
On Fri, 2 Apr 2021 17:32:41 GMT, Johan Vos wrote: >> WebKit crashes during JavaScriptCore initialization code for Apple Silicon. > > This works, as long as MACOSX_MIN_VERSION is set to 11. I guess we don't want > to commit that in the build.gradle, as we only require that for a build on >

Re: RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Johan Vos
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote: > WebKit crashes during JavaScriptCore initialization code for Apple Silicon. This works, as long as MACOSX_MIN_VERSION is set to 11. I guess we don't want to commit that in the build.gradle, as we only require that for a build on Apple

RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Arun Joseph
WebKit crashes during JavaScriptCore initialization code for Apple Silicon. - Commit messages: - 8259555: Webkit crashes on Apple Silicon Changes: https://git.openjdk.java.net/jfx/pull/452/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=452=00 Issue:

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-02 Thread Scott Palmer
I haven’t done much in terms of custom controls, but I do see this issue a lot in my primary application. It would be nice to have it fixed as the layout looks rather sloppy without it. Any time I see the layout “correct” itself when I interact with a control or tweak the size of a window it

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-02 Thread Kevin Rushforth
Circling back to this: Do any JavaFX application developers on this list have any thoughts? I think this is a good idea, and it seems worth moving this forward, but it will require a fair bit of effort. I'd like to hear buy-in from other developers -- particularly those who develop or use

Re: Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH

2021-04-02 Thread Eric Bresie
Silly question, is the difference with Windows just the nature of the native support on each platform (Unix based vs Windows) and libraries used as part of that? Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On April 1, 2021 at 4:29:09 PM CDT, Kevin Rushforth

Integrated: JDK-8258381 : [macos] Exception when input emoji using Chinese input method

2021-04-02 Thread Hsiafan
On Sun, 21 Mar 2021 04:13:48 GMT, Hsiafan wrote: > The convertNSStringToJString function convert NSString to Java String using > NewStringUTF,NewStringUTF accept modified-UTF8 encoded str。This fix using > UTF-16 encoding for converting. This pull request has now been integrated. Changeset:

Re: RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic

2021-04-02 Thread yosbits
On Thu, 1 Apr 2021 23:50:12 GMT, Marius Hanl wrote: >> Because it is such a small correction >> Problem from me I feel that it is not easy to register, but I will try to >> register. >> >> It has passed two existing tests for compatibility: >> >> * gradle base:test >> * gradle

Re: Proof of concept for fluent bindings for ObservableValue

2021-04-02 Thread Nir Lisker
Hi John, I've had my eyes set on ReactFX enhancements for a while too, especially as a replacement for the unsafe "select" mechanism. One of the things that kept me from going forward with this is seeing what Valhalla will bring. Generic specialization might save a lot of duplication work on