Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2022-02-07 Thread Thiago Milczarek Sayao
On Sat, 11 Dec 2021 00:32:06 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minimize changes > > On my Ubuntu 20.04 VM the bug still happens about 1/2 the time with this fix.

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected [v3]

2022-02-07 Thread Michael Strauß
On Mon, 7 Feb 2022 18:46:55 GMT, Jose Pereda wrote: >> This PR adds a predicate to TableView and TreeTableView selection models >> order to remove rows from the selection only when there are no selected >> cells in that given row, when cell selection is enabled. >> >> Two tests have been

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected [v3]

2022-02-07 Thread Jose Pereda
> This PR adds a predicate to TableView and TreeTableView selection models > order to remove rows from the selection only when there are no selected cells > in that given row, when cell selection is enabled. > > Two tests have been added as well, that fail without this PR and pass with it.

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs

2022-02-07 Thread Nir Lisker
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-07 Thread Michael Strauß
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg wrote: > Issue was TreeView commit editing implementation violated the spec'ed > mechanism: > > - no default commit handler on TreeView > - TreeCell modifying the data directly > > Fix is to move the saving of the edited value from cell

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-02-07 Thread Kevin Rushforth
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Integrated: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs

2022-02-07 Thread Michael Strauß
On Mon, 22 Nov 2021 17:52:06 GMT, Michael Strauß wrote: > `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype > specified for images encoded in data URIs. This should be improved as follows: > > 1. If the specified image subtype is not supported, an exception will be >

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]

2022-02-07 Thread Michael Strauß
On Mon, 7 Feb 2022 15:03:07 GMT, yosbits wrote: > At least the following method do not need to remove the static modifier, but > they do. Is there any benefit? > > ```java > public int getNumBands(ImageType type) { > ``` I think the fact that the method doesn't access any instance fields

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-02-07 Thread iaroslavski
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs

2022-02-07 Thread Kevin Rushforth
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs

2022-02-07 Thread Nir Lisker
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs

2022-02-07 Thread Kevin Rushforth
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected [v2]

2022-02-07 Thread yosbits
On Mon, 7 Feb 2022 10:24:01 GMT, Jose Pereda wrote: >> This PR adds a predicate to TableView and TreeTableView selection models >> order to remove rows from the selection only when there are no selected >> cells in that given row, when cell selection is enabled. >> >> Two tests have been

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]

2022-02-07 Thread yosbits
On Sat, 8 Jan 2022 17:30:55 GMT, Michael Strauß wrote: >> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype >> specified for images encoded in data URIs. This should be improved as >> follows: >> >> 1. If the specified image subtype is not supported, an exception will

[jfx18] Integrated: 8279345: Realign class docs of LightBase and subclasses

2022-02-07 Thread Nir Lisker
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Nir Lisker
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: JavaFX with Python/JS

2022-02-07 Thread Johan Vos
Hi Thiago, Yes, that is possible, and I've done that years ago with some simple python code, that resulted in a array of numbers that can then be visualised with JavaFX. It is really cool indeed, but back then the Python support was limited (e.g. no numpy). As for huge marketing opportunity: the

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Ambarish Rapte
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

[jfx18] RFR: 8271085: TabPane: Redundant API docs

2022-02-07 Thread Ajit Ghaisas
This is a Javadoc cleanup and correction fix for the TabPane as described in the JBS. Changes done for all the Properties of the TabPane - - Moved the property description to be over the property field. - Removed the unnecessary docs on property setter/getter and Property method. -

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]

2022-02-07 Thread Ambarish Rapte
On Sat, 8 Jan 2022 17:30:55 GMT, Michael Strauß wrote: >> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype >> specified for images encoded in data URIs. This should be improved as >> follows: >> >> 1. If the specified image subtype is not supported, an exception will

RFR: 8280841: Update SQLite to 3.37.2

2022-02-07 Thread Hima Bindu Meda
Updated SQLite to 3.37.2 released on 2022-01-06 from the current version 3.32.3. Website : https://www.sqlite.org/index.html Source code can be found from https://www.sqlite.org/download.html at [sqlite-amalgamation-3370200.zip](https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip)

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected [v2]

2022-02-07 Thread Jose Pereda
On Fri, 4 Feb 2022 17:33:18 GMT, Michael Strauß wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback from reviewer > > modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java >

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected [v2]

2022-02-07 Thread Jose Pereda
> This PR adds a predicate to TableView and TreeTableView selection models > order to remove rows from the selection only when there are no selected cells > in that given row, when cell selection is enabled. > > Two tests have been added as well, that fail without this PR and pass with it.

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected

2022-02-07 Thread Jose Pereda
On Sat, 5 Feb 2022 05:08:54 GMT, yosbits wrote: >> This PR adds a predicate to TableView and TreeTableView selection models >> order to remove rows from the selection only when there are no selected >> cells in that given row, when cell selection is enabled. >> >> Two tests have been added as

Re: RFR: 8255940: localStorage is null after window.close() [v3]

2022-02-07 Thread Jay Bhaskar
On Sun, 6 Feb 2022 11:54:14 GMT, Jay Bhaskar wrote: >> No, it's not OK for two reasons: >> >> 1. It prevents concurrent execution of tests from two different directories >> 2. The Java temp directory might be something other than "/tmp" on some >> systems. >> >> Best is to use a local subdir

Re: RFR: 8255940: localStorage is null after window.close() [v3]

2022-02-07 Thread Jay Bhaskar
> Issue: The current implementation of DOMWindow ::localStorage(..) returns > null pointer in case of page is being closed. > Fix: It should not return nullptr , as per the [w3c web storage > spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) > "User agents should expire data from the