Re: Programmatic (Java) access to style / layout ?

2013-12-17 Thread David Grieve
It is possible, but probably not in the way that https://javafx-jira.kenai.com/browse/RT-17293 would provide. By that I mean, it would be nice to be able to progammatically say "the border color for this button when hovered is red." This can be done now by adding an invalidation listener to the

Re: A lot WARING with CSS

2013-12-15 Thread David Grieve
This is of concern to me as I have tried to maintain backward compatibility. It would be helpful if you would file a bug on this and include your .css file, if possible. On Dec 14, 2013, at 3:25 PM, Francisco Javier Godino wrote: > I have an application running perfectly with JAVAFX 2. > > I

Re: Reloading stylesheets

2013-12-12 Thread David Grieve
; Subject:Re: Reloading stylesheets > Sent by:openjfx-dev-boun...@openjdk.java.net > > > > This is also impacting Scene Builder. > > I have filed a Jira with a test case: > https://javafx-jira.kenai.com/browse/RT-34863 > > Jerome > > On 12/11/

Re: Reloading stylesheets

2013-12-11 Thread David Grieve
stylesheet is the Key in > a cache that isn't getting cleared by my code above. Nothing visible > happens when I do: >scene.stylesheets.clear() >scene.stylesheets.add(sameStylesheet) > > Given your description below, my impression is that RELOADING should a

Re: Reloading stylesheets

2013-12-10 Thread David Grieve
The way it works in 8.0 is that there is a cache of loaded stylesheets. When a scene or parent adds a stylesheet, the stylesheet is added to the cache. Any other scene or parent that uses the same stylesheet will get the one from cache. If a scene or parent later removes the stylesheet, the styl

Re: Creating a type of toggle with two labels..

2013-12-04 Thread David Grieve
It could be just about any type of button…with the right css styles! On Dec 4, 2013, at 5:57 PM, Leif Samuelsson wrote: > On 2013-12-04 14:54, Leif Samuelsson wrote: >> It seems to me that you could do this with a small class extending >> ToggleButton. >> Add a couple of String properties and u

Re: Creating a type of toggle with two labels..

2013-12-04 Thread David Grieve
You might want to look at what Gerrit has done here: http://harmoniccode.blogspot.com/2013/10/friday-fun-xviii.html On Dec 4, 2013, at 5:05 PM, Pedro Duque Vieira wrote: > OK, sounds reasonable. Too bad about the code duplication that will need to > take place. > > Thanks Jonathan and thanks

Re: Slider CSS skinning

2013-11-27 Thread David Grieve
Here is one way that uses a linear-gradient style where the stop offsets are defined by the slider value public void startx(Stage stage) VBox vbox = new VBox(4); final Slider slider = new Slider(); SliderSkin skin = new SliderSkin(slider); slider.setSkin(skin);

[JavaFX 8.0] Review request for RT-33919: Unit test failure in Node_cssStyleMap_Test :: testStyleMapTracksChanges

2013-11-22 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-33919 Please review: http://cr.openjdk.java.net/~dgrieve/RT-33919/webrev/ Reviewers: jgiles The ObservableMap,List

[API review] Relevant to RT-26277. Affects Region layout. Your input is needed.

2013-11-20 Thread David Grieve
The purpose of this email is to solicit feedback on an issue related to Region layout and the use of percent values in insets. https://javafx-jira.kenai.com/browse/RT-26277 is the relevant JIRA issue. Currently, a Region's width and height depends on the width and height of its content plus th

Review Request: RT-26277 [API, Layout] Percentage doesn't work in CSS Insets anymore

2013-11-07 Thread David Grieve
Dear OpenJFX Community, Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-26277 The webrev is available at: http://cr.openjdk.java.net/~kcr/RT-26277/webrev/ The JIRA issue contains detailed information. Thanks, David

Re: [API REVIEW] Add javafx.scene.layout.BackgroundInsets (RT-26277)

2013-11-04 Thread David Grieve
:40 PM, Stephen F Northover wrote: > Hi David, > > Looks good. Please update the JIRA with what you intend to do. People are > welcome to follow along there if they have any ideas for a different API / > approach. > > Steve > > On 2013-11-04 2:22 PM, David Grie

[API REVIEW] Add javafx.scene.layout.BackgroundInsets (RT-26277)

2013-11-04 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-26277 relates to the use of percentage values in -fx-background-insets. BackgroundFill (in javafx.scene.layout) uses Insets, which does not allow for a percentage value. My proposal here is to simply copy the BorderWidths implementation to a BackgroundIn

Re: CFV: New OpenJFX Committer: Oleg Barbashov

2013-10-24 Thread David Grieve
Vote: YES On Oct 24, 2013, at 8:58 AM, Artem Ananiev wrote: > > I hereby nominate Oleg Barbashov (OpenJDK user name: ogb) to OpenJFX > Committer. > > Oleg is a member of JavaFX SQE team at Oracle. He is currently an Author in > OpenJFX and is an active contributor to this project, about 30 c

Re: CFV: New OpenJFX Committer: Victor Shubov

2013-10-24 Thread David Grieve
Vote: YES On Oct 24, 2013, at 9:05 AM, Artem Ananiev wrote: > > I hereby nominate Victor Shubov to OpenJFX Committer. > > Victor is a member of JavaFX SQE team at Oracle. He has already contributed > enough changesets into the "tests" repository: > > $ hg log -M -u "Victor Shubov" --template

Re: Lambdafication (was Re: Default methods in JFX-8)

2013-10-03 Thread David Grieve
And what about Stream? I like the declarative code that comes from using Stream and I can see places in the code where Stream could be used, but I wonder about its performance relative to iterators and/or enhanced for loops. On Oct 3, 2013, at 4:45 PM, Richard Bair wrote: >> Hello, OpenJFX Co

Re: Changes in caspian.bss

2013-09-14 Thread David Grieve
This is (or should be) RT-32839, which is fixed in 8.0 and should make its way into next week's promotion. On Sep 14, 2013, at 7:26 AM, Tom Eugelink wrote: > > On JavaFX 8.0 we're getting all kind of CSS warnings when running the JFXtras > 8.0 project. I personally am waiting for JFX8 to sta

Re: PrefWidth/Height calculations only works if stage is shown

2013-08-28 Thread David Grieve
There is https://javafx-jira.kenai.com/browse/RT-21206, which I've just edited to be public. On Aug 28, 2013, at 2:29 PM, John Smith wrote: > Is there any plan to make impl_processCSS(true) public API? > Should I create a Jira for this? > If there were a public API, would processCSS be the rig

Re: custom Styleable properties CSS prefix

2013-08-16 Thread David Grieve
; My next step is to port this to 8.0. Are the changes major? > > > > On 2013-08-15 16:16, David Grieve wrote: >> I'm assuming this is 8.0? If so, what com.sun classes did you need to pull >> in and why? I'd like to know from the perspective of the owner of

Re: CFV: New OpenJFX Committer: Felipe Heidrich

2013-08-15 Thread David Grieve
Vote: Yes On Aug 15, 2013, at 1:36 PM, Artem Ananiev wrote: > > I hereby nominate Felipe Heidrich (OpenJDK user name: felipe) to OpenJFX > Committer. > > Felipe is a member of JavaFX graphics group at Oracle. He is mostly > responsible for JavaFX text and fonts, but not only for that. Here i

Re: CFV: New OpenJFX Committer: Mick Fleming

2013-08-15 Thread David Grieve
Vote: Yes On Aug 15, 2013, at 2:11 PM, Artem Ananiev wrote: > > I hereby nominate Mick Fleming (OpenJDK user name: mickf) to OpenJFX > Commmitter. > > Mick is a member of JavaFX Controls team at Oracle. He fixed many bugs and > implemented tons of features in virtually every JavaFX Control,

Re: custom Styleable properties CSS prefix

2013-08-15 Thread David Grieve
I'm assuming this is 8.0? If so, what com.sun classes did you need to pull in and why? I'd like to know from the perspective of the owner of the styleable API. If you have to pull in com.sun, then I might have missed something somewhere since all you should need is in the javafx.css package. O

Re: Proposal to move default style-class from Control to SkinBase

2013-08-07 Thread David Grieve
I appreciate the feedback and would like to point you to https://javafx-jira.kenai.com/browse/RT-9272. Your constructive criticism and input is welcome there, too. On Aug 7, 2013, at 4:41 PM, Pedro Duque Vieira wrote: > Hi David, > > I'm not going to directly answer your question but I'm rat

Re: Form of ProgressIndicator

2013-08-07 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-31196 On Aug 7, 2013, at 12:35 PM, Martin Klähn wrote: > Hi guys, > > I've just realized that the ProgressIndicator in Modena isn't shown as a > rotating circle. It looks like somebody pried apart the ProgressWheel and > left it apart. > > Has there been

Proposal to move default style-class from Control to SkinBase

2013-08-07 Thread David Grieve
Currently, a control has a default style-class. For example, you can use .button in a style-sheet to style a Button. I propose to move the default style-class from the control to the skin (RT-32186). The impetus for this change is two-fold. Firstly, it can be argued that setting the style-clas

Re: CFV: New OpenJFX Committer:Daniel Blaukopf

2013-08-06 Thread David Grieve
Vote: YES On Aug 6, 2013, at 11:15 AM, David Hill wrote: > I hereby nominate Daniel Blaukopf to OpenJFX Committer. > Daniel is a member of the Embedded Device team, which means he works across > various aspects of the platform. He is also the architect for the "embedded > device" space. > > H

Re: Font size in JavaFX 8

2013-07-18 Thread David Grieve
Which build? Yesterday I filed https://javafx-jira.kenai.com/browse/RT-31745 On Jul 18, 2013, at 9:39 AM, Peter Penzov wrote: > Hi, > I tested to run code developed on JavaFX 2.2. On JavaFX 8 the size of > the Font cannot be set properly with setStyle("-fx-font-size: 12pt;"). I > suppose tha

Re: ConcurrentModificationException during controls test runs

2013-07-17 Thread David Grieve
Thanks, John. I'll add this trace to https://javafx-jira.kenai.com/browse/RT-31714. If you have a short, self-contained, correct example that you can add to this issue, that will help me verify the fix. On Jul 17, 2013, at 9:14 AM, John Hendrikx wrote: > > I just got one too, but not relate

Re: Overriding caspian.css -fx-background

2013-07-17 Thread David Grieve
Probably a question better put to the OTN forums, but… In caspian.css, you'll find /* A very light grey used for the background of windows. See also * -fx-text-background-color, which should be used as the -fx-text-fill * value for text painted on top of backgrounds colored with -f

Re: ConcurrentModificationException during controls test runs

2013-07-16 Thread David Grieve
Please don't file a bug. There are two bugs for this already! https://javafx-jira.kenai.com/browse/RT-31698 https://javafx-jira.kenai.com/browse/RT-31714 On Jul 16, 2013, at 7:26 PM, Kevin Rushforth wrote: > Yes, Jennifer and I both saw this during integration testing. Jennifer also > saw this

Re: [API Review]: Node validation

2013-07-12 Thread David Grieve
is the "true" usage really needed or was it > just to cover up errors we were seeing? I remember having done this but don't > remember if it was truly needed or not? > > Richard > > On Jul 12, 2013, at 9:03 AM, David Grieve wrote: > >> I hesitate

Re: [API Review]: Node validation

2013-07-12 Thread David Grieve
I hesitate to mention Node#impl_processCSS(boolean) which is very very close to your notion of applyCss(); impl_processCSS(boolean) is a thorn in my side, but is used in certain places in controls code to ensure CSS is applied before layout in order to ascertain a node's dimensions. What it doe

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:07 PM, Richard Bair wrote: > I hereby nominate Debbie Masada to OpenJFX Committer. > > Debbie is a member of the samples team and works on Ensemble and other sample > applications, adding functionality etc. as necessary. Some of her recent > changes can be seen

Re: CFV: New OpenJFX Committer: Danno Ferrin

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:03 PM, Richard Bair wrote: > I hereby nominate Danno Ferrin to OpenJFX Committer. > > Danno has been actively submitting patches and following up to make sure they > get integrated for the past 8 months or so (the first patch I found was on > this issue: https:/

Re: CFV: New OpenJFX Committer: Oleg Mazurov

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:17 PM, Richard Bair wrote: > I hereby nominate Oleg Mazurov to OpenJFX Committer. > > Oleg has been a key behind-the-scenes contributor to JavaFX performance. Some > of his contributions can be counted in code > > http://hg.openjdk.java.net/openjfx/8/master/rt/l

Re: CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-10 Thread David Grieve
Vote: yes On Jul 9, 2013, at 6:09 PM, Richard Bair wrote: > I hereby nominate Alexander Kouznetsov to OpenJFX Committer. > > Alex is a member of the samples team, but also contributes to the core > platform itself and to J1 demos. His recent work can be seen here: > > http://hg.openjdk.java.n

Re: [API Review]: Node validation

2013-07-09 Thread David Grieve
possibilities for strange performance > issues with this approach when you bind certain properties. > > Richard > > On Jul 8, 2013, at 9:52 AM, David Grieve wrote: > >> I'm wondering why this "validate" can't just be implicit in any call that >

Re: [API Review]: Node validation

2013-07-08 Thread David Grieve
I'm wondering why this "validate" can't just be implicit in any call that uses or returns layout bounds. Surely we can tell from the dirty bits whether or not something needs layout and/or css. On Jul 8, 2013, at 12:31 PM, Richard Bair wrote: > OK, just throwing something wild out there. Right

Re: [API Review]: Node validation

2013-07-03 Thread David Grieve
Hi Martin, With regard to having this work without a Scene… I think having a method that would layout a node without the node actually having to be part of the scene-graph would be _very_ useful. Often times, developers will do the show-hide trick or add-remove trick to get a node's bounds be

[API Review] Make Scene styleable through CSS

2013-06-25 Thread David Grieve
https://javafx-jira.kenai.com/browse/RT-31282 Scene has a fillProperty which should be styleable via CSS but this would require making Scene implement the javafx.css.Styleable interface. The interesting bits from the interface are public String getId() public ObservableList getStyleCl

Re: Stroke-border issues

2013-06-20 Thread David Grieve
paque. I believe this won't work with stacked background fills... > > On 20.06.2013 20:01, David Grieve wrote: >> Try '-fx-border-style solid inside;' > > Tried it already. See 5th stackpane in my screenshot. Some "interesting" > result. > > http://s13.postimg.org/ujcl7lxt3/borders_and_bounds.png > > Werner

Re: Stroke-border issues

2013-06-20 Thread David Grieve
Try '-fx-border-style solid inside;' On Jun 20, 2013, at 1:26 PM, Richard Bair wrote: > I think what you're looking for is StrokeType: > http://docs.oracle.com/javafx/2/api/javafx/scene/shape/StrokeType.html > > On Jun 20, 2013, at 10:17 AM, Werner Lehmann > wrote: > >> Hi, >> >> I am expe

Re: Get style properties

2013-06-18 Thread David Grieve
On Jun 18, 2013, at 3:54 PM, Mario Torre wrote: > Hi all! > > I was trying to figure out how JavaFX parses and uses the style under > the hood and I stumbled on something I don't fully understand (I admit > I'm not really a CSS expert yet :). > > In the modena.css, right at the .root selector w

Re: How to see when a scene gets shown?

2013-06-13 Thread David Grieve
Get the window of the scene and add a handler for the onShownProperty via the setOnShown method. Add a listener to the Scene's windowProperty and add/remove your handler there. On Jun 13, 2013, at 8:19 AM, Pedro Duque Vieira wrote: > Hi Werner, > > Thanks for your input but unfortunately thi

Re: API review "RT-30861: Add simple Font factory method for a default font of a different size"

2013-06-03 Thread David Grieve
x27;d just add it as it will add >>> no weight and would at least be there when I reach for it. As long as one >>> day it won't be "the wrong thing"… >> >> It won't be doing the wrong thing per the proposed spec which is clear enough >>>

Re: API review "RT-30861: Add simple Font factory method for a default font of a different size"

2013-06-03 Thread David Grieve
ill add no weight > and would at least be there when I reach for it. As long as one day it won't > be "the wrong thing"… > > Anyway, if it is going to take more than a few minutes to figure out, best to > punt on this rather than soak up Felipe's prec

Re: API review "RT-30861: Add simple Font factory method for a default font of a different size"

2013-06-03 Thread David Grieve
I would rather see the deriveFont methods, but not as factory methods. public Font deriveFont(double size) public Font deriveFont(String family) The subtle difference being that these wouldn't use "default" sizes or family names but would use whatever the font is to find the closest matching fon

Re: Backwards compatibility issue?

2013-05-31 Thread David Grieve
On May 31, 2013, at 11:38 AM, Daniel Zwolenski wrote: > On 01/06/2013, at 1:23 AM, David Grieve wrote: > >> I won't take you up on that bet. I hate to lose. >> >> If the jar file has the .css file in it, you can disabled the loading of >> binary css by s

Re: Backwards compatibility issue?

2013-05-31 Thread David Grieve
to in the post if you want to do your own testing > on it. > > On 01/06/2013, at 12:57 AM, David Grieve wrote: > >> "512" is the localized message of the exception that is being thrown, which >> in itself is odd. >> >> You might get more info if

Re: Backwards compatibility issue?

2013-05-31 Thread David Grieve
"512" is the localized message of the exception that is being thrown, which in itself is odd. You might get more info if you set the CSS logger to INFO. Assuming this is JavaFX 2.2.x, you can set the CSS logging level via: com.sun.javafx.Logging.getCSSLogger().setLevel(com.sun.javafx.logging.P

<    1   2   3