[jfx11u] Integrated: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound

2021-12-07 Thread Johan Vos
On Tue, 7 Dec 2021 08:39:20 GMT, Johan Vos wrote: > backport (18->11) for 8276490: Incorrect path for duplicate x and y values, > when path falls outside axis bound This pull request has now been integrated. Changeset: 095c2c34 Author: Johan Vos URL: https://git.openjdk

[jfx17u] Integrated: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

2021-12-07 Thread Johan Vos
On Tue, 7 Dec 2021 08:37:15 GMT, Johan Vos wrote: > Clean backport (18->17) for 8276847: JSException: ReferenceError: Can't find > variable: IntersectionObserver This pull request has now been integrated. Changeset: 25abe09e Author:Johan Vos URL: https://git.op

[jfx17u] Integrated: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound

2021-12-07 Thread Johan Vos
On Tue, 7 Dec 2021 08:39:43 GMT, Johan Vos wrote: > backport (18->11) for 8276490: Incorrect path for duplicate x and y values, > when path falls outside axis bound This pull request has now been integrated. Changeset: 227afc85 Author: Johan Vos URL: https://git.openjdk

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v3]

2021-12-10 Thread Johan Vos
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote: >> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last >> element but to the bottom of the last element. > > eduardsdv has updated the pull request incrementally with one additional > commit since the last revision: > > 827

Re: RFR: 8201538: Remove implementation support for applets from JavaFX

2021-12-10 Thread Johan Vos
On Tue, 31 Aug 2021 16:28:53 GMT, Kevin Rushforth wrote: > This PR removes the obsolete applet implementation from JavaFX. It is an > ongoing maintenance burden to carry around this legacy code. Also, cleaning > this up could help in the implementation of GTK4, Wayland, and Metal, since > we w

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v3]

2021-12-10 Thread Johan Vos
On Fri, 10 Dec 2021 13:34:53 GMT, eduardsdv wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 1584: >> >>> 1582: boolean posSet = false; >>> 1583: >>> 1584: if (index > getCellCount() - 1) { >> >> I agree that the previous code

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v4]

2021-12-10 Thread Johan Vos
On Fri, 10 Dec 2021 15:24:44 GMT, eduardsdv wrote: >> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last >> element but to the bottom of the last element. > > eduardsdv has updated the pull request incrementally with one additional > commit since the last revision: > > 82

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]

2021-12-10 Thread Johan Vos
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]

2021-12-11 Thread Johan Vos
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendri

Re: RFR: 8273089: Deprecate JavaFX GTK 2 library for removal

2021-12-11 Thread Johan Vos
On Tue, 30 Nov 2021 13:26:30 GMT, Kevin Rushforth wrote: > This PR deprecates the JavaFX glass GTK 2 library for removal. Since there > isn't an associated API, the mechanism for doing this is to print a > "deprecated for removal" warning message when the `glassgtk2` library it is > loaded. A

RFR: 8278595: Provide more information when a pipeline can't be used

2021-12-13 Thread Johan Vos
This PR provides at least some basic information when a pipeline can't be used. There are a number of reasons why a candidate pipeline can't be used, and this PR makes it clear at which point the pipeline fails. The changes are only applied in case `prism.verbose` is already set to `true`, so

Re: RFR: 8278595: Provide more information when a pipeline can't be used [v2]

2021-12-13 Thread Johan Vos
rism.verbose` is already set to > `true`, so there is no unwanted logging. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Fix (minor) formatting issues. - Changes: - all: https://git.openjdk.java.net/jf

Re: RFR: 8278595: Provide more information when a pipeline can't be used [v3]

2021-12-13 Thread Johan Vos
rism.verbose` is already set to > `true`, so there is no unwanted logging. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: fix one more whitespace issue - Changes: - all: https://git.openjdk.java.net/jf

Integrated: 8278595: Provide more information when a pipeline can't be used

2021-12-13 Thread Johan Vos
On Mon, 13 Dec 2021 11:00:02 GMT, Johan Vos wrote: > This PR provides at least some basic information when a pipeline can't be > used. > There are a number of reasons why a candidate pipeline can't be used, and > this PR makes it clear at which point the pipeline fails.

Monocle properties in glass and prism

2021-12-15 Thread Johan Vos
Hi, The separation between Glass and Prism is slightly broken by Monocle and that restricts the number of possible combinations. I wonder if there are any known cases where the glass platform is set to Monocle, but where prism is expected to use X11? That sounds like a contradiction, as Monocle is

Re: Monocle properties in glass and prism

2021-12-15 Thread Johan Vos
On Wed, Dec 15, 2021 at 3:53 PM Kevin Rushforth wrote: > > > I wonder if there are any known cases where the glass platform is set to > > Monocle, but where prism is expected to use X11? That sounds like a > > contradiction > > Agreed that this seems like a mismatch. > > > I suggest we remove the

RFR: 8278860: Streamline properties for Monocle

2021-12-15 Thread Johan Vos
Base decisions in prism for embedded cases on the same glass.platform property that is also used in glass. This PR replaces the property `embedded` with the property `glass.platform` . There is only 1 place where the property `embedded` was read, which is in the PlatformUtil.java. There are onl

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Johan Vos
On Wed, 15 Dec 2021 00:25:08 GMT, Kevin Rushforth wrote: > Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > >

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Johan Vos
On Wed, 15 Dec 2021 22:12:12 GMT, Kevin Rushforth wrote: > > The only question I have for now is if it would make sense to have a new > > configuration instead of binding this to DEBUG_NATIVE. > > I had initially thought of only stripping the binaries for production builds, > e.g., when `-PCON

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Johan Vos
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]

2021-12-17 Thread Johan Vos
On Thu, 16 Dec 2021 21:26:29 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]

2021-12-17 Thread Johan Vos
On Thu, 16 Dec 2021 21:26:29 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v6]

2021-12-17 Thread Johan Vos
On Fri, 17 Dec 2021 12:56:40 GMT, Kevin Rushforth wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More review comments >> >> 1. Renamed "Contributing to...codebase" section to "Coding style and >> testing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Johan Vos
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8278860: Streamline properties for Monocle [v2]

2021-12-17 Thread Johan Vos
PlatformUtil.java. > > There are only 2 places where the value of that property is used, and in both > cases the only check is to detect whether or not that property has a value of > "monocle". Johan Vos has updated the pull request incrementally with one additional commi

Re: RFR: 8278860: Streamline properties for Monocle [v2]

2021-12-17 Thread Johan Vos
On Thu, 16 Dec 2021 00:20:06 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add space after comma > > modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.

Integrated: 8278860: Streamline properties for Monocle

2021-12-17 Thread Johan Vos
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote: > Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place whe

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-17 Thread Johan Vos
On Tue, 14 Dec 2021 07:27:50 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrapper was introduced which u

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v9]

2021-12-17 Thread Johan Vos
On Fri, 17 Dec 2021 15:18:51 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-19 Thread Johan Vos
On Tue, 14 Dec 2021 07:27:50 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrapper was introduced which u

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]

2021-12-20 Thread Johan Vos
On Thu, 16 Dec 2021 21:40:47 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: [jfx11u] RFR: 8279396: Define version in .jcheck/conf

2022-01-04 Thread Johan Vos
On Tue, 4 Jan 2022 16:45:52 GMT, Kevin Rushforth wrote: > Backport fix to add `version` property to `.jcheck/conf`. This is needed in > support of a Skara bot config change to take the fix version from the repo. > > NOTE: the `UPDATING-version.md` file was not present in the repo. I copied it

Re: [jfx17u] RFR: 8279396: Define version in .jcheck/conf

2022-01-04 Thread Johan Vos
On Tue, 4 Jan 2022 16:39:00 GMT, Kevin Rushforth wrote: > Backport fix to add `version` property to `.jcheck/conf`. This is needed in > support of a Skara bot config change to take the fix version from the repo. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Johan Vos
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) @bourgesl can you rename the title of this PR to 8274066: Polygon filled outside its area when very large coordinates are used --

Re: RFR: 8279615: Change JavaFX release version to 19

2022-01-07 Thread Johan Vos
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2022 at 16:00 UTC. ok (once 18 is branched) - Mark

RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed

2022-01-09 Thread Johan Vos
When the size of a ListCell is changed and a scrollTo method is invoked without having a layout calculation in between, the old (wrong) size is used to calculcate the total estimate. This happens e.g. when the size is changed in the `updateItem` method. This PR will immediately resize the cell a

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-10 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect >

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Johan Vos
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. This looks good with the current tools/OS behaviour.

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-13 Thread Johan Vos
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) t

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect >

Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect >

Re: [jfx18] RFR: Request to sync January 2022 changes into jfx

2022-01-18 Thread Johan Vos
Approved. Op di 18 jan. 2022 om 18:25 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > Hi Johan, > > I request approval to sync changes from to the just-released January > 2022 CPU release into the 'jfx18' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > >

Re: [jfx17u, jfx11u] RFR: Request to backport January 2022 CPU changes

2022-01-18 Thread Johan Vos
Approved Op di 18 jan. 2022 om 18:25 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > Hi Johan, > > I request approval to backport the changes from the just-released > January 2022 CPU to jfx17u (for 17.0.2) and to jfx11u (for 11.0.14) . > > https://github.com/kevinrushforth/jfx17u/compar

Re: The openjfx native library cache path should be platform dependent

2022-01-20 Thread Johan Vos
That sounds correct indeed. I filed https://bugs.openjdk.java.net/browse/JDK-8280369 for this. Thanks for reporting! - Johan On Thu, Jan 20, 2022 at 6:14 AM Glavo wrote: > I noticed that openjfx packaged in jar caches native libraries in > ~/.openjfx/cache/${version}, it is not related to the s

Re: [jfx17u] RFR: 8280490: Change JavaFX release version in jfx17u to 17.0.3

2022-01-25 Thread Johan Vos
On Tue, 25 Jan 2022 01:19:11 GMT, Kevin Rushforth wrote: > Bump release version in `jfx17u` repo to 17.0.3 for the start of a new > release. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx17u/pull/29

Re: [jfx11u] RFR: 8280489: Change JavaFX release version in jfx11u to 11.0.15

2022-01-25 Thread Johan Vos
On Tue, 25 Jan 2022 01:20:04 GMT, Kevin Rushforth wrote: > Bump release version in `jfx11u` repo to 11.0.15 for the start of a new > release. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/69

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Johan Vos
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based ca

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Johan Vos
Hi Kevin, Thanks for filing [JDK-8281089]. I think this is the way forward indeed. The longer we delay moving to VS 2019, the more problems we can expect. I'll build/test the WebKit 613.1 as well. - Johan On Wed, Feb 2, 2022 at 1:49 PM Kevin Rushforth wrote: > On Wed, 2 Feb 2022 07:34:55 GMT,

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-04 Thread Johan Vos
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and igno

Re: JavaFX with Python/JS

2022-02-07 Thread Johan Vos
Hi Thiago, Yes, that is possible, and I've done that years ago with some simple python code, that resulted in a array of numbers that can then be visualised with JavaFX. It is really cool indeed, but back then the Python support was limited (e.g. no numpy). As for huge marketing opportunity: the

Re: RFR: 8281459: WebKit 613.1 build broken on M1

2022-02-09 Thread Johan Vos
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in this

Re: RFR: 8281459: WebKit 613.1 build broken on M1

2022-02-10 Thread Johan Vos
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in this

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]

2022-02-17 Thread Johan Vos
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct uninte

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]

2022-02-17 Thread Johan Vos
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct uninte

Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Johan Vos
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. I notice changes specific to AArch64 and Linux, so I did a testbuild on Linux AArch64 which was successful. Will test the mac/linux/window

Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Johan Vos
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Ok on mac/linux/win x86_64 and on linux aarch64 - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jf

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Johan Vos
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - s/Enhancement/Enhancements > - C

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-15 Thread Johan Vos
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent failur

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Johan Vos
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent failur

[jfx11u] RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-17 Thread Johan Vos
Reviewed-by: kcr - Commit messages: - 8203463: [Accessibility, Narrator] NPE in TableView Changes: https://git.openjdk.java.net/jfx11u/pull/81/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u&pr=81&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8203463 Stat

[jfx11u] RFR: 8197991: Selecting many items in a TableView is very slow

2022-03-17 Thread Johan Vos
Co-authored-by: Naohiro Yoshimoto Reviewed-by: kcr, aghaisas - Commit messages: - 8197991: Selecting many items in a TableView is very slow Changes: https://git.openjdk.java.net/jfx11u/pull/82/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u&pr=82&range=00 Issue: http

[jfx17u] RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos
Reviewed-by: kcr - Commit messages: - 8203463: [Accessibility, Narrator] NPE in TableView Changes: https://git.openjdk.java.net/jfx17u/pull/38/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=38&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8203463 Stat

[jfx17u] RFR: 8197991: Selecting many items in a TableView is very slow

2022-03-18 Thread Johan Vos
Co-authored-by: Naohiro Yoshimoto Reviewed-by: kcr, aghaisas - Commit messages: - 8197991: Selecting many items in a TableView is very slow Changes: https://git.openjdk.java.net/jfx17u/pull/39/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=39&range=00 Issue: http

[jfx11u] Integrated: 8197991: Selecting many items in a TableView is very slow

2022-03-18 Thread Johan Vos
On Thu, 17 Mar 2022 21:01:51 GMT, Johan Vos wrote: > Co-authored-by: Naohiro Yoshimoto > Reviewed-by: kcr, aghaisas This pull request has now been integrated. Changeset: 1c3d9666 Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/

[jfx17u] Integrated: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos
On Fri, 18 Mar 2022 07:42:11 GMT, Johan Vos wrote: > Reviewed-by: kcr This pull request has now been integrated. Changeset: 53d443bf Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/53d443bffa34c971c7c6192649caa9aba2acb5f5 Stats: 1 line in 1 file changed: 1

[jfx17u] Integrated: 8197991: Selecting many items in a TableView is very slow

2022-03-18 Thread Johan Vos
On Fri, 18 Mar 2022 07:42:37 GMT, Johan Vos wrote: > Co-authored-by: Naohiro Yoshimoto > Reviewed-by: kcr, aghaisas This pull request has now been integrated. Changeset: 4af7ee97 Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/

[jfx11u] Integrated: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos
On Thu, 17 Mar 2022 20:56:32 GMT, Johan Vos wrote: > Reviewed-by: kcr This pull request has now been integrated. Changeset: bf32dd8a Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/bf32dd8a52876b0c0a53e9f73d64b0a986829626 Stats: 1 line in 1 file changed: 1

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v2]

2022-03-22 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add the option to shift all cells down in case the current calculations would lead to empty c

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-22 Thread Johan Vos
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, sinc

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-23 Thread Johan Vos
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, sinc

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v3]

2022-03-24 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add test to check if there are no empty cells at the end of a List in case there are en

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v2]

2022-03-24 Thread Johan Vos
On Tue, 22 Mar 2022 08:47:42 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > > Mos

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > > Mos

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. .github/workflows/sub

Re: RFR: 8283517: Update boot JDK to 18

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't need to update >

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Johan Vos
On Tue, 29 Mar 2022 11:50:32 GMT, Kevin Rushforth wrote: >> No, it will use whatever the latest is for GitHub actions. There doesn't >> seem to be an 11.2 package for GHA. It should be sufficient for most >> testing, but highlights one of the limitations of relying on GitHub Actions >> for any

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-03-30 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Don't shift cells if we are already showing the lowest index cell. -

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v3]

2022-03-30 Thread Johan Vos
On Fri, 25 Mar 2022 16:26:34 GMT, Kevin Rushforth wrote: > It looks like there are some failing unit tests now. I fixed them. - PR: https://git.openjdk.java.net/jfx/pull/712

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Johan Vos
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as m

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Johan Vos
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as m

Re: RFR: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Johan Vos
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/767

[jfx18] RFR: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1

2022-04-13 Thread Johan Vos
Update JavaFX release version to 18.0.1 in jfx18 branch - Commit messages: - Update JavaFX release version to 18.0.1 in jfx18 branch Changes: https://git.openjdk.java.net/jfx/pull/769/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=769&range=00 Issue: https://bugs.ope

backport requests for 18.0.1

2022-04-13 Thread Johan Vos
Hi Kevin, I request approval to backport the following issues to the jfx18 branch, for JavaFX 18.0.1: JDK-8278980: Update WebKit to 613.1 JDK-8281459: WebKit 613.1 build broken on M1 JDK-8281711: Cherry-pick WebKit 613.1 stabilization fixes JDK-8282099: Cherry-pick WebKit 613.1 stabilization fixe

Re: [jfx18] RFR: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1 [v2]

2022-04-13 Thread Johan Vos
> Update JavaFX release version to 18.0.1 in jfx18 branch Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Update version in .jcheck/conf to 18.0.1 - Changes: - all: https://git.openjdk.java.net/jfx/pull/769/files -

[jfx18] Integrated: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 08:59:45 GMT, Johan Vos wrote: > Update JavaFX release version to 18.0.1 in jfx18 branch This pull request has now been integrated. Changeset: 87cb6594 Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/87cb65949c468774bd6973198e45bb3e372f52f3 St

[jfx18] RFR: 8278980: Update WebKit to 613.1

2022-04-13 Thread Johan Vos
Co-authored-by: Ajit Ghaisas Co-authored-by: Jay Bhaskar Co-authored-by: Kevin Rushforth Reviewed-by: kcr, jvos, aghaisas - Commit messages: - 8278980: Update WebKit to 613.1 Changes: https://git.openjdk.java.net/jfx/pull/770/files Webrev: https://webrevs.openjdk.java.net/?repo=

[jfx18] Integrated: 8278980: Update WebKit to 613.1

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 12:35:18 GMT, Johan Vos wrote: > Co-authored-by: Ajit Ghaisas > Co-authored-by: Jay Bhaskar > Co-authored-by: Kevin Rushforth > Reviewed-by: kcr, jvos, aghaisas This pull request has now been integrated. Changeset: f19b57ae Author: Johan Vos URL:

[jfx18] RFR: 8281459: WebKit 613.1 build broken on M1

2022-04-13 Thread Johan Vos
Reviewed-by: kcr, jvos - Commit messages: - 8281459: WebKit 613.1 build broken on M1 Changes: https://git.openjdk.java.net/jfx/pull/771/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=771&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281459 Stats: 20 lin

[jfx18] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 13:43:18 GMT, Johan Vos wrote: > Reviewed-by: kcr, jvos This pull request has now been integrated. Changeset: 1d74 Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/1d74d01addf3b6481f0af7866c8454b6cfdf Stats: 20 lines in 1 file changed

[jfx18] RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
Stabilization fixes from WebKitGTK 2.34.5 Reviewed-by: jvos, kcr - Commit messages: - 8281711: Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx/pull/772/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=772&range=00 Issue: https://

[jfx18] Withdrawn: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 14:15:29 GMT, Johan Vos wrote: > Stabilization fixes from WebKitGTK 2.34.5 > > Reviewed-by: jvos, kcr This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jfx/pull/772

[jfx18] RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
Stabilization fixes from WebKitGTK 2.34.5 Reviewed-by: jvos, kcr - Commit messages: - 8281711: Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx/pull/773/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=773&range=00 Issue: https://

[jfx18] Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 15:22:22 GMT, Johan Vos wrote: > Stabilization fixes from WebKitGTK 2.34.5 > > Reviewed-by: jvos, kcr This pull request has now been integrated. Changeset: 0402975a Author: Johan Vos URL: https://git.openjdk.java.net/j

[jfx18] RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-04-13 Thread Johan Vos
Reviewed-by: kcr, jvos - Commit messages: - 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx/pull/774/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=774&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-828209

[jfx18] Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 16:00:41 GMT, Johan Vos wrote: > Reviewed-by: kcr, jvos This pull request has now been integrated. Changeset: 7e2cefba Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/7e2cefba7f28fc0570b7495a08203756caa5327c Stats: 186 lines in 11 files chan

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-04-14 Thread Johan Vos
On Wed, 30 Mar 2022 13:27:40 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size

Re: RFR: Request to sync April 2022 changes into jfx master

2022-04-19 Thread Johan Vos
Approved. On Tue, Apr 19, 2022 at 6:03 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to sync changes from to the just-released April 2022 > CPU release into the 'master' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > > https://github.com/kevinrus

Re: [jfx18, jfx17u, jfx11u] RFR: Request to backport April 2022 CPU changes

2022-04-19 Thread Johan Vos
Approved. On Tue, Apr 19, 2022 at 6:03 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released April > 2022 CPU to jfx:jfx18 (for 18.0.1), jfx17u (for 17.0.3) and to jfx11u > (for 11.0.15) . > > https://github.com/kevinrushforth/jfx17u/compare/

[jfx11u] RFR: 8285152: Change JavaFX release version to 11.0.16 in jfx11u

2022-04-19 Thread Johan Vos
Update security version for JavaFX 11 to 16. - Commit messages: - Update security version for JavaFX 11 to 16. Changes: https://git.openjdk.java.net/jfx11u/pull/83/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u&pr=83&range=00 Issue: https://bugs.openjdk.java.net/brow

<    1   2   3   4   5   6   7   8   9   10   >