> On 12/15/2019 6:06 PM, Nir Lisker wrote:
>
> Replying on the mailing list to the questions raised on GitHub.
>
> The state of whether to use the computed center pivot or the value of the
>> pivot attribute is implicit with no way for an application to know which it
>>
Do other projects also have multi-reviewers requirements?
I would think that at least for a CSR, which is OpenJDK-wide, a request
could be put in with the Skara to track it. A Reviewer (or Committer?)
could invoke a /csr command which will require the PR author to provide a
link to the CSR, and
On Wed, 11 Dec 2019 16:06:48 GMT, Kevin Rushforth wrote:
>> The finalize() method is deprecated in JDK9. See [Java 9 deprecated
>> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html).
>> And so the
>>
On Thu, 12 Dec 2019 21:52:05 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
On Thu, 12 Dec 2019 22:02:27 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
Replying on the mailing list to the questions raised on GitHub.
The state of whether to use the computed center pivot or the value of the
> pivot attribute is implicit with no way for an application to know which it
> is, and no way to set it back to using the computed center (i.e., the state
>
The bot doesn't know how many reviewers are needed. This was brought up
before in point 3 in
http://mail.openjdk.java.net/pipermail/openjfx-dev/2019-October/023662.html.
- Nir
On Mon, Dec 16, 2019 at 2:24 PM Jeanette Winzenburg
wrote:
>
> Looks like it assumes a pull request as properly
Thanks Michael.
Kevin, if these are approved I can add them to the build instructions page.
- Nir
On Sat, Oct 19, 2019 at 7:07 PM Michael Franz wrote:
> Hi,
>
> Just to report that I was able to get OpenJFX development setup on CentOS 8
> using the following steps:
> 0. sudo yum update
> 1.
pulls in the needed
> libX11 developer package)), but it seems a good list.
>
> -- Kevin
>
>
> On 10/19/2019 9:11 AM, Nir Lisker wrote:
> > Thanks Michael.
> >
> > Kevin, if these are approved I can add them to the build instructions
> page.
> >
> > -
If you have at least an Author role you will be given a JBS account.
Otherwise, use the link https://bugs.java.com and your bug will be
transferred to JBS after triage.
- Nir
On Sun, Oct 27, 2019 at 10:51 PM Dan Howard wrote:
> How do you register to file a bug? I don't see any registration
rded in build.properties [4].
>
> -- Kevin
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8232063
> [2] https://bugs.openjdk.java.net/browse/JDK-8232064
> [3] https://github.com/gradle/gradle/milestones
> [4] https://github.com/openjdk/jfx/blob/master/build.properties#L75
>
>
Sorry, that was my mistake when I updated that page for Skara. We usually
list JDK N and N-1 as compatible for JFX N and I missed that Gradle is not
there yet for 13.
Use JDK 12 for now.
- Nir
On Fri, Oct 18, 2019, 09:02 Robert Lichtenberger
wrote:
> In trying to provide a fix for JDK-8232524
By the way, Gradle 6.0 RC1 is due today. It could be beneficial to test the
build with it prior to the release of 6.0.
On Fri, Oct 18, 2019 at 4:16 PM Nir Lisker wrote:
> By way of information, the current toolchain versions used by the JavaFX
>> build are recorded in build.prop
On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote:
> On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote:
>
>> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote:
>>
>>> The pull request has been updated with additional changes.
>>>
>>>
>>>
>>> Added commits:
>>> -
I triage and self-assign my issues by the dozens :)
On Sat, Oct 26, 2019 at 7:07 PM Philip Race wrote:
> I see no problem with filing a bug .. and bonus points for assigning it
> to yourself and triaging it.
>
> -phil.
>
> On 10/26/19, 8:20 AM, Jeanette Winzenburg wrote:
> >
> > ar ...
On Mon, 18 Nov 2019 18:00:46 GMT, Nir Lisker wrote:
> On Mon, 18 Nov 2019 18:00:45 GMT, Nir Lisker wrote:
>
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>>
>>
>>
>> Commits:
>> - a388fb92: Fixed whitespaces
>> -
Changeset: 8bea7b71
Author:Nir Lisker
Date: 2019-11-20 06:53:00 +
URL: https://git.openjdk.java.net/jfx/commit/8bea7b71
8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors
Reviewed-by: kcr, arapte
!
modules/javafx.base/src/main/java/javafx/beans/property
On Mon, 18 Nov 2019 18:12:13 GMT, Kevin Rushforth wrote:
> On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote:
>
>> On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote:
>>
>>> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote:
>>>
>>
On Wed, 30 Oct 2019 14:01:58 GMT, Hadzic Samir wrote:
> On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote:
>
>> The pull request has been updated with additional changes.
>>
>>
>>
>> Added commits:
>> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader
>>
>>
Hi Kevin,
A few questions and comments:
1. I'm getting double notifications from threads I'm subscribed to - one
from GitHub and one from the bot, including notifications on my own
comments. The Skara bot doesn't need to notify me on threads I'm subscribed
to.
2. Are the hg files like hgignore
On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote:
> The pull request has been updated with additional changes.
>
>
>
> Added commits:
> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for
> clarification on TableColumnHeader
>
> Changes:
> - all:
the comment a reviewer would make
anyway to inform the PR author how many reviewers they should wait for.
Extending the bot to look for n reviewers instead of the current 1 should
not be far fetched.
>
>
On Wed, Dec 18, 2019 at 4:02 AM Philip Race wrote:
>
>
> On 12/16/19, 4:
On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8185886
>
> Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays
> to improve listener removal speed.
>
> This was due to the removal of listeners in TableView taking up
Hi,
Animation's cycleDuration property says that the computation assumes a rate
of 1.0. However, Sequential and Parallel transitions both take the rate
into account in computeCycleDuration(). Is this a mistake?
- Nir
> Resubmitting from before the transition to this repo. See linked issue for
> details.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 12178c7f: Renamed `put` to `entry` as per review comment
Changes:
- all:
On Mon, 2 Mar 2020 08:31:47 GMT, dannygonzalez
wrote:
>> In use cases where a large number of listeners are being discarded, it may
>> be better to first consider changing the design to receive event
>> notifications on nodes whose listener registrations are not frequently
>> discarded.
>
>>
Changeset: 960f0390
Author:Nir Lisker
Date: 2020-03-03 14:04:34 +
URL: https://git.openjdk.java.net/jfx/commit/960f0390
8208761: Update constant collections to use the new immutable collections
Reviewed-by: arapte, kcr
!
modules/javafx.controls/src/main/java/javafx/scene
On Fri, 28 Feb 2020 01:19:23 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> I finished my review and tested this on all platforms. It looks good to me.
>
> The only comment I have is the one inline comment I left in `KeyCodeMap.java`
> about
On Mon, 24 Feb 2020 11:04:26 GMT, dannygonzalez
wrote:
>> Just wanted to keep a similar behaviour as before using the same calculation
>> based originally on the size of the listeners array list and now based on
>> the size of the map. So in theory the weak listeners should be trimmed at
>>
On Mon, 24 Feb 2020 09:14:51 GMT, dannygonzalez
wrote:
>> I agree, I kept these in as I wasn't sure if there was a need to manually
>> force the garbage collection of weak listeners at the same rate as the
>> original implementation.
>> Removing this would make sense to me also.
>>
>>
On Mon, 24 Feb 2020 11:09:30 GMT, dannygonzalez
wrote:
>> Agreed, will change.
>
> Nope, actually:
> `listeners.keySet().removeIf(p::test) `
>
> is not the same as:
> `listeners.entrySet().removeIf(e -> p.test(e.getKey()));`
>
> We need to test against the entrySet.key not the entrySet
On Tue, 25 Feb 2020 12:18:34 GMT, dannygonzalez
wrote:
>> I haven't done a detailed review yet, but I worry about the memory
>> consumption and performance of using a Map for the simple cases where there
>> is only a single (or very small number) of listeners. These methods are used
>> in
On Fri, 24 Jan 2020 17:16:13 GMT, Frederic Thevenet
wrote:
>> I don't, to be honest.
>> The results for some dimensions (not always the same) can vary pretty
>> widely from one run to another, despite all my effort to repeat results and
>> remove outliers.
>> Out of curiosity, I also tried
On Sat, 25 Jan 2020 19:55:23 GMT, Nir Lisker wrote:
>> With regard as to why the tiling version is significantly slower, though, I
>> do have a pretty good idea; as Kevin hinted, the pixel copy into a temporary
>> buffer before copying into the final image is where m
On Wed, 29 Jan 2020 15:42:51 GMT, Kevin Rushforth wrote:
>> I need to re-review the updated PR.
>
> The code changes look good to me. As long as you are willing to address the
> follow-on issues for openjfx15, I'll approve this PR for openjfx14, once I
> run my last test.
>
> I did a fair
On Wed, 29 Jan 2020 20:47:11 GMT, Kevin Rushforth wrote:
>> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
>> not play backwards after being paused) has been split to deal with
>> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
>>
Resubmitting from before the transition to this repo. See linked issue for
details.
-
Commits:
- 440e7a88: Initial commit of 8208761
Changes: https://git.openjdk.java.net/jfx/pull/104/files
Webrev: https://webrevs.openjdk.java.net/jfx/104/webrev.00
Issue:
> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
> not play backwards after being paused) has been split to deal with
> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
> embedded](https://bugs.openjdk.java.net/browse/JDK-8237975) animations.
On Fri, 31 Jan 2020 00:31:17 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks fine, and all my testing looks good, too. I don't have a good
> recommendation for the test...I'd go with whatever is easiest for jfx14 and
> address it
Changeset: 1749e854
Author:Nir Lisker
Date: 2020-02-03 12:29:43 +
URL: https://git.openjdk.java.net/jfx/commit/1749e854
8237975: Non-embedded Animations do not play backwards after being paused
Reviewed-by: kcr, arapte
!
modules/javafx.graphics/src/main/java/com/sun
Changeset: 1749e854
Author:Nir Lisker
Date: 2020-02-03 12:29:43 +
URL: https://git.openjdk.java.net/jfx/commit/1749e854
8237975: Non-embedded Animations do not play backwards after being paused
Reviewed-by: kcr, arapte
!
modules/javafx.graphics/src/main/java/com/sun
On Fri, 24 Jan 2020 16:26:38 GMT, Frederic Thevenet
wrote:
>> Here are the results when running JavaFX 14-ea+7.
>> The columns of the table correspond the width of the target snapshot, while
>> the rows correspond to the height and the content of the cells is the
>> average time* spent (in
Changeset: 9ae37f1f
Author:Nir Lisker
Date: 2020-01-22 20:58:12 +
URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f
8236753: Animations do not play backwards after being stopped
Reviewed-by: kcr, arapte
! modules/javafx.graphics/src/main/java/javafx/animation
Hi Ed,
Try to search JBS [1] for this issue. If you don't find one, you can submit
it through bugs.java.com, though I suspect this is known.
I don't know the technicalities of VirtualFlow in TableView, so can't help
there.
- Nir
[1] https://bugs.openjdk.java.net/issues/?jql=component %3D
th submitting a new bug report. The closest I found
> were
> JDK-8166956 [1] and JDK-8185887 [2].
>
> I also would be interested to know whether others have run into this
> in
> their applications.
>
> -- Kevin
>
> [1] https://bugs.openjdk.java.net/br
[8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do not
play backwards after being paused) has been split to deal with
[embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
embedded](https://bugs.openjdk.java.net/browse/JDK-8237975) animations. This is
a
On Tue, 28 Jan 2020 19:19:57 GMT, Nir Lisker wrote:
> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
> not play backwards after being paused) has been split to deal with
> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
> emb
Thanks Peter, I added the info.
- Nir
On Wed, Feb 5, 2020 at 9:55 AM Peter, Benjamin wrote:
> Hi devs,
>
> about JDK-8150263 : ObservableListWrapper fires change notifications from
> sort() and sort(Comparator) even if list is not changed.
>
> I stumbled about the problem and prepared a
> Docs fixes for OpenJFX 14. We can wait with integrating this in case there
> are last minute fixes, but reviews can start.
The pull request has been updated with 2 additional commits.
-
Added commits:
- 75d34b85: Update copyright year
- 131850d2: Fix extra }
Changes:
- all:
On Tue, 18 Feb 2020 18:15:30 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 2 additional commits.
>
> modules/javafx.base/src/main/java/javafx/collections/ListChangeListener.java
> line 234:
>
>> 233: *
>> 234: * for (Node n :
> Docs fixes for OpenJFX 14. We can wait with integrating this in case there
> are last minute fixes, but reviews can start.
The pull request has been updated with 2 additional commits.
-
Added commits:
- 6ef5518c: Revert copyright year change
- 200ac8c3: Revert extra }
Changes:
Changeset: 35a01caf
Author:Nir Lisker
Date: 2020-02-19 14:35:56 +
URL: https://git.openjdk.java.net/jfx/commit/35a01caf
8228867: Fix mistakes in FX API docs
Reviewed-by: jvos, kcr
! modules/javafx.base/src/main/java/javafx/collections/FXCollections.java
! modules
On Fri, 14 Feb 2020 14:23:45 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` --
On Thu, 20 Feb 2020 20:43:22 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` --
On Tue, 11 Feb 2020 07:17:43 GMT, Ambarish Rapte wrote:
>> Resubmitting from before the transition to this repo. See linked issue for
>> details.
>
> modules/javafx.graphics/src/main/java/com/sun/prism/j2d/print/J2DPrinter.java
> line 632:
>
>> 631:
>> 632: private static Map
> Resubmitting from before the transition to this repo. See linked issue for
> details.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 8bf73ca1: Fixes for review comments
Changes:
- all: https://git.openjdk.java.net/jfx/pull/104/files
- new:
On Tue, 11 Feb 2020 18:53:08 GMT, Kevin Rushforth wrote:
>> Docs fixes for OpenJFX 14. We can wait with integrating this in case there
>> are last minute fixes, but reviews can start.
>
> The changes so far look fine. As you say, we can wait for a bit to finish the
> review of this.
>
> One
On Thu, 13 Feb 2020 23:13:06 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` --
On Wed, 5 Feb 2020 13:48:45 GMT, Kevin Rushforth wrote:
>> We have a few performance tests in apps/performance, but I don't know how up
>> to date they are. They might give you a starting point on how to measure
>> FPS, but really the harder part is going to be coming up with a workload --
>>
On Thu, 20 Feb 2020 05:15:25 GMT, Guru Hb wrote:
> Updating SQlite to 3.31.1 (Currently used 3.30.1).
@rwestberg When the author closes their PR, shouldn't the bot remove the `rfr`
label?
-
PR: https://git.openjdk.java.net/jfx/pull/118
On Mon, 17 Feb 2020 01:53:18 GMT, Nir Lisker wrote:
>> Looks like the `jcheck` bot removed the `rfr` label because the CSR isn't
>> complete. An incomplete CSR should be treated the same way as an
>> insufficient number of reviewers. I filed
>> [SKARA-262](https://bugs
I was thinking about this some more. We could use ObjectProperty as
this would allow to set nulls in order to reset the value to the default
node's center, and will allow independent axis control and binding. It's
rather ugly though in my opinion.
On Tue, Dec 17, 2019 at 2:46 AM Nir Lisker wrote
On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8185886
>
> Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays
> to improve listener removal speed.
>
> This was due to the removal of listeners in TableView taking up
On Fri, 14 Feb 2020 20:47:04 GMT, Nir Lisker wrote:
>> @arapte I request you to be one of the reviewers of this PR.
>
> I'll be the 2nd reviewer.
> the referent to the created property object has been garbage collected before
> the `finalize` method is called
On Tue, 18 Feb 2020 20:09:59 GMT, Kevin Rushforth wrote:
>>> the referent to the created property object has been garbage collected
>>> before the `finalize` method is called
>>
>> I'm confused. What is that referent exactly and why is it guaranteed to have
>> been GC'd before finalization?
>
The private field `lastPlayFinished` is responsible for 2 cases where an
animation in `STOPPED` status does not play after `play()` is called if the
rate is negative:
1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is
`false`. Setting a negative rate and calling
.
On Sat, Jan 11, 2020 at 3:08 AM Nir Lisker wrote:
> What happens if you set the rate of the parent transition and then set the
>> rate of a child animation?
>>
> What if you bind to the rate of a child animation?
>
>
> There is already some code that touches t
ion actually modifies the child
> node. This can work, but has more issues. What happens if you set the
> rate of the parent tansition and then set the rate of a child animation?
> What if you bind to the rate of a child animation?
>
> -- Kevin
>
> On 1/1/2020 1:04 PM,
On Fri, 3 Jan 2020 23:02:56 GMT, Nir Lisker wrote:
>>> I still need to test your sample app on Mac.
>>
>> I get the error with your sample app. It fails on Mac or Linux (Ubuntu
>> 16.04) with the same error as I reported above.
>
> The error was for the cases
I updated the eclipse instructions. Have a look.
Thanks,
Nir
On Tue, Jan 14, 2020 at 1:01 PM Robert Lichtenberger <
r.lichtenber...@gmail.com> wrote:
> As a follow-up to the long thread on using an IDE. I just found out that
> running test.javafx.scene.web.WebViewTest is not possible with
>
On Thu, 16 Jan 2020 01:06:30 GMT, Nir Lisker wrote:
>> The fix looks good to me.
>> After this change the steps needed for playing an `Animation` backwards will
>> change.
>> Earlier this was documented with `Animation.play()` API as below.
>>
>> --
On Tue, 14 Jan 2020 16:50:12 GMT, Ambarish Rapte wrote:
>> I should add that it will depend on whether there are any regressions. One
>> thing we do need to be careful of is introducing regressions during rampdown.
>
> The fix looks good to me.
> After this change the steps needed for playing
On Thu, 16 Jan 2020 17:00:47 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
On Fri, 17 Jan 2020 19:22:24 GMT, Kevin Rushforth wrote:
>> I'm not 100% convinced this would really add much to the readability of the
>> code; I extracted the code from `doSnapshotTile` in its own method because
>> it is called twice (on both sides of the `if (height > maxTextureSize ||
>>
On Fri, 17 Jan 2020 22:48:11 GMT, Kevin Rushforth wrote:
>>> So this PR may need a document change for `Animation.play()`
>>
>> Yes, and the docs need clarification in other places anyway. The [parent
>> issue](https://bugs.openjdk.java.net/browse/JDK-8210238) from which this bug
>> was
> The private field `lastPlayFinished` is responsible for 2 cases where an
> animation in `STOPPED` status does not play after `play()` is called if the
> rate is negative:
>
> 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is
> `false`. Setting a negative rate and
wrong here? Smells like module system
> problems :-(.
>
>
> Best regards,
>
> Robert
> On 2020-01-10 17:52, Nir Lisker wrote:
>
> Hi Robert,
>
> I've brought this up in the past.
>
> I think that the best solution is for someone from the community to take
> that t
l respond inline.
>
>
> On 1/10/2020 6:45 PM, Nir Lisker wrote:
>
> I forgot to bring up https://bugs.openjdk.java.net/browse/JDK-8200206,
> which is also relevant to this discussion. The solution to that one is
> probably allowing only 1 parent, similar to the scenegraph po
Changeset: 9ae37f1f
Author:Nir Lisker
Date: 2020-01-22 20:58:12 +
URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f
8236753: Animations do not play backwards after being stopped
Reviewed-by: kcr, arapte
! modules/javafx.graphics/src/main/java/javafx/animation
> wrote:
>
> That's an interesting idea. It would, of course, need to disallow reducing
> the number below the minimum specified in .jcheck/conf (e.g., we wouldn't
> allow "/reviewers 0").
>
> -- Kevin
>
>
> On 12/18/2019 10:36 AM, Nir Lisker wrote:
>
> The client l
Looks like an all-or-nothing situation - either any commit requires
re-approval or no commit requires re-approval. In this case, I would say
that all commits should require re-approval since it's the safer approach.
Having the issue stay in approved state after a significant change is much
worse
Hi Robert,
I've brought this up in the past.
I think that the best solution is for someone from the community to take
that task. I try to keep the Eclipse section updated, we will need someone
for the other IDE's.
- Nir
On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger <
> * choose "Import projects" then "Gradle" -> "Existing Gradle project"
> >> > * give the top level folder of my repository (/home/rli/PWEs/jfx in my
> >> case)
> >> > * Use the gradle wrapper (i.e. no changes on the wizards next
; > * Use the gradle wrapper (i.e. no changes on the wizards next page)
> > > * The project structure is given correctly, so I click finish
> > >
> > > Eclipse then loads the projects but gives out the aforementioned error.
> > >
> > > I've made a 1-minute video cli
On Fri, 20 Dec 2019 21:56:32 GMT, Kevin Rushforth wrote:
>> The bug I mentioned above is not a bug actually. There are large changes
>> over a small distance that make it looks like a jump in the lighting values,
>> but when working with a finer scale the lighting dynamics seem correct.
>
> I
On Fri, 3 Jan 2020 09:21:32 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 64:
>
>> 63:
>> 64: private double ca = DEFAULT_CA;
>> 65:
>
> The
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- f66e8cf4: Addressing review comments
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 3 Jan 2020 05:08:33 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 43:
>
>> 42: private static final double DEFAULT_MAX_RANGE =
>>
On Fri, 3 Jan 2020 05:17:26 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41:
>
>> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}.
>> 41: *
>>
On Fri, 3 Jan 2020 09:25:21 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 175:
>
>> 174: lightsAttenuation[a++] = lights[i].attenuation[2];
>> 175:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- 464e8b5d: Fixed shader compilation errors for 2 and 3 lights in es2
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 3 Jan 2020 22:23:29 GMT, Kevin Rushforth wrote:
>> I was wondering about it myself, but all the other values are `double`s that
>> are cast to `float`s. Wouldn't it also be odd to have the API properties
>> `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of
>>
On Fri, 3 Jan 2020 22:37:06 GMT, Kevin Rushforth wrote:
>> I have added few comments, but have not run tests and sample yet.
>
>> I still need to test your sample app on Mac.
>
> I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04)
> with the same error as I reported
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- 66cdab32: Attenuation and range changed internally to floats from doubles
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
-
Hi,
As part of my work in the animations package I've come across an undefined
spec. Is the rate of an animation that is embedded in a Parallel/Sequential
transition inherited and overridden by its parent?
If I have an animations with a rate of 1 and a parent with a rate of 2, and
I add the
On Fri, 6 Mar 2020 17:51:08 GMT, Nir Lisker wrote:
> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
>
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
Why was the rfr label not reinstated?
-
PR: https://git.openjdk.java.net/jfx/pull/140
Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
[CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
-
Commits:
- 7548c723: Initial commit
Changes: https://git.openjdk.java.net/jfx/pull/140/files
Webrev:
On Tue, 3 Mar 2020 16:12:23 GMT, Kevin Rushforth wrote:
> The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic
> parameter if not surrounded by `<` and `>`. This will in turn fail the build,
> since we treat warnings as errors. There are 5 classes in JavaFX with this
>
On Fri, 6 Mar 2020 23:35:56 GMT, Nir Lisker wrote:
>> I note that this also changes the wrapper property objects from anonymous
>> subclasses of XPropertyBase to SimpleXProperty. This is more than
>> just a readability cleanup. It's probably fine for this case, bu
On Sat, 7 Mar 2020 00:30:21 GMT, Tom Schindl
wrote:
>> That doesn't seem right. The additional fields are captured in the
>> anonymous class anyway (same as in lambdas).
>>
>> On Sat, Mar 7, 2020 at 1:53 AM Tom Schindl wrote:
>>
>>> I can somehow remember asking Richard Bair why JavaFX
201 - 300 of 830 matches
Mail list logo
