Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-28 Thread Ambarish Rapte
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Ambarish Rapte
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]

2022-05-20 Thread Ambarish Rapte
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

Re: RFR: 8283869: Update attribution in webkit.md file

2022-05-10 Thread Ambarish Rapte
On Tue, 10 May 2022 16:37:57 GMT, Kevin Rushforth wrote: > Doc-only change to update the license attribution in our `webkit.md` file. LGTM - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/793

Re: RFR: 8284654: Modal behavior returns to wrong stage [v2]

2022-05-10 Thread Ambarish Rapte
On Mon, 9 May 2022 14:54:55 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

Re: RFR: 8284654: Modal behavior returns to wrong stage

2022-05-09 Thread Ambarish Rapte
On Fri, 6 May 2022 13:37:22 GMT, Thiago Milczarek Sayao wrote: > Did you test it on Linux? I tested it on MacOS Catalina 10.15.7 > the window should not accept focus when disabled, The window does not really gets the focus. The button cannot be clicked. but it does bring the window in

Re: RFR: 8284654: Modal behavior returns to wrong stage

2022-05-05 Thread Ambarish Rapte
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao wrote: > When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee >

Re: [jfx11u] RFR: 8274274: Update JUnit to version 5.8.1

2022-05-02 Thread Ambarish Rapte
On Sat, 30 Apr 2022 13:45:39 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u`. It isn't a clean backport since the > mainline patch updated `gradle/verification-metadata.xml`, which doesn't > exist in 11. Marked as reviewed by arapte (Reviewer). - PR:

Re: [jfx11u] RFR: 8281564: Update cmake to 3.22.3

2022-05-02 Thread Ambarish Rapte
On Sat, 30 Apr 2022 13:39:32 GMT, Kevin Rushforth wrote: > Simple backport to `jfx11u`. It isn't a clean backport since the mainline > patch had an update to `gradle/verification-metadata.xml`, which doesn't > exist in 11. Marked as reviewed by arapte (Reviewer). - PR:

[jfx17u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/

2022-05-02 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ Changes: https://git.openjdk.java.net/jfx17u/pull/51/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=51=00 Issue:

[jfx17u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/

2022-05-02 Thread Ambarish Rapte
On Mon, 2 May 2022 11:48:02 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 13ca8ee8 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/13ca8ee891486b17551f55ef93532a703de37c3e Stats: 3 lines i

[jfx17u] Integrated: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-05-02 Thread Ambarish Rapte
On Fri, 29 Apr 2022 17:14:21 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, jbhaskar This pull request has now been integrated. Changeset: 367f3d5a Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/367f3d5a8227aeb83af5fbc646329c860ca0fcdc Stats: 142 li

[jfx17u] Integrated: 8280020: Underline and line-through not straight in WebView

2022-05-02 Thread Ambarish Rapte
On Fri, 29 Apr 2022 17:10:09 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 8e52c7be Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/8e52c7bee8cd4e5aa83a6ea33572cd41026f9776 Stats: 192 lines i

[jfx17u] Integrated: 8269115: WebView paste event contains old data

2022-05-02 Thread Ambarish Rapte
On Fri, 29 Apr 2022 17:08:56 GMT, Ambarish Rapte wrote: > Reviewed-by: arapte, kcr This pull request has now been integrated. Changeset: cc835ba1 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/cc835ba1fe0a135e82c6e6461f67e3ff56cf7b37 Stats: 120 lines i

[jfx17u] Integrated: 8255940: localStorage is null after window.close()

2022-05-02 Thread Ambarish Rapte
On Fri, 29 Apr 2022 17:07:27 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: ca7303ce Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/ca7303ce40e38848a7e606b940f376e979f6e187 Stats: 168 lines i

[jfx17u] Integrated: 8278759: PointerEvent: buttons property set to 0 when mouse down

2022-05-02 Thread Ambarish Rapte
On Fri, 29 Apr 2022 17:06:02 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: dd592f13 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/dd592f13ca63abc1691b8eeff01bb03abf6ca6dc Stats: 302 lines i

[jfx17u] Integrated: 8282134: Certain regex can cause a JS trap in WebView

2022-04-29 Thread Ambarish Rapte
On Fri, 29 Apr 2022 17:04:44 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 350fb532 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/350fb53261e2d51be4ba25f538ad127aa16f6471 Stats: 22 lines i

[jfx17u] Integrated: 8280841: Update SQLite to 3.37.2

2022-04-29 Thread Ambarish Rapte
On Fri, 29 Apr 2022 16:59:33 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: e05362c9 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/e05362c9b81c91450cf928304ea3c2aefd71017a Stats: 22902 li

[jfx17u] RFR: 8255940: localStorage is null after window.close()

2022-04-29 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8255940: localStorage is null after window.close() Changes: https://git.openjdk.java.net/jfx17u/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=45=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255940

[jfx17u] RFR: 8280020: Underline and line-through not straight in WebView

2022-04-29 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8280020: Underline and line-through not straight in WebView Changes: https://git.openjdk.java.net/jfx17u/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=47=00 Issue:

[jfx17u] RFR: 8269115: WebView paste event contains old data

2022-04-29 Thread Ambarish Rapte
Reviewed-by: arapte, kcr - Commit messages: - 8269115: WebView paste event contains old data Changes: https://git.openjdk.java.net/jfx17u/pull/46/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=46=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269115 Stats:

[jfx17u] RFR: 8282134: Certain regex can cause a JS trap in WebView

2022-04-29 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8282134: Certain regex can cause a JS trap in WebView Changes: https://git.openjdk.java.net/jfx17u/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=43=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282134

[jfx17u] RFR: 8278759: PointerEvent: buttons property set to 0 when mouse down

2022-04-29 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8278759: PointerEvent: buttons property set to 0 when mouse down Changes: https://git.openjdk.java.net/jfx17u/pull/44/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=44=00 Issue:

[jfx17u] RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-04-29 Thread Ambarish Rapte
Reviewed-by: kcr, jbhaskar - Commit messages: - 8270867: Debug build of WebKit 613.1 fails on Linux Changes: https://git.openjdk.java.net/jfx17u/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=48=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270867

[jfx17u] RFR: 8280841: Update SQLite to 3.37.2

2022-04-29 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8280841: Update SQLite to 3.37.2 Changes: https://git.openjdk.java.net/jfx17u/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=42=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280841 Stats: 22902 lines in 5

[jfx11u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ Changes: https://git.openjdk.java.net/jfx11u/pull/92/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=92=00 Issue:

[jfx11u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 18:12:41 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: f8d4b48b Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/f8d4b48b03e2af4ec1f927448a4cf95303a29a9f Stats: 3 lines i

[jfx11u] Integrated: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:52:40 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, jbhaskar This pull request has now been integrated. Changeset: 8706f989 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/8706f9893a0acd3c07a7f5574e77badeb05deed3 Stats: 142 li

[jfx11u] Integrated: 8269115: WebView paste event contains old data

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:48:23 GMT, Ambarish Rapte wrote: > Reviewed-by: arapte, kcr This pull request has now been integrated. Changeset: 567685c9 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/567685c9c7bf7d8d779701c6709856be328c1cd4 Stats: 120 lines i

[jfx11u] Integrated: 8280020: Underline and line-through not straight in WebView

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:50:08 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 104e7b67 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/104e7b67ed7714cd3c5849d5012f5877ef2f57dc Stats: 192 lines i

[jfx11u] Integrated: 8255940: localStorage is null after window.close()

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:46:45 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 57e4c94a Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/57e4c94a0bc1a47d2381e86275a7d8a53ce4ce5e Stats: 168 lines i

[jfx11u] Integrated: 8278759: PointerEvent: buttons property set to 0 when mouse down

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:16:40 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: c2c62ff4 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/c2c62ff459edded8284c09307fb6d709b54aebef Stats: 302 lines i

[jfx11u] Integrated: 8282134: Certain regex can cause a JS trap in WebView

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:13:19 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 3cfee273 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/3cfee27342f3b1fc1b8533823f50ebd9660955e4 Stats: 22 lines i

[jfx11u] RFR: 8280020: Underline and line-through not straight in WebView

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8280020: Underline and line-through not straight in WebView Changes: https://git.openjdk.java.net/jfx11u/pull/90/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=90=00 Issue:

[jfx11u] Integrated: 8280841: Update SQLite to 3.37.2

2022-04-28 Thread Ambarish Rapte
On Thu, 28 Apr 2022 17:04:37 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 6fe09f46 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/6fe09f4618a6767d323f4c490014a7eea6756da8 Stats: 22902 li

[jfx11u] RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, jbhaskar - Commit messages: - 8270867: Debug build of WebKit 613.1 fails on Linux Changes: https://git.openjdk.java.net/jfx11u/pull/91/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=91=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270867

[jfx11u] RFR: 8255940: localStorage is null after window.close()

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8255940: localStorage is null after window.close() Changes: https://git.openjdk.java.net/jfx11u/pull/88/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=88=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255940

[jfx11u] RFR: 8269115: WebView paste event contains old data

2022-04-28 Thread Ambarish Rapte
Reviewed-by: arapte, kcr - Commit messages: - 8269115: WebView paste event contains old data Changes: https://git.openjdk.java.net/jfx11u/pull/89/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=89=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269115 Stats:

[jfx11u] RFR: 8278759: PointerEvent: buttons property set to 0 when mouse down

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8278759: PointerEvent: buttons property set to 0 when mouse down Changes: https://git.openjdk.java.net/jfx11u/pull/87/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=87=00 Issue:

[jfx11u] RFR: 8282134: Certain regex can cause a JS trap in WebView

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8282134: Certain regex can cause a JS trap in WebView Changes: https://git.openjdk.java.net/jfx11u/pull/86/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=86=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282134

[jfx11u] RFR: 8280841: Update SQLite to 3.37.2

2022-04-28 Thread Ambarish Rapte
Reviewed-by: kcr, arapte - Commit messages: - 8280841: Update SQLite to 3.37.2 Changes: https://git.openjdk.java.net/jfx11u/pull/85/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=85=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280841 Stats: 22902 lines in 5

Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests [v2]

2022-04-22 Thread Ambarish Rapte
On Fri, 22 Apr 2022 07:30:25 GMT, Ajit Ghaisas wrote: >> This PR is to cleanup a few `javafx.controls` unit tests that were ignored. >> >> Here is the list of targeted unit test classes- >> - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, >> `PaginationTest` >> - Ignored

Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests

2022-04-22 Thread Ambarish Rapte
On Thu, 21 Apr 2022 11:23:35 GMT, Ajit Ghaisas wrote: > This PR is to cleanup a few `javafx.controls` unit tests that were ignored. > > Here is the list of targeted unit test classes- > - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, > `PaginationTest` > - Ignored tests

Integrated: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows

2022-04-21 Thread Ambarish Rapte
On Thu, 21 Apr 2022 15:44:57 GMT, Ambarish Rapte wrote: > The test ServiceTest.testManyServicesRunConcurrently fails intermittently on > Windows platform with a time out error. > Test needs to be skipped until fixed. This pull request has now been integrated. Changeset: 5a023b

Integrated: 8282449: Intermittent OOM error in PredefinedMeshManagerTest

2022-04-21 Thread Ambarish Rapte
On Thu, 21 Apr 2022 15:07:38 GMT, Ambarish Rapte wrote: > This is a test only fix. The tests used to create Sphere and Cylinder of > large divisions, which could fail intermittently with OOM. > The tests were added along with the fix for > [JDK-8180151](https://bugs.openjdk.java.ne

RFR: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows

2022-04-21 Thread Ambarish Rapte
The test ServiceTest.testManyServicesRunConcurrently fails intermittently on Windows platform with a time out error. Test needs to be skipped until fixed. - Commit messages: - skip-test Changes: https://git.openjdk.java.net/jfx/pull/783/files Webrev:

RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest

2022-04-21 Thread Ambarish Rapte
This is a test only fix. The tests used to create Sphere and Cylinder of large divisions, which could fail intermittently with OOM. The tests were added along with the fix for [JDK-8180151](https://bugs.openjdk.java.net/browse/JDK-8180151). The attributes of Sphere and Cylinder were chosen such

Re: RFR: 8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8

2022-04-12 Thread Ambarish Rapte
On Fri, 11 Mar 2022 03:01:39 GMT, Alexander Matveev wrote: > - Problem was that our code which checks if URI ends with file extension was > not considering that URI can have query parameters. Fixed by checking URI > path, instead of actual URI. > - Also, creation of HLS Connection holder was

Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]

2022-04-07 Thread Ambarish Rapte
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote: >> Issue: Floating point overflow , when making end point for line drawing as >> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); >> Solution: traverse widths to calculate end point and increment start point. > > Jay Bhaskar

Integrated: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Ambarish Rapte
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. This pull request has now been integrated. Changeset: d960d639 Author: Ambarish Rapte URL: https://git.openjdk.java.net/j

Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

2022-04-05 Thread Ambarish Rapte
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, including media and

RFR: 8281564: Update cmake to 3.22.3

2022-04-04 Thread Ambarish Rapte
Update cmake to 3.22.3 Verified build on all three platforms. The sanity test looks good. - Commit messages: - cmake-update Changes: https://git.openjdk.java.net/jfx/pull/767/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=767=00 Issue:

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Ambarish Rapte
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-30 Thread Ambarish Rapte
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Build on Ubuntu

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-28 Thread Ambarish Rapte
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. I shall do a test

Re: RFR: 8283517: Update boot JDK to 18

2022-03-28 Thread Ambarish Rapte
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't need to update >

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-22 Thread Ambarish Rapte
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux,

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v10]

2022-03-08 Thread Ambarish Rapte
On Tue, 8 Mar 2022 20:32:53 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window =

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-03-08 Thread Ambarish Rapte
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window =

Re: RFR: 8280020: Underline and line-through not straight in WebView [v8]

2022-03-07 Thread Ambarish Rapte
On Mon, 7 Mar 2022 09:28:52 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add

Re: RFR: 8269115: WebView paste event contains old data [v7]

2022-03-05 Thread Ambarish Rapte
On Fri, 4 Mar 2022 02:50:24 GMT, Jay Bhaskar wrote: >> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and >> appending mime types in pasteboard operation like setPlainText, Hence it >> will append duplicate mime types in m_availMimeTypes , in this case the >> length

Re: RFR: 8255940: localStorage is null after window.close() [v9]

2022-03-04 Thread Ambarish Rapte
On Fri, 4 Mar 2022 16:55:48 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >>

Re: RFR: 8255940: localStorage is null after window.close() [v7]

2022-03-01 Thread Ambarish Rapte
On Tue, 1 Mar 2022 02:42:54 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >>

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Marked as

Re: [jfx11u] RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. Marked as reviewed by arapte

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v4]

2022-03-01 Thread Ambarish Rapte
On Tue, 1 Mar 2022 06:19:04 GMT, Hima Bindu Meda wrote: >> Basically, buttons property is a mask which represents the button/buttons >> clicked on the mouse. >> It is observed that event.buttons property is set to 0 when there is >> mouse press or drag event.This behaviour is observed only

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Verified that

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v3]

2022-02-28 Thread Ambarish Rapte
On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda wrote: >> Basically, buttons property is a mask which represents the button/buttons >> clicked on the mouse. >> It is observed that event.buttons property is set to 0 when there is >> mouse press or drag event.This behaviour is observed

Re: RFR: 8269115: WebView paste event contains old data

2022-02-24 Thread Ambarish Rapte
On Tue, 8 Feb 2022 11:13:20 GMT, Jay Bhaskar wrote: > Issue: The DataObject uses m_availMimeTypes as Vector of strings, and > appending mime types in pasteboard operation like setPlainText, Hence it will > append duplicate mime types in m_availMimeTypes , in this case the length >

Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-23 Thread Ambarish Rapte
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. This pull request has now been integrated. Changeset: 6f201f7a Author:Ambarish Rapte URL: https://git.openjdk.java.n

RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Ambarish Rapte
Include additional stabilization fixes of WebKit 613.1 Sanity testing did not show any concerns. - Commit messages: - Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx/pull/740/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=740=00

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Ambarish Rapte
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Ambarish Rapte
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView

2022-02-22 Thread Ambarish Rapte
On Sat, 19 Feb 2022 11:43:00 GMT, Jay Bhaskar wrote: > Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can > cause a JS trap in WebView Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/739

Re: RFR: 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start

2022-02-21 Thread Ambarish Rapte
On Wed, 16 Feb 2022 16:46:47 GMT, Kevin Rushforth wrote: > The `javafx.graphics` module has a number of native libraries, including the > redistributable Microsoft DLLs on Windows. When running an application using > the standalone JavaFX SDK, we load all of the needed DLLs from the SDK `bin`

Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-02-17 Thread Ambarish Rapte
On Wed, 16 Feb 2022 08:07:35 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. This pull request has now been integrated. Changeset: 418d3437 Author:Ambarish Rapte URL: https://git.openjdk.java.n

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]

2022-02-16 Thread Ambarish Rapte
On Wed, 16 Feb 2022 08:49:15 GMT, danielpeintner wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct unintentional change > > modules/javafx.web/src/main/native/Source/Ja

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]

2022-02-16 Thread Ambarish Rapte
> Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: correct unintentional change - Changes: - all:

RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-02-16 Thread Ambarish Rapte
Include additional stabilization fixes of WebKit 613.1 Sanity testing did not show any concerns. - Commit messages: - Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx/pull/733/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=733=00

Re: RFR: 8280841: Update SQLite to 3.37.2 [v3]

2022-02-10 Thread Ambarish Rapte
On Thu, 10 Feb 2022 05:56:47 GMT, Hima Bindu Meda wrote: >> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version >> 3.32.3. >> >> Website : https://www.sqlite.org/index.html >> Source code can be found from https://www.sqlite.org/download.html at >>

Integrated: 8281459: WebKit 613.1 build broken on M1

2022-02-10 Thread Ambarish Rapte
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > W

RFR: 8281459: WebKit 613.1 build broken on M1

2022-02-09 Thread Ambarish Rapte
This seems like a bad merge issue. There were duplicate copies of four methods in `MacroAssemblerARM64.h` which caused WebKit build failure on Mac M1 machines. Just removing the methods removes the error. With the changes in this PR, now the file `MacroAssemblerARM64.h` matches with the WebKit

Re: RFR: 8280841: Update SQLite to 3.37.2

2022-02-08 Thread Ambarish Rapte
On Fri, 4 Feb 2022 12:53:51 GMT, Hima Bindu Meda wrote: > Updated SQLite to 3.37.2 released on 2022-01-06 from the current version > 3.32.3. > > Website : https://www.sqlite.org/index.html > Source code can be found from https://www.sqlite.org/download.html at >

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Ambarish Rapte
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]

2022-02-07 Thread Ambarish Rapte
On Sat, 8 Jan 2022 17:30:55 GMT, Michael Strauß wrote: >> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype >> specified for images encoded in data URIs. This should be improved as >> follows: >> >> 1. If the specified image subtype is not supported, an exception will

Integrated: 8278980: Update WebKit to 613.1

2022-02-04 Thread Ambarish Rapte
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is re

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Ambarish Rapte
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote: > You may have noticed ... The change file contains changes that are not > related to the WebKit upgrade. It looks like you're reverting to an older > version. Thanks for pointing it out. It is corrected now. Thanks @kevinrushforth for quick

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-02 Thread Ambarish Rapte
bugs.openjdk.java.net/browse/JDK-8280421) Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: Restore commits that were mistakenly reverted. 8279013: ES2Pipeline fails to detect AMD vega20 graphics card 8277853: With Touch enab

RFR: 8278980: Update to 613.1 version of WebKit

2022-02-02 Thread Ambarish Rapte
Update JavaFX WebKit to GTK WebKit 2.34 (613.1). Verified the updated version build, tests run and sanity testing. This does not cause any issues except a unit test failure `IrresponsiveScriptTest`. It is recorded and ignored using [JDK-8280421](https://bugs.openjdk.java.net/browse/JDK-8280421)

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-25 Thread Ambarish Rapte
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-25 Thread Ambarish Rapte
On Tue, 25 Jan 2022 00:40:18 GMT, Kevin Rushforth wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8280280: Update boot JDK to 17.0.2

2022-01-20 Thread Ambarish Rapte
On Wed, 19 Jan 2022 18:43:31 GMT, Kevin Rushforth wrote: > JDK 17.0.2 shipped yesterday as part of the January CPU release. We should > update the JavaFX 18 build to use that version, so this is targeted for > `jfx18`. Marked as reviewed by arapte (Reviewer). - PR:

Re: RFR: 8279615: Change JavaFX release version to 19

2022-01-07 Thread Ambarish Rapte
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2021 at 16:00 UTC. Marked as reviewed by arapte (Reviewer).

Re: RFR: 8279396: Define version in .jcheck/conf

2022-01-04 Thread Ambarish Rapte
On Tue, 4 Jan 2022 13:09:33 GMT, Kevin Rushforth wrote: > This patch adds the version property to `.jcheck/conf`. By doing this we can > remove the corresponding configuration from the Skara bots, which in turn > reduces the need for timing and general complexity of starting a new JavaFX >

Re: RFR: 8234921: Add DirectionalLight to the selection of 3D light types [v6]

2022-01-02 Thread Ambarish Rapte
On Mon, 20 Dec 2021 13:13:09 GMT, Nir Lisker wrote: >> Adds a directional light as a subclass of `LightBase`. I think that this is >> the correct hierarchy for it. >> >> I tried to simulate a directional light by putting a point light far away, >> but I got artifacts when the distance was

Integrated: 8279078: Update copyright header for files modified in 2021

2021-12-21 Thread Ambarish Rapte
On Tue, 21 Dec 2021 18:31:13 GMT, Ambarish Rapte wrote: > Fix for updating last modified year in the files that were modified during > year 2021. > @kevinrushforth, Please take a look. This pull request has now been integrated. Changeset: 303bcdb9 Author: Ambarish Rapte URL:

RFR: 8279078: Update copyright header for files modified in 2021

2021-12-21 Thread Ambarish Rapte
Fix for updating last modified year in the files that were modified during year 2021. @kevinrushforth, Please take a look. - Commit messages: - copyright year update 2021 Changes: https://git.openjdk.java.net/jfx/pull/699/files Webrev:

Re: [jfx17u] RFR: 8272638: Update copyright header for files modified in 2021

2021-12-10 Thread Ambarish Rapte
On Tue, 7 Dec 2021 13:30:44 GMT, Kevin Rushforth wrote: > Backport fix to update copyright changes. This was done by a script that > checks the copyright years for all files modified this year and updates the > ones that are missing 2021. As such it won't be a clean backport. Marked as

Re: [jfx11u] RFR: 8272638: Update copyright header for files modified in 2021

2021-12-10 Thread Ambarish Rapte
On Tue, 7 Dec 2021 13:31:38 GMT, Kevin Rushforth wrote: > Backport fix to update copyright headers. This was done by a script that > checks the copyright years for all files modified this year and updates the > ones that are missing 2021. As such it won't be a clean backport. Marked as

Re: RFR: 8278494: Remove .hgtags

2021-12-10 Thread Ambarish Rapte
On Thu, 9 Dec 2021 13:02:32 GMT, Kevin Rushforth wrote: > Trivial fix to remove the obsolete `.hgtags` file from the repo. As mentioned > in JBS, this file has (intentionally) not been updated since the switch to > git. It will continue to be available in the `jfx17` branch >

  1   2   3   4   5   6   7   8   >