Re: Build error with gradle (command line)

2021-05-11 Thread Johan Vos
Hi John, Regardless of the issues some of us have now, I believe the verification is a good thing to add, so thank you for that enhancement. Security often comes with a price, and if removing caches is all that it takes, I'm happy. Unrelated to that, I'm worried about the maintenance cost of

Re: Build error with gradle (command line)

2021-05-11 Thread Johan Vos
(I did a reply instead of a reply-all) Hi, I had that on one of my Linux systems too, after the fix for JDK-8264010. My first system went fine after I ran with ./gradlew --refresh-dependencies and I understood this worked for others as well. On the second system, that didn't work and I ended

Re: Build error with gradle (command line)

2021-05-11 Thread Johan Vos
On Tue, May 11, 2021 at 1:41 PM Kevin Rushforth wrote: > I see that Ajit answered already with option #1 and that you are going > to try option #2. We might want to document this on the "Building > JavaFX" Wiki page. > > To expand on this a bit, what I think must have happened is that the >

[jfx11u] Integrated: 8211294: ScrollPane content is blurry with 125% scaling

2021-05-10 Thread Johan Vos
On Mon, 10 May 2021 16:36:53 GMT, Johan Vos wrote: > Clean backport for jfx11u . Builds and tests are green. This pull request has now been integrated. Changeset: 32fda115 Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/32fda11550c1e2c7b19ef681082e03fb52552

[jfx11u] RFR: 8211294: ScrollPane content is blurry with 125% scaling

2021-05-10 Thread Johan Vos
Clean backport for jfx11u . Builds and tests are green. - Commit messages: - 8211294: ScrollPane content is blurry with 125% scaling Changes: https://git.openjdk.java.net/jfx11u/pull/16/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=16=00 Issue:

[jfx11u] Integrated: 8258381: [macos] Exception when input emoji using Chinese input method

2021-05-10 Thread Johan Vos
On Mon, 10 May 2021 10:19:04 GMT, Johan Vos wrote: > Clean backport. > This only touches the macos platform, build and basic tests work fine. This pull request has now been integrated. Changeset: debddf79 Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/

[jfx11u] RFR: 8258381: [macos] Exception when input emoji using Chinese input method

2021-05-10 Thread Johan Vos
Clean backport. This only touches the macos platform, build and basic tests work fine. - Commit messages: - 8258381: [macos] Exception when input emoji using Chinese input method Changes: https://git.openjdk.java.net/jfx11u/pull/15/files Webrev:

Re: [jfx11u] RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-05-10 Thread Johan Vos
On Sat, 8 May 2021 15:41:06 GMT, Kevin Rushforth wrote: > This is a mostly-clean backport to jfx11u. The only merge conflicts I had to > fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the > static library support is not present in 11 (this is the exact same thing I >

Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3

2021-05-07 Thread Johan Vos
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see >

Re: [jfx11u] RFR: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys

2021-05-05 Thread Johan Vos
On Wed, 5 May 2021 16:12:36 GMT, Kevin Rushforth wrote: > This is the backport of a small enhancement to add a query for CAPS_LOCK and > NUM_LOCK to jfx11u. > > The jfx mainline patch applied cleanly except for one conflict in an import > statement which had to be manually resolved. I also

Re: [jfx11u] RFR: 8260245: Update ICU4C to version 68.2

2021-05-05 Thread Johan Vos
On Wed, 5 May 2021 12:00:25 GMT, Kevin Rushforth wrote: > Backport ICU update from jfx mainline to jfx11u. The backport was clean > except for a minor diff in the surrounding context in `build.gradle`. I ran a > sanity test on Windows (I'll test on other two platforms before integrating).

Re: [jfx11u] RFR: 8262366: Update glib to version 2.66.7

2021-05-05 Thread Johan Vos
On Wed, 5 May 2021 11:57:06 GMT, Kevin Rushforth wrote: > Backport glib / gstreamer update from jfx mainline to jfx11u. The backport > applied cleanly, and I ran a sanity test on Windows (I'll test on other two > platforms before integrating). works on linux and mac - Marked as

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-05-03 Thread Johan Vos
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-05-01 Thread Johan Vos
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8264998: Empty Jars shouldn't have Automatic-Module-Name

2021-04-30 Thread Johan Vos
On Fri, 30 Apr 2021 08:42:14 GMT, Abhinay Agarwal wrote: > 8264998: Empty Jars shouldn't have Automatic-Module-Name Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/484

Re: RFR: 8265400: Update to gcc 10.3 on Linux

2021-04-29 Thread Johan Vos
On Tue, 27 Apr 2021 21:30:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK > 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). > > I ran a full build and test, including media and WebKit. Marked as reviewed

[jfx11u] Integrated: 8265703: Change JavaFX release version in jfx11u to 11.0.12

2021-04-29 Thread Johan Vos
On Thu, 29 Apr 2021 07:05:07 GMT, Johan Vos wrote: > Increase security release number for JavaFX 11 to 11.0.12 > Fix for JDK-8265703 This pull request has now been integrated. Changeset: debbd07d Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/

[jfx11u] RFR: 8265703: Change JavaFX release version in jfx11u to 11.0.12

2021-04-29 Thread Johan Vos
Increase security release number for JavaFX 11 to 11.0.12 Fix for JDK-8265703 - Commit messages: - Increase security release number for JavaFX 11 to 11.0.12 Changes: https://git.openjdk.java.net/jfx11u/pull/1/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=1=00

Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use [v2]

2021-04-29 Thread Johan Vos
On Fri, 23 Apr 2021 15:31:52 GMT, Jeanette Winzenburg wrote: >> Issue is missing update of Tree-/TableCell's editiable state when changing >> its index from editingIndex to -1. >> >> Seems to be a left-over from fixing cell's editing update - done in >>

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-27 Thread Johan Vos
On Tue, 27 Apr 2021 12:01:54 GMT, Kevin Rushforth wrote: > > May be it has sense to add a drag event handler (which disarms the > > corresponding button) to ButtonBehavior only if javafx.platform is set to > > monocle to localize the fix only for Monocle? Or add a separate property > > and

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-26 Thread Johan Vos
On Fri, 19 Feb 2021 14:19:35 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. > > To reproduce the issue run the > [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) > with Monocle: >> sudo

Integrated: 8265669: AccumCell should not be visible

2021-04-26 Thread Johan Vos
On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote: > Hide accumCell when the cell is released. > Fix for JDK-8265669 This pull request has now been integrated. Changeset: 6b63bf5c Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/6b63bf5c Stats: 13 lines in 2

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-23 Thread Johan Vos
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge

Re: RFR: 8265669: AccumCell should not be visible

2021-04-23 Thread Johan Vos
On Fri, 23 Apr 2021 13:48:16 GMT, Ajit Ghaisas wrote: > The change as such is fine, but, I have two questions at a higher level - Thanks. The answers are higher level as well, as they are more about the expectations of updateItem() > > > (from JBS description) - "This will lead to a call to

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-23 Thread Johan Vos
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge

Integrated: 8265469: Allow to build media and webkit for Linux-AArch64

2021-04-23 Thread Johan Vos
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote: > Changes that allow to build linux configuration on Linux AArch64 > This PR introduces an `IS_AARCH64` parameter in build.gradle. > This PR already contains the change from PR #465 so if this one gets > integrated, that change need

Re: RFR: 8265469: Allow to build media and webkit for Linux-AArch64 [v2]

2021-04-23 Thread Johan Vos
On Fri, 23 Apr 2021 06:22:13 GMT, Arun Joseph wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove classifier as per reviewer comment > > build.gradle line 3465: > >

Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use

2021-04-23 Thread Johan Vos
On Thu, 22 Apr 2021 10:40:15 GMT, Jeanette Winzenburg wrote: >> I see the updateEditingIndex is used as a hacky flag as the comment says, >> and `table.edit(-1, null)` is called conditionally. >> But my question is about the pre- and postconditions. What would happen if a >> subclass

Re: RFR: 8265469: Allow to build media and webkit for Linux-AArch64 [v2]

2021-04-23 Thread Johan Vos
> Changes that allow to build linux configuration on Linux AArch64 > This PR introduces an `IS_AARCH64` parameter in build.gradle. > This PR already contains the change from PR #465 so if this one gets > integrated, that change needs to removed from this PR. Johan Vos has upda

Re: RFR: 8265469: Allow to build media and webkit for Linux-AArch64

2021-04-23 Thread Johan Vos
On Thu, 22 Apr 2021 20:07:40 GMT, Kevin Rushforth wrote: >> Changes that allow to build linux configuration on Linux AArch64 >> This PR introduces an `IS_AARCH64` parameter in build.gradle. >> This PR already contains the change from PR #465 so if this one gets >> integrated, that change needs

Re: RFR: 8265425: Hard failure when building OpenJFX for Linux AArch64

2021-04-22 Thread Johan Vos
On Sat, 17 Apr 2021 16:21:20 GMT, Tor (torbuntu) wrote: > For building on aarch64 linux systems we need it added to the buuld.gradle to > stop ignoring it. Approving this so it can be integrated as soon as OCA label is gone. This is a required change for Linux AArch64, so if the OCA can be

Re: Request to backport 4 fixes to 11-dev + add README files in support of GIT transition

2021-04-22 Thread Johan Vos
Approved On Thu, Apr 22, 2021 at 12:21 AM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the following fixes to 11-dev in support > of the transition to GIT: > > 8231735: gradle checkrepo is obsolete and doesn't work with git > 8223719: Add .gitignore to repo > 8223722:

Monocle, headless isolated from embedded

2021-04-21 Thread Johan Vos
Hi, Related to the issue at https://bugs.openjdk.java.net/browse/JDK-8265633, I want to add a general observation and trigger a discussion: I hear from more users who want to bundle Monocle with desktop distributions. However, I don't think Monocle is ready at this moment to be bundled with the

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-21 Thread Johan Vos
On Tue, 13 Apr 2021 08:43:07 GMT, Alexander Scherbatiy wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove mt.exe from win.gradle build script > > I removed `ext.MC = cygpath("$winSdkBinDir/mt.exe")`

Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use

2021-04-21 Thread Johan Vos
On Wed, 21 Apr 2021 14:37:15 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TableCell.java >> line 581: >> >>> 579: // so that subclasses which override cancelEdit can execute. >>> So, >>> 580: // I have to use a kind of hacky

Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use

2021-04-21 Thread Johan Vos
On Wed, 21 Apr 2021 11:29:38 GMT, Jeanette Winzenburg wrote: > Issue is missing update of Tree-/TableCell's editiable state when changing > its index from editingIndex to -1. > > Seems to be a left-over from fixing cell's editing update - done in >

RFR: 8265669: AccumCell should not be visible

2021-04-21 Thread Johan Vos
Hide accumCell when the cell is released. Fix for JDK-8265669 - Commit messages: - Hide accumCell when the cell is released. Changes: https://git.openjdk.java.net/jfx/pull/474/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=474=00 Issue:

Re: AArch64 naming conventions

2021-04-20 Thread Johan Vos
ot; field in JBS (the alternative > there being 'arm'). > I'd find it easier if it was consistent across all these places. > > -phil > > On 4/19/21 1:06 PM, Johan Vos wrote: > > Recently, we introduced the option (or are introducing the options) to > > build OpenJFX

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-20 Thread Johan Vos
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH

AArch64 naming conventions

2021-04-19 Thread Johan Vos
Recently, we introduced the option (or are introducing the options) to build OpenJFX for 64-bit ARM CPU's on Mac, Windows and Linux. However, those 3 platforms use different approaches to deal with this arch-specific options. Since the PR's for windows and linux are currently still open, it might

RFR: 8265469: Allow to build media and webkit for Linux-AArch64

2021-04-19 Thread Johan Vos
Changes that allow to build linux configuration on Linux AArch64 This PR introduces an `IS_AARCH64` parameter in build.gradle. This PR already contains the change from PR #465 so if this one gets integrated, that change needs to removed from this PR. - Commit messages: - Changes

Re: RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader [v3]

2021-04-19 Thread Johan Vos
On Thu, 15 Apr 2021 16:43:08 GMT, Matthias Bläsing wrote: >> The functions from FileSystemJava are called from different threads the >> root problem manifests because the JNI FindClass function behaves >> differently when called from a context that is the ancestor of a java >> frame compared to

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-18 Thread Johan Vos
On Fri, 26 Feb 2021 16:47:55 GMT, John Neffenger wrote: > > What is the expected behavior? > > I think that's why I never raised the issue. I let the bug train me to avoid > it! For better or for worse, I think the only answer to your question is > whatever Android and iOS do. I agree it's

Re: RFR: 8259356: MediaPlayer's seek freezes video

2021-04-17 Thread Johan Vos
On Sat, 17 Apr 2021 01:39:17 GMT, Alexander Matveev wrote: > This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS > streams (unfortunately I was not able to find repro case and more details on > why it was added) in gstappsink.c line 659-678 to store current caps

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-17 Thread Johan Vos
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH

Integrated: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-16 Thread Johan Vos
On Tue, 9 Feb 2021 12:21:28 GMT, Johan Vos wrote: > This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in re

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v4]

2021-04-16 Thread Johan Vos
if we want to > estimate the total size, we need to do some additional calculations. In this > PR, I try to balance between consistent behavior and performance. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Process reviewer

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v3]

2021-04-16 Thread Johan Vos
On Fri, 16 Apr 2021 10:03:07 GMT, Ajit Ghaisas wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/test/java/test/javafx/scene/con

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v3]

2021-04-16 Thread Johan Vos
if we want to > estimate the total size, we need to do some additional calculations. In this > PR, I try to balance between consistent behavior and performance. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Process reviewer commen

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Johan Vos
On Thu, 15 Apr 2021 07:53:50 GMT, Ajit Ghaisas wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/main/java/javafx/scene/control

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Johan Vos
On Mon, 12 Apr 2021 13:10:44 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/main/java/javafx/scene/control

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-16 Thread Johan Vos
On Thu, 15 Apr 2021 07:22:29 GMT, Ajit Ghaisas wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/test/java/test/javafx/scene/con

Re: RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader [v2]

2021-04-15 Thread Johan Vos
On Mon, 12 Apr 2021 16:17:37 GMT, Kevin Rushforth wrote: > @johanvos Do you have a case where it is actually failing as a result of a > thread not being attached? No, I don't have a usecase for that. Hence, as long as there is no trace that can lead to this, I agree this (calling the

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]

2021-04-15 Thread Johan Vos
On Thu, 15 Apr 2021 13:56:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH

Re: RFR: 8265031: Change default macOS min version for x86_64 to 10.12 and aarch64 to 11.0 [v2]

2021-04-14 Thread Johan Vos
On Wed, 14 Apr 2021 12:40:29 GMT, Kevin Rushforth wrote: >> As noted in the JBS bug, the minimum macOS version on which JavaFX will run >> is currently set to 10.10 in `mac.gradle`. macOS 10.10 is many years out of >> support, so we should update this minimum. Further, macOS / aarch64 (aka >>

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Johan Vos
On Wed, 14 Apr 2021 14:56:16 GMT, Kevin Rushforth wrote: >> buildSrc/win.gradle line 46: >> >>> 44: def HOST_ARCH = getWinArch(ext.OS_ARCH) >>> 45: def TARGET_ARCH = getWinArch(ext.TARGET_ARCH) >>> 46: def IS_CROSS = HOST_ARCH != TARGET_ARCH >> >> can we move this to build.gradle? >> With the

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v2]

2021-04-14 Thread Johan Vos
On Tue, 13 Apr 2021 08:41:12 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH

Re: RFR: 8265031: Change default macOS min version for x86_64 to 10.12 and aarch64 to 11.0

2021-04-13 Thread Johan Vos
On Mon, 12 Apr 2021 20:30:55 GMT, Kevin Rushforth wrote: > As noted in the JBS bug, the minimum macOS version on which JavaFX will run > is currently set to 10.10 in `mac.gradle`. macOS 10.10 is many years out of > support, so we should update this minimum. Further, macOS / aarch64 (aka >

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:12:54 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/main/java/javafx/scene/control

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]

2021-04-12 Thread Johan Vos
if we want to > estimate the total size, we need to do some additional calculations. In this > PR, I try to balance between consistent behavior and performance. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Process reviewer commen

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Tue, 9 Feb 2021 12:21:28 GMT, Johan Vos wrote: > This PR introduces a refactory for VirtualFlow, fixing a number of issues > reported about inconsistent scrolling speed (see > https://bugs.openjdk.java.net/browse/JDK-8089589) > The problem mentioned in the JBS issue (and in re

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:32:28 GMT, Kevin Rushforth wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:29:39 GMT, Kevin Rushforth wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in

Re: RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.

2021-04-12 Thread Johan Vos
On Fri, 9 Apr 2021 22:27:47 GMT, Kevin Rushforth wrote: >> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in

Re: RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader [v2]

2021-04-12 Thread Johan Vos
On Sat, 10 Apr 2021 15:01:08 GMT, Kevin Rushforth wrote: >> I'm currently rerunning tests and preparing and update - further analysis >> showed, that thread attachment is handled in >> `WebCore::StorageThread::threadEntryPoint()`: >> >>

Re: RFR: 8264928: Update to Xcode 12.4

2021-04-10 Thread Johan Vos
On Thu, 8 Apr 2021 17:21:43 GMT, Kevin Rushforth wrote: > This updates the compiler used to build JavaFX on macOS to Xcode 12.4 (which > includes the MacOSX11.1 sdk), which matches the compiler that will be used to > build JDK 17, once openjdk/jdk#3388 is integrated. > > As noted in the bug

Re: RFR: 8264990: Fix segfault when accessing local storage in webview

2021-04-09 Thread Johan Vos
On Fri, 9 Apr 2021 16:02:36 GMT, Kevin Rushforth wrote: >> That's how I ran it, too. I did it from a clean repo. This was on Windows, >> but shouldn't matter. > > I just tried it on Linux and get the same failure: > > Caused by: java.lang.NullPointerException: Cannot invoke >

Re: RFR: 8264990: Fix segfault when accessing local storage in webview

2021-04-09 Thread Johan Vos
On Thu, 8 Apr 2021 12:30:38 GMT, Matthias Bläsing wrote: >> The functions from FileSystemJava are called from different threads the >> root problem manifests because the JNI FindClass function behaves >> differently when called from a context that is the ancestor of a java >> frame compared to

Re: RFR: 8260245: Update ICU4C to version 68.2 [v2]

2021-04-08 Thread Johan Vos
On Thu, 8 Apr 2021 13:01:27 GMT, Arun Joseph wrote: >> We currently use ICU4C version 64.2. We should update to the latest stable >> version 68.2. >> http://site.icu-project.org/home > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8264886: WebKit native to Java invocations on wrong thread

2021-04-08 Thread Johan Vos
On Thu, 8 Apr 2021 12:27:02 GMT, Matthias Bläsing wrote: >> Fix for JDK-8264886 > > Please have a look at https://github.com/openjdk/jfx/pull/458 - the solution > there is identical, but also fixes fetching the FileSystem class. > Please have a look at #458 - the solution there is identical,

RFR: 8264886: WebKit native to Java invocations on wrong thread

2021-04-08 Thread Johan Vos
Fix for JDK-8264886 - Commit messages: - Use env->AttachCurrentThread before making invocations from native to Java Changes: https://git.openjdk.java.net/jfx/pull/459/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=459=00 Issue:

Re: RFR: 8260245: Update ICU4C to version 68.2

2021-04-07 Thread Johan Vos
On Mon, 5 Apr 2021 18:14:36 GMT, Arun Joseph wrote: > We currently use ICU4C version 64.2. We should update to the latest stable > version 68.2. > http://site.icu-project.org/home build.gradle line 1914: > 1912: } > 1913: patternLayout { > 1914:

Re: RFR: 8217955: Problems with touch input and JavaFX 11

2021-04-07 Thread Johan Vos
On Mon, 5 Apr 2021 18:59:52 GMT, Jose Pereda wrote: > This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to > prevent touch events from being used instead of regular mouse events on Linux > platforms. Note that the touch events will be delivered as mouse > pressed/dragged

Re: RFR: 8217955: Problems with touch input and JavaFX 11

2021-04-07 Thread Johan Vos
On Tue, 6 Apr 2021 23:32:53 GMT, Thiago Milczarek Sayao wrote: > If anyone would implement touch events, the change would need to be rolled > back? Yes, *if* touch events would be implemented properly at a native level, this change will need to be rolled back. This can be a follow-up issue,

Re: RFR: 8262366: Update glib to version 2.66.7 [v2]

2021-04-03 Thread Johan Vos
On Thu, 1 Apr 2021 23:17:58 GMT, Alexander Matveev wrote: >> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 >> - One bug was discovered in updated GStreamer which was causing deadlock or >> infinite loop during seek on macOS. See gstsystemclock.c for changes between >>

Re: RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Johan Vos
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote: > WebKit crashes during JavaScriptCore initialization code for Apple Silicon. The other required changes required to build for M1 can easily be passed as build parameters using gradlew -P Hence, this change contains all that is needed to be

Re: RFR: 8259555: Webkit crashes on Apple Silicon

2021-04-02 Thread Johan Vos
On Fri, 2 Apr 2021 15:37:38 GMT, Arun Joseph wrote: > WebKit crashes during JavaScriptCore initialization code for Apple Silicon. This works, as long as MACOSX_MIN_VERSION is set to 11. I guess we don't want to commit that in the build.gradle, as we only require that for a build on Apple

Re: RFR: 8262366: Update glib to version 2.66.7

2021-04-01 Thread Johan Vos
On Thu, 1 Apr 2021 01:36:01 GMT, Alexander Matveev wrote: >> I get a compilation error on Linux: >> >> ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c: >> In function 'gst_audio_buffer_map': >>

Integrated: 8264536: Building OpenJFX on Apple AARCH64 not possible

2021-03-31 Thread Johan Vos
On Wed, 31 Mar 2021 17:54:49 GMT, Johan Vos wrote: > don't bail when building on Apple M1 systems > Fix for JDK-8264536 This pull request has now been integrated. Changeset: eec2f394 Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/eec2f394 Stats: 1 line in

RFR: 8264536: Building OpenJFX on Apple AARCH64 not possible

2021-03-31 Thread Johan Vos
don't bail when building on Apple M1 systems Fix for JDK-8264536 - Commit messages: - don't bail when building on Apple M1 systems Changes: https://git.openjdk.java.net/jfx/pull/451/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=451=00 Issue:

Re: RFR: 8264162: PickResult.toString() is missing the closing square bracket [v2]

2021-03-31 Thread Johan Vos
On Thu, 25 Mar 2021 22:08:36 GMT, Kevin Rushforth wrote: >> Simple fix to add a missing closing bracket to `PickResult::toString`. This >> includes a unit test that fails without the fix and passes with the fix. > > Kevin Rushforth has updated the pull request incrementally with one >

Re: RFR: 8264501: UIWebView for iOS is deprecated [v2]

2021-03-31 Thread Johan Vos
On Wed, 31 Mar 2021 12:26:17 GMT, Jose Pereda wrote: >> This PR replaces the deprecated iOS native view for web (UIWebView) with >> WKWebView. >> >> While most of the native API can be easily replaced from one to the other, >> there are some changes that affect the scripts execution, and

issues on javafxports/openjdk-jfx

2021-03-28 Thread Johan Vos
I'm creating a separate thread for this, as it might get lost in other threads. We see that issues are still created in the old github.com/javafxports/openjdk-jfx project. The README of that project clearly mentions that repository is obsolete, but the issue tracker is still open. It is not hard

Re: RFR: 8264162: PickResult.toString() is missing the closing square bracket

2021-03-25 Thread Johan Vos
On Thu, 25 Mar 2021 12:29:38 GMT, Kevin Rushforth wrote: > Simple fix to add a missing closing bracket to `PickResult::toString`. This > includes a unit test that fails without the fix and passes with the fix. Good catch. Test fails before and succeeds after the patch. - Marked

Integrated: 8211362: Restrict export of libjpeg symbols from libjavafx_iio.so

2021-03-25 Thread Johan Vos
On Thu, 25 Mar 2021 12:02:25 GMT, Johan Vos wrote: > Fix for JDK-8211362 > > Compile javafx-iio native files with -f-visibiliy=hidden in order > not to export the non-JNI symbols. > Although this issue was about libjavafx_iio.so only (and not about > libjavafx_iio.a), thi

RFR: 8211362: Restrict export of libjpeg symbols from libjavafx_iio.so

2021-03-25 Thread Johan Vos
Fix for JDK-8211362 Compile javafx-iio native files with -f-visibiliy=hidden in order not to export the non-JNI symbols. Although this issue was about libjavafx_iio.so only (and not about libjavafx_iio.a), this PR allows fixing the static build as well. For static builds, we also use ld -r to

software cursor on hardware rendering

2021-03-24 Thread Johan Vos
Hi, I'm currently adding a software-cursor on top of hardware rendering (in case no hardware or OS-provided cursor is available). On all desktop platforms (and on Monocle with X11), we use the cursor provided by the window manager. In case there is no window manager, Monocle can use a software

Re: Not really a nice comment but a real issue?

2021-03-23 Thread Johan Vos
Hi John, all, Clearly, there are advantages and disadvantages to the Oracle Web form. It's not a black/white situation. We need to find a solution that combines the advantages of being accessible as well as not creating false expectations. I really like the JBS system, it is very powerful and

Integrated: 8263778: Fix monocle JNI signatures for instance methods

2021-03-20 Thread Johan Vos
On Sat, 20 Mar 2021 11:53:21 GMT, Johan Vos wrote: > Fix signatures (jclass/jobject), add UNUSED when unused > Fix for JDK-8263778 > > The monocle/egl native code now includes the javac generated header file > UNUSED() directives are used when a parameter is not used > jobje

RFR: 8263778: Fix monocle JNI signatures for instance methods

2021-03-20 Thread Johan Vos
Fix signatures (jclass/jobject), add UNUSED when unused Fix for JDK-8263778 The monocle/egl native code now includes the javac generated header file UNUSED() directives are used when a parameter is not used jobject/jclass are used when expected. - Commit messages: - Fix signatures

Re: RFR: 8263759: Update boot JDK to 15.0.2

2021-03-18 Thread Johan Vos
On Thu, 18 Mar 2021 12:17:58 GMT, Kevin Rushforth wrote: > Simple fix to updated the boot JDK version to 15.0.2. Tested locally, and > with the GitHub Actions build, both of which passed. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/431

Re: RFR: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-18 Thread Johan Vos
On Wed, 17 Mar 2021 23:05:27 GMT, Kevin Rushforth wrote: >> Fix for JDK-8092439 and JDK-8092064 >> Monocle currently hard-codes a single Screen, and the >> `staticScreen_getScreens()` method will never return more than 1 Screen. >> >> This PR introduces the possibility to deal with multiple

Integrated: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-18 Thread Johan Vos
On Tue, 16 Mar 2021 14:24:19 GMT, Johan Vos wrote: > Fix for JDK-8092439 and JDK-8092064 > Monocle currently hard-codes a single Screen, and the > `staticScreen_getScreens()` method will never return more than 1 Screen. > > This PR introduces the possibility to deal with m

Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-17 Thread Johan Vos
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last

Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-16 Thread Johan Vos
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last

RFR: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-16 Thread Johan Vos
Fix for JDK-8092439 and JDK-8092064 Monocle currently hard-codes a single Screen, and the `staticScreen_getScreens()` method will never return more than 1 Screen. This PR introduces the possibility to deal with multiple screens, which is not uncommon on embedded systems. By default, the

Re: RFR: 8257895: Allow building of JavaFX media libs for Apple Silicon [v2]

2021-03-13 Thread Johan Vos
On Thu, 11 Mar 2021 06:42:29 GMT, Alexander Matveev wrote: >> - Added support to compile media on arm. >> - libffi is based on 3.3. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8257895: Allow building of JavaFX

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-10 Thread Johan Vos
On Tue, 9 Mar 2021 18:51:22 GMT, Jose Pereda wrote: >> This PR changes the parameter names to accommodate class calculations >> related to screen event coordinates (AbsX, AbsY). >> >> As >>

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-10 Thread Johan Vos
On Tue, 9 Mar 2021 18:48:49 GMT, Jose Pereda wrote: >> Yes, that makes sense. >> >> We could refactor the three `sendScrollXXXEvent` methods to something like: >> >> sendScrollXXXEvent(double xAbs, double yAbs, int touchCount) >> or to: >> >> sendScrollXXXEvent(double x, double y, double

Re: CFV: New OpenJFX Committer: John Neffenger

2021-03-10 Thread Johan Vos
Vote: yes On Wed, Mar 10, 2021 at 12:58 PM Kevin Rushforth wrote: > I hereby nominate John Neffenger [1] to OpenJFX Committer. > > John is an OpenJFX community member, who has contributed 10 commits [2] > to OpenJFX. > > Votes are due by March 24, 2021 at 12:00 UTC. > > Only current OpenJFX

  1   2   3   4   5   6   7   >