Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v2]

On Tue, 31 May 2022 22:25:23 GMT, Kevin Rushforth wrote: >> Hi, >> Time is going short before openjfx 19... >> >> 2 options: >> - keep dpqs for corner cases and keep my coding life simple >> - disable or remove dpqs code in marlinFX for openjfx, so my branches will >> diverge... >> >> Any advi

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 &

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 &

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 &

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

On Fri, 7 Jan 2022 23:35:37 GMT, Kevin Rushforth wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

On Fri, 7 Jan 2022 23:39:05 GMT, Laurent Bourgès wrote: > Would a targeted test for the failing case from the bug report make sense? I added the HugePolygonClipTest that fails on jdk11, 17 ... but now passes. - PR: https://git.openjdk.java.net/jfx/pull/674

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

cial Thanks to Vladimir Yaroslavskiy that provided me up-to-date DPQS > 19.05 with many variants, improving almost-sorted datasets. We are > collaborating to provide a complete Sort framework (15 algorithms, many > various datasets, JMH benchmarks) publicly on github: > see https://github.co

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

On Fri, 7 Jan 2022 23:35:37 GMT, Kevin Rushforth wrote: > Would a targeted test for the failing case from the bug report make sense? I agree the rule is to have a test, I will write a basic test derived from user's case asap. - PR: https://git.openjdk.java.net/jfx/pull/674

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - removed simple-precision (float) variant > - improved Stroker to handle

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) I will add changelog asap - PR: https://git.openjdk.java.net/jfx/pull/674

RFR: 8274066: Polygon filled outside its area when very large coordinates are used

Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper fixes to handle huge coords) - Commit messages: - fixed jcheck warning (tab) - Merge branch 'openjdk:master' into marlinFX-0.9.4.5 - minor changes (syntax, warnings) + merge with marlin 0.9.4.5 (jdk) - fixe

Integrated: JDK-8259718 Remove the Marlin rasterizer (single-precision)

On Sun, 17 Jan 2021 15:49:33 GMT, Laurent Bourgès wrote: > Changes: > - Removed single-precision Marlin renderer > - class name refactoring > - fix prism > - copyright year This pull request has now been integrated. Changeset: c1b14de9 Author:Laurent Bourgès U

Re: RFR: JDK-8259718 Remove the Marlin rasterizer (single-precision) [v3]

> Changes: > - Removed single-precision Marlin renderer > - class name refactoring > - fix prism > - copyright year Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: updated Version - Changes:

Re: RFR: JDK-8259718 Remove the Marlin rasterizer (single-precision)

On Sun, 17 Jan 2021 15:49:33 GMT, Laurent Bourgès wrote: > Changes: > - Removed single-precision Marlin renderer > - class name refactoring > - fix prism > - copyright year How to run tests again ? I tried pull commands but it does nothing. - PR: https://git.openj

Re: RFR: JDK-8259718 Remove the Marlin rasterizer (single-precision) [v2]

> Changes: > - Removed single-precision Marlin renderer > - class name refactoring > - fix prism > - copyright year Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed ClipShapeTest (marlin detection) ---

RFR: JDK-8259718 Remove the Marlin rasterizer (single-precision)

Changes: - Removed single-precision Marlin renderer - class name refactoring - fix prism - copyright year - Commit messages: - Removed single-precision Marlin renderer + class name refactoring + fix prism + copyright year Changes: https://git.openjdk.java.net/jfx/pull/379/files W

Re: RFR: 8196079: Remove obsolete Pisces rasterizer

On Sat, 18 Jul 2020 14:57:08 GMT, Kevin Rushforth wrote: > This removes the obsolete OpenPiscesRasterizer (Java-based) and > NativePiscesRasterizer implementations. The Marlin > rasterizer was added in FX 9 and was made the default in FX 10. Marlin both > outperforms Pisces and is more robust.

Re: RFR: 8196079: Remove obsolete Pisces rasterizer

On Sat, 18 Jul 2020 22:07:59 GMT, Kevin Rushforth wrote: >> That's the case, michael. >> In SWContext, the Marlin renderer is called to rasterize any shape. >> >> See >> https://github.com/openjdk/jfx/pull/268/files#diff-28f93b00dc9cba7197f0a6c2fef022ed > > I think you are conflating the raster

Re: RFR: 8196079: Remove obsolete Pisces rasterizer

On Sat, 18 Jul 2020 16:11:38 GMT, Phil Race wrote: >> This removes the obsolete OpenPiscesRasterizer (Java-based) and >> NativePiscesRasterizer implementations. The Marlin >> rasterizer was added in FX 9 and was made the default in FX 10. Marlin both >> outperforms Pisces and is more robust. >>

Re: RFR: 8189092: ArrayIndexOutOfBoundsException on Linux in getCachedGlyph

On Fri, 25 Oct 2019 20:18:48 GMT, Phil Race wrote: > I have added an evaluation in https://bugs.openjdk.java.net/browse/JDK-8207839 > Please read that for more detail, but basically we are not properly > preventing or > handling cases where fontconfig causes us to overflow the byte storage used

RFR: 8226789: Path rendered incorrectly when it goes outside the clipping region

Hi, Please review this bug fix in Marlin renderer's path clipper :https://bugs.openjdk.java.net/browse/JDK-8226789https://github.com/javafxports/openjdk-jfx/pull/534 PS: I will propose another fix soon to JDK14 / Marlin renderer (java2d) Laurent

Re: Javafx - graphics

Hi, This is not stack overflow, neither a support list ! OpenJFX-dev is dedicated to OpenJFX dev, ie enhancing the JavaFX implementation. Concerning Vector Graphics, I made MarlinFX, the 2d shape rasterizer for openjfx, ie Shape to pixel coverage converter integrated in Prism. Laurent Le sam. 8

Re: Text rendering on Mojave (macOS)

Hi, It remembers me that recently (within 2 months), somebody proposed 2 patchs to enable freetype LCDFilter for awt & javafx. Both patches are integrated in jdk12 & jfx 12 ... probably a backport to jdk11u & jfx11u is in progress... Please test latest version, first. My 2 cents, Laurent Le me

Re: JavaFX 11.0.1-ea+1 release

: negative > scaling factors or small scaling factors > > -- Kevin > > > On 11/2/2018 3:52 AM, Laurent Bourgès wrote: > > Hi, > > > > Could you publish the list of included bug fixed (JBS query) ? > > > > Cheers, > > Laurent > > > >

Re: JavaFX 11.0.1-ea+1 release

Hi, Could you publish the list of included bug fixed (JBS query) ? Cheers, Laurent Le ven. 2 nov. 2018 à 10:00, Johan Vos a écrit : > Hi, > > We are about to release JavaFX 11.0.1, containing the fixes that made it > into the 11-dev repository. > An early-access build for this is available as

Re: Review request backport 8210386

Thank you, Laurent Le lun. 29 oct. 2018 à 19:35, Kevin Rushforth a écrit : > Looks good. Approved for pushing to 11-dev. > > -- Kevin > > On 10/29/2018 11:27 AM, Johan Vos wrote: > > new webrev including test: > > http://cr.openjdk.java.net/~jvos/8210386/webrev.01/ > >

[12] RFR: JDK-8210386: Clipping problems with complex affine transforms

Please review the following bug fix in the MarlinFX renderer for JavaFX 12: https://bugs.openjdk.java.net/browse/JDK-8210386 https://github.com/javafxports/openjdk-jfx/pull/206 PS: What is the process to backport this bug fix to OpenJFX 11 updates ? This patch is small and can be applied directly

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

ot really satisfied by adding such noise in build.gradle, >>> >> but it can be improved later ... >>> > >>> > Agreed. This can be a follow-on issue. I'll finish my review shortly. >>> > >>> > -- Kevin >>> > >>> >

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

27;ll finish my review shortly. > > > > -- Kevin > > > > > > On 7/3/2018 8:45 AM, Laurent Bourgès wrote: > >> Kevin, > >> > >> > I added the system property "ClipShapeTest.numTests" but it > >> requires a > >>

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

Kevin, > I added the system property "ClipShapeTest.numTests" but it requires a > build.gradle change to pass the parameter: > > Yes, something like this is what I had in mind. As long as we don't add > too many of these, it is OK with me. Note that as coded, the build will > fail if you don't def

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

of the >>>> concrete Marlin setup as quality thresholds are sensitive to such values. >>>> >>> >>> As a best practice, tests should generally be run using the same >>> settings as are used in production. Other than to verify how it behaves >>>

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

> recommend running functional tests with this set), although since you don't > do any animation, it probably doesn't matter. > > 227 System.setProperty("javafx.animation.fullspeed", "true"); // > full speed > I will remove

[11] JDK-8204621: Upgrade MarlinFX to 0.9.2

Hi, Please review this large patch to upgrade MarlinFX to 0.9.2 in OpenJFX11: JBS: https://bugs.openjdk.java.net/browse/JDK-8198885 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-092.0/ PR: https://github.com/javafxports/openjdk-jfx/pull/96 (CI OK) This patch is almost identical t

[11] RFR JDK-8202743: Dashed Stroke randomly painted incorrectly, may freeze application

Please review this simple fix for MarlinFX Dasher: JBS: https://bugs.openjdk.java.net/browse/JDK-8202743 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8202743.0/ Github Pull request: https://github.com/javafxports/openjdk-jfx/pull/87 Notes: - (D)Dasher changes corresponds to

Re: OpenJFX GitHub mirror

Hi, As such github references point to either issue or PR, I recommend using the term 'github-link'. Laurent Le jeu. 29 mars 2018 à 03:40, Kevin Rushforth a écrit : > I think this would be fine. We would want something that didn't conflict > with anything else and wasn't confusing. Possible ch

[11] Review request: JDK-8196617: FX print tests fail with NPE in some environments

Kevin, Please review this webrev that fixes the NPE in getMediaName(): JBS: https://bugs.openjdk.java.net/browse/JDK-8196617 webrev: http://cr.openjdk.java.net/~lbourges/fx/fx-8196617.0/ It was tested OK on the appveyor CI that failed before the patch. Thanks, Laurent

Re: Test failures running on OS X

> junit.framework.AssertionFailedError: expected:<2.5> but was:<2.0> >> at junit.framework.Assert.fail(Assert.java:47) >> at junit.framework.Assert.failNotEquals(Assert.java:283) >> at junit.framework.Assert.assertEquals(Assert.java:64) >> at junit.framework.Assert.assertEquals(Assert.java:71) >> at >> test.javafx.scene.control.SpinnerTest.test_jdk_8150946_testC >> ommit_valid(SpinnerTest.java:1308) >> >> This is with gradle 46, 9.0.4 on a german locale OS X... >> >> Any ideas what to look for? >> >> Thanks >> >> Sven >> >> > -- -- Laurent Bourgès

Re: Test failures running on OS X

Hi, I confirm I have the same problem on my FR Locale. I added -Duser.language=en to the gradle command line and it worked. Alternatively set LANG=US in your env. It should be fixed in build.gradle... Cheers, Laurent Le 10 mars 2018 11:07 PM, "Sven Reimers" a écrit : > Hi, > > getting back i

[11] Review request: JDK-8189689: JavaFX build fails with gcc 6

Kevin, Please review the following webrev that fixes compilation with gcc 6, that was initiated on github by Emmanuel Bourg (@ebourg) in PR #11 and #16 https://bugs.openjdk.java.net/browse/JDK-8189689 http://cr.openjdk.java.net/~lbourges/fx/fx-8189689.0/ Thanks, Laurent

Re: Repositories, AdoptOpenJDK and github

Johan, I am following the long discussion and I mostly agree what was said. Maybe it is time to start working on github on few minor / trivial bugs... to test all the new process. I propose to extract few JBS bugs (small) with high ROI (agile /scrum approach) and create shadow copies into github

Re: More community participation in JavaFX

Hi folks, Please respect the 2 threads with different scopes: - this one on how to simplify external contributions (infrastructure, review policies...) - the other one on javafx features... Please stay in the scope & being constructive... I personally improved the prism shape rasterizer (marlinfx

Re: More community participation in JavaFX

Hi Chris, I'm more than happy to keep the community JavaFX build server at chriswhocodes.com running and host JDK 8/9/10/n + FX builds there. At the moment it's mostly used by the Raspberry Pi community to grab JavaFX overlays for JDK8 on ARM. I can also build and host OSX and Windows builds t

Re: Building OpenJFX.

Phil, I am using ubuntu 17.4 (soon will upgrade to 17.10) and gcc 6 is the default compiler. I submitted a jfx bug as I had to fix some c code (wait call) and ignore warnings (as error) to build OpenJFX / JDK 10 on gcc6. I may help fixing some warnings but I am not an expert of javafx native code

Re: Innovation again (was Re: Text classes)

Dear all, Chris mail motivated me to answer too. *** For *your* situation, what is JavaFX, how do you want it to evolve and what does it mean to you? *** I am developping for 10 years scientific desktop apps with Java Swing (+ Java Web Start). As our users are mostly using linux & macOS, we on

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

Hi Kevin, Here is the updated patch providing MarlinFX-0.8.2 to OpenJFX-10 that provides an efficient path clipper fixing the bug JDK-8184429: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-082-8184429.0/ It is up-to-date with jfx-dev / jdk forrest (10) and recent changes from the Marlin

Re: Build issues on Ubuntu 16.04, 17.10 and 18.04-daily inside Docker

fxpackager/src/main/native/library/common/Java.cpp:237:46: > note: in C++11 destructors default to noexcept > FAILED > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':fxpackager:compileLinuxLibrary'. > > Could not call NativeCompileTask.compile() on task > ':fxpackager:compileLinuxLibrary' > > Details and complete build logs can be found at > https://gitlab.com/krichter/openjfx-8u-dev-rt/pipelines/14781176. The > build script `.gitlab-ci.yml` contains the commands used to build. > > -Kalle > > -- -- Laurent Bourgès

Re: Font metrics in JavaFX Canvas

Hi David, If I can help (dev / test / build / patch), I would love doing it on this RFE... on my spare time as usual (best effort). However I have no idea how text metrics are implemented in JavaFX. Could anyone give us directions or draft ideas to do the job ourselves ? Should we start a github

Re: PLEASE READ: OpenJFX developer repos + JDK 10 RDP1 deadlines

Kevin, To be sure, does it mean OpenJFX 10 changes are due to dec 14th ie for JDK10 RDP1 ? I would like to provide MarlinFX 0.8.2 for jfx10 but the remaining time is short for the web review to happen... and the RFR Marlin 0.8.2 patch for Java2d is submitted but no comment yet. Should I submit a

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

ee can be open sourced .. that I can run but you can't .. I'll at least run the automated ones. I wouldn't call them anything very focused on testing rasterization but I can at least check off that concern .. And yes, I'll make time to review it. -phil. On 11/08/2017 01:55 PM, La

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

; as the code is quite simple to read but the new CG algorithms to ignore / discard useless path elements are cool but not obvious. Please tell me if you have time and if you prefer a combined (JDK / JFX) webrev or start with 2D or JFX. Cheers, Laurent 2017-09-07 8:52 GMT+02:00 Laurent Bourg

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

he end of the method declaration (same > pattern appears in a few other files) > > > 2. Can you add a blank line before the Path2DWrapper class declaration? > > Other than that, as long as you address Phil's concerns it is OK to go in. > > Thanks. > > -- Kevin > &

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

Just a gentle reminder... Kevin, could you have a look ? I have other patches coming soon... Cheers, Laurent Le 27 oct. 2017 8:02 PM, "Laurent Bourgès" a écrit : > Hi Phil, > Thanks for your comments. > > Le 27 oct. 2017 18:28, "Phil Race" a écrit : > >

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

erizerSpec == RasterizerType.FloatMarlin) {+ return MarlinRasterizer.createCenteredStrokedShape(s, stroke);+}+// JavaPisces fallback:+return createCenteredStrokedShapeOpenPisces(s, stroke);+}+ Laurent -phil. On 10/25/2017 02:11 PM, Laurent Bourgès wrote: Please

[10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

Please review this simple patch that moves the BasicStroke.createCenteredStrokedShape() implementation into ShapeUtil in order to use Marlin instead of OpenPisces: JBS: https://bugs.openjdk.java.net/browse/JDK-8188062 Webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8188062.0/ Chang

Re: Build JFX-10 on linux gcc 6

Hi Kevin, As I deleted (by mistake) my former OpenJFX10, I was a bit lost ! 2017-10-19 20:40 UTC+02:00, Kevin Rushforth : > Hi Laurent, > > We don't have an easy way to suppress -Werror (no equivalent of JDK's > --disable-warnings-as-errors configure option). > > For the short term, you can edit

Build JFX-10 on linux gcc 6

Hi, I cloned a fresh openjfx 10 and I got gradle build error with gcc 6 on my ubuntu 17.4 as gcc warnings are considered as errors. Sorry I forgot how to fix the gradle setting to avoid -Werror. What is the trick ? Laurent

Re: JavaOne slides about Marlin/FX renderer

Hi, Please join me in my efforts improving either Java2D or JavaFX (performance, quality, better 3D support in JFX) by contributing to the Marlin project or sponsoring me working for the java community (OpenJDK & OpenJFX). Here are important clarifications, that represents my point of view (see

JavaOne slides about Marlin/FX renderer

Hi, Here are my final JavaOne slides about the Marlin & MarlinFX renderers: https://github.com/bourgesl/bourgesl.github.io/raw/master/ja vaone2017/slides/javaone-marlin-talk.pdf You will also get links to my github repositories... Please join me in my efforts improving either Java2D or JavaFX (p

Client group consolidation ?

Hi, I wonder what is the current status of the Client consolidation gathering former openjdk groups 2d, awt, sound... and maybe openjfx ? I remember that Phil Race proposed such a big change but as these groups are fragmented with only few active members, I think it is worth to merge them to obta

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

7 16:23, "Kevin Rushforth" a écrit : > Hi Laurent, > > Some combination of Phil, Sergey, and I will take a look at this when we > can. Perhaps there might be others on these two lists who could lend a > helping hand? > > -- Kevin > > > Laurent Bourgès

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

erer even more ? Thanks, Laurent Le 5 sept. 2017 22:41, "Laurent Bourgès" a écrit : > Hi Jim, > > I made good progress on my PathClipFilter that works now perfectly with > many test maps for the NZ rule (EO has artefacts if I enable the filter in > that case). > >

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

Hi Jim, I made good progress on my PathClipFilter that works now perfectly with many test maps for the NZ rule (EO has artefacts if I enable the filter in that case). Here is the updated code below to illustrate the approach: - use a new IndexStack in (D)Helpers to store only corner indexes (0/1

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

in reverse order... clip off: ~ 145ms clip on: ~ 106ms TODO: handle corner points & turns arround / reverse the clip Cheers, Laurent 2017-09-01 22:09 GMT+02:00 Laurent Bourgès : > Dear Jim, > > I am not so good at explaining my early solution for NZ rule in english: > - it mimi

Fwd: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

eces on the floor...? > I already tried to explain an interesting case: closed subpaths on the left or right sides are bringing lots of edges into the Renderer bag that cost a lot due to the scanline processing (crossing inc, sort, spans ...). I prefer coding an external simplifier compatibl

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

Hi Jim, I am answering your first message: Area is overkill for this as it tries to find exact intersection points of arbitrary geometry. You simply need something that will trace accurately around the outside of a clip to get from an exit point back to an entry point. That is a much simpler op

Re: RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

thresholds) but did not try curve subdivision to guarantee the special point accuracy (cups...) Hope you will have time soon to look at the webrev, your feedback may help a lot. Cheers, Laurent Le 29 août 2017 2:58 AM, "Jim Graham" a écrit : Hi Laurent, On 8/28/17 2:09 PM, Laurent Bou

Re: RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

end you an updated MarlinFX patch (when you need it). Cheers, Laurent > I'm still looking through the management of the closed path detection > coordinates, but I thought I'd get at least these questions out first > before the weekend... > > ..

RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

pBench test with a small clip and several affine transforms: it does not produce any artefact (0 pixel difference between clip=true/false) PS: I also improved the accuracy of Renderer's AFD by using the kaham compensated-sum approach (later patch) Cheers, Laurent Bourgès

[10] RFR 8180449: Upgrade the Marlin renderer in JavaFX

Please review this MarlinFX upgrade, following recent changes in Marlin2D to synchronize Marlin 0.7.5 with OpenJDK & OpenJDK: JBS: https://bugs.openjdk.java.net/browse/JDK-8180449 (last) webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.2/ Changes: - Renderer (4 variants): use sh

[10] RFR

Please review this MarlinFX upgrade, following recent changes in Marlin2D to synchronize Marlin 0.7.5 with OpenJDK & OpenJDK: JBS: https://bugs.openjdk.java.net/browse/JDK-8180449 (last) webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.2/ Changes: - Renderer (4 variants): use sh

Re: MarlinFX upgrade 0.7.5

to JavaFX, I wonder if it is worth to backport this small difference in Marlin2D where there will be no gain. Laurent 2017-05-16 23:11 GMT+02:00 Laurent Bourgès : > Hi Jim, > > I didn't notice anything functionally wrong with reviewing the webrev. >> I'm going to do som

Re: MarlinFX upgrade 0.7.5

Hi Jim, I didn't notice anything functionally wrong with reviewing the webrev. I'm > going to do some basic testing on it now while you create a JBS bug for it > and submit for a formal review. But I did notice some discrepancies by > diffing the sources against each other which it would be nice

Re: MarlinFX upgrade 0.7.5

affected by the review comments I made there? Did you want to > hold both until they both are ready to go in and then push them at the same > time (to keep them in sync)? > > Minimally, it is time to file a bug against FX for this... > > ...jim > >

Re: MarlinFX upgrade 0.7.5

X for this... > > ...jim > > > On 4/19/17 11:35 PM, Laurent Bourgès wrote: > >> Hi, >> >> Please review this MarlinFX upgrade to Marlin 0.7.5: >> >> JBS: no bug yet for OpenJFX 10 >> webrev: http://cr.openjdk.java.net/~

MarlinFX upgrade 0.7.5

Hi, Please review this MarlinFX upgrade to Marlin 0.7.5: JBS: no bug yet for OpenJFX 10 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.0/ Changes: - Renderers: fixed block processing - dead code & few comment removals in Strokers - fixed all floating-point number literals to

[10] RFR 8170024: PiscesRenderer.pr.emitAndClearAlphaRow cannot accept a pix_x_from parameter greater than clip.xmin

Please review this performance enhancement for OpenJFX 10 / Marlin: JBS: https://bugs.openjdk.java.net/browse/JDK-8170024 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170024.0/ The performance impact is small but may be more important for large shapes (left-side is 'empty) but

Re: [10] Review request: 8177985 Use Marlin renderer as the default FX rasterizer

Jim, It looks good to me (even I am not an official reviewer) and the Marlin Double-precision will be the default rasterizer. Bye, Laurent Le 14 avr. 2017 22:32, "Jim Graham" a écrit : > JBS: https://bugs.openjdk.java.net/browse/JDK-8177985 > webrev: http://cr.openjdk.java.net/~flar/JDK-817798

Re: [9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

_LG_POSITIONS_Y) = ceil(spmaxY) > > > NoAA comments are identical, though line numbers may be different... > I reported all changes in RendererNoAA. Laurent > > On 12/9/16 8:46 AM, Laurent Bourgès wrote: > >> Please review this simple fix for MarlinFX: >> &

[9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

Please review this simple fix for MarlinFX: JBS: https://bugs.openjdk.java.net/browse/JDK-8170030 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170030.0/ PS: I will provide asap a Marlin2D patch incorporating changes made in MarlinFX (including this one) Cheers, Laurent

Re: Planning for JavaFX.next

Hi, I would like to promote performance & quality improvements on the rasterizer that I could do in jdk10 within a tiger team focused on fx rendering: - multithreaded rendering (Marlin is thread-safe) ie the javafx could do parallel rendering of layers or shapes - software rasterizers: optimize i

[9] Review request: JDK-8170879 Fix Quad / Cubic BND constants for Marlin (FX)

Please review this simple fix for MarlinFX: JBS: https://bugs.openjdk.java.net/browse/JDK-8170879 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170879.0/ As mentioned in JBS, I studied both quality & performance and MarlinFX is now slightly better than openpisces (1.6 vs 2.1 avg

Re: Follow-on bugs

0x7FFF) 4543c4543 < + + 0x7DffL; --- > + + 0x7FFFL; 2016-11-30 23:12 GMT+01:00 Laurent Bourgès : > Jim, > > As announced yesterday night, I made a new 'Double' (alias D) pipeline for > marlinFX with 2 web

Re: Follow-on bugs

Jim, As announced yesterday night, I made a new 'Double' (alias D) pipeline for marlinFX with 2 webrevs: - cmp that compares the D pipeline vs the float pipeline: http://cr.openjdk.java.net/~lbourges/marlinFX-D/marlinFX-Double-cmp/ - raw that makes no comparison to be easily applicable as a patch:

Re: Follow-on bugs

Hi again, As I wanted to use double precision for long, I ported main marlinFX classes using a tricky sed scripts... fixed the 'D' pipeline and it seems already working well. The 2 mentioned bugs are then fixed + the performance ob DemoFX / GUIMark (webview) seems the same as the hot spot is in s

Re: Follow-on bugs

Hi, For large curves, I would recommend using a first step to subdivide the curve into smaller ones (1024 pixels as described in Lien paper) to ensure the AFD algorithm preserves enough accuracy with float values (first) in the Dasher. Basic recursive subdivision at halves with a large flatness t

Re: Follow-on bugs

Jim, There is one thing I think you should look at, though, and I wasn't sure if > I should file a bug. If you've downloaded the Rasterization verifier from > the old JBS bug for non-AA rendering, try running it with the 4quads mode > (-quad argument I think). It looks like it averages slightly

Review request for JDK-8170140: rendering anomaly with MarlinFX renderer

Jim & Kevin, Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170140.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8170140 Ths bug fix seems very simple in MaskMarlinAlphaConsumer: +// ensure last block flag = 0 to process final block:+ blkFl

Re: Optimised, high-performance, multi-threaded rendering pipeline

ieb Felix Bembrick : > > > > (Thanks to Kevin for lifting my "awaiting moderation" impasse). > > > > So, with all the recent discussions regarding the great contribution by > > Laurent Bourgès of MarlinFX, it was suggested that a separate thread be > &g

Review request for JDK-8169270: Leverage new Java2D Marlin rasterizer for JavaFX

Jim & Kevin, Sorry to announce this code review in late, I thought JBS would have sent such email from the comment. Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8169270.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8169270 Reviewers: flar, kcr Th

Re: Fwd: Re: Marlin-Renderer and JavaFX

Jim, 2016-11-10 0:47 GMT+01:00 Jim Graham : > Hi Laurent, > > Great job on creating a very obvious minimal impact! That should help > streamline it through the approval process. > Thanks. > > Is MarlinProperties.isEnabled still used? (Searching patch file - no, I > don't think so) > Will fi

Re: Fwd: Re: Marlin-Renderer and JavaFX

FX is what you are planning for FX. > I agree your naming convention. > > That's just for conversational purposes, I'm not proposing that we > formalize those into formal project names, but this will keep discussions > smaller? > > On 11/2/16 2:54 PM, Lauren

Re: Fwd: Re: Marlin-Renderer and JavaFX

Jim, > > I would think an effort to parallelize a single shape rasterization would > be much simpler in scope. Still outside the current JDK 9 timeline, but > definitely something that could help in future releases. I believe that > once we put the edges into the internal structures we could par

Re: Marlin-Renderer and JavaFX

Felix & Tobias, Could you please start another thread to discuss the parallelization (multi-threading) in JavaFX Graphics ? I am a bit lost as there is 13 messages since 12 hours on several topics (marlin, MT ...) so I would like closing this topic soon by answering MarlinFX questions and partici

Re: Marlin-Renderer and JavaFX

Hi, First results with DemoFX (run.sh -e sierpinski) to compare a simple path scene with HW pipeline (es2): - native pisces: 138 fps - open pisces: 150 fps - marlin fx: 300 fps But it is too simple to evaluate Marlin improvements: the more complex the shape is, the more performance you get Laure

Re: ACTION - JavaFX modular build is here

Kevin & David, It seems tricky to add a module dependency ! 2016-11-09 14:51 GMT+01:00 Kevin Rushforth : > My recommendation would be to avoid this dependency if possible, but if > not, then Dave's suggestion is the way to go. What is it that you need from > jdk.internal.ref that you can't do us

Re: ACTION - JavaFX modular build is here

Hi david, I am trying to build OpenJDK9 with OpenJFX9 (tip); I run the following scenario: - build OpenJFX9 with JDK9 EA 143: ok - build OpenJDK9 with --with-import-modules=_path_to_openjfx/9-dev/build/modular-sdk: ok - build OpenJFX9 with the built OpenJDK9: KO (gradle clean all) Apparently, the

Re: Fwd: Re: Marlin-Renderer and JavaFX

, "Laurent Bourgès" a écrit : > Jim, > > Here is the new patch: > http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-s02-ofx9.3/ > > Changes: > - cleanup wrt OpenJDK9 (Unsafe is OK but I switch to the standard Cleaner) > - modified PrismSettings as recommended and

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-04 19:55 GMT+01:00 Jim Graham : > On 11/4/2016 11:33 AM, Laurent Bourgès wrote: > >> For SWContext, I figured out that only openpisces.* classes were used >> directly via imports (hardcoded) so I left it unchanged. So you propose >> to generalize use of marlin

Re: Review request for 8169294:

Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham : > I'd like to see Kevin review the test as I'm not the best expert on our > JUnit framework. > I just added @Test annotations and kept the jtreg tags in header (for information). I could add asserts but JUnit does intercept any thrown exception and re

Review request for 8169294:

Hi, Please review this Path2D fix improving its storage growth algorithm as done in java2d: JBS: https://bugs.openjdk.java.net/browse/JDK-8169294 Webrev: http://cr.openjdk.java.net/~lbourges/fx/path2D/ PS: I converted the former jtreg test to JUnit test for OpenJFX. I hope it is correct, as I was

  1   2   >