On Mon, 15 Nov 2021 20:13:11 GMT, Martin Fox wrote:
> The code that maps from a Windows virtual key code to a Java key code in
> `getKeyCodeForChar` did not match the similar code in
> `ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable
> punctuation and symbols in
On Wed, 10 Nov 2021 18:48:04 GMT, Martin Fox wrote:
>> There was a mismatch between the way `get_glass_key` generated the Java key
>> code for a given key press and how `getKeyCodeForChar` determined the key
>> code for the matching character. For example, when pressing the plus sign on
>> a
On Tue, 30 Nov 2021 13:26:30 GMT, Kevin Rushforth wrote:
> This PR deprecates the JavaFX glass GTK 2 library for removal. Since there
> isn't an associated API, the mechanism for doing this is to print a
> "deprecated for removal" warning message when the `glassgtk2` library it is
> loaded. A
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window =
On Wed, 10 Nov 2021 12:46:08 GMT, Kevin Rushforth wrote:
>> This bug is caused by not sanity checking the data returned by a call to the
>> Windows Clipboard `IDataObject::GetData` method. When requesting a file
>> descriptor with a format of either `CFSTR_FILEDESCRIPTORA` or
>>
On Wed, 10 Nov 2021 12:46:08 GMT, Kevin Rushforth wrote:
>> This bug is caused by not sanity checking the data returned by a call to the
>> Windows Clipboard `IDataObject::GetData` method. When requesting a file
>> descriptor with a format of either `CFSTR_FILEDESCRIPTORA` or
>>
On Fri, 22 Oct 2021 17:32:10 GMT, Martin Fox wrote:
> During a drag-and-drop operation on the Mac the Command key will filter out
> every drag source operation except `NSDragOperationGeneric` (this behavior is
> provided by the OS). JavaFX drag sources only set the Move, Copy, and Link
> drag
On Tue, 28 Sep 2021 21:01:13 GMT, Martin Fox wrote:
> There was a mismatch between the way `get_glass_key` generated the Java key
> code for a given key press and how `getKeyCodeForChar` determined the key
> code for the matching character. For example, when pressing the plus sign on
> a US
On Tue, 5 Oct 2021 20:36:37 GMT, Martin Fox wrote:
> The test case for JDK-8160241 creates a window in a zoomed state (as defined
> by macOS). When the OS later goes to unzoom the window it will try to shrink
> it down to 1 point wide. This was entered as JDK-8163137 but the fix for that
>
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote:
> On an external (non-retina) monitor JavaFX LCD text on macOS is painful on
> the eyes.
> Retina diminishes it rather than cures it.
>
> The problem is a mix of a couple of things
> 1) CoreText no longer generates LCD glyphs (except perhaps
On Tue, 12 Oct 2021 15:12:43 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Break if reach self
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window =
On Fri, 17 Sep 2021 13:00:20 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Wed, 15 Sep 2021 23:06:39 GMT, Kevin Rushforth wrote:
>> Added a paragraph indicating that a review of a clean backport to an update
>> release is optional, if the bug in question has been approved for inclusion
>> into the release.
>
> Kevin Rushforth has updated the pull request
Vote: YES
From: openjfx-dev on behalf of Kevin
Rushforth
Date: Monday, 13 September 2021 at 8:07 PM
To: openjfx-dev@openjdk.java.net , Thiago
Milczarek Sayao
Subject: CFV: New OpenJFX Committer: Thiago Sayao
I hereby nominate Thiago Sayao [1] to OpenJFX Committer.
Thiago is an OpenJFX
On Fri, 20 Aug 2021 22:22:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Sun, 15 Aug 2021 21:18:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Sun, 15 Aug 2021 20:10:43 GMT, Thiago Milczarek Sayao
wrote:
> Weird, It works consistently for me on 20.04. Just tested again to be sure.
I am running a 20.04 VM. The test fails for me 60-70% of the time. I will
request someone in team to try this once.
-
PR:
On Sun, 15 Aug 2021 16:26:59 GMT, Pankaj Bansal wrote:
>> Test works on Linux, don't know on other platforms.
>>
>> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.dnd.DndRawImageTest`
>
>> Test works on Lin
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage window =
On Wed, 11 Aug 2021 23:40:00 GMT, Thiago Milczarek Sayao
wrote:
> Test works on Linux, don't know on other platforms.
>
> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.dnd.DndRawImageTest`
The fix does solve the issue and looks good to me.
The test
On Fri, 6 Aug 2021 20:44:23 GMT, Thiago Milczarek Sayao
wrote:
> > I will look at this. Meanwhile, could you please write an automated system
> > test for this?
>
> Sure, I would provide it, but in the past drag and drop tests were not
> possible. Any ideas?
I think it should be possible to
On Fri, 6 Aug 2021 02:18:38 GMT, Thiago Milczarek Sayao
wrote:
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> It simplified the gtk2 `DragView::View::expose` to paint with
>
On Fri, 30 Jul 2021 06:23:59 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - fix review comments
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
On Mon, 26 Jul 2021 18:15:04 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8250590 - add missing @since tag
>
> modules/javafx.graphics/src/main/java/javafx/css/CssParser.java line 4748:
>
On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal wrote:
> The bug is a regression as a result of fix done for JDK-8227366 and is
> reproducible on Linux and Mac. This fix is being reverted in this change and
> a new bug (JDK-8271054) has been created to redo the JDK-8227366
>
&g
On Sat, 24 Jul 2021 12:45:04 GMT, Kevin Rushforth wrote:
> Remove the obsolete `apps/samples/3DViewer/src/test` directory from the
> 3DViewer sample, including two test classes that don't run and a set of data
> files that won't load. This is a follow-on cleanup bug to
>
On Fri, 23 Jul 2021 16:35:58 GMT, Kevin Rushforth wrote:
>> Pankaj Bansal has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed review comments 1) Increase delay 2) Fix Formatting 3) Make test
>&g
re as
> well. This seems wrong as calling stage.setAlwaysOnTop(true) should not be
> required to bring stage window in focus on running the test. This may be an
> issue on my Window machine or something similar. I hope reviewers can shed
> some light on this.
Pankaj Bansal has upda
On Fri, 23 Jul 2021 00:16:33 GMT, Kevin Rushforth wrote:
> The fix (reverting the earlier fix for JDK-8227366) looks fine to me. The
> test runs fine on Mac (and mostly fine on Linux, but I need to test a couple
> more things).
>
> I also see the failure on Windows frequently depending on
re as
> well. This seems wrong as calling stage.setAlwaysOnTop(true) should not be
> required to bring stage window in focus on running the test. This may be an
> issue on my Window machine or something similar. I hope reviewers can shed
> some light on this.
Pankaj Bansal has upda
On Sat, 10 Jul 2021 16:06:18 GMT, Thiago Milczarek Sayao
wrote:
>> The PR approach is to set `gtk_window_set_keep_above` to true on
>> APPLICATION_MODAL windows, so they will not stay behind non
>> APPLICATION_MODAL windows.
>>
>> This is passed on WindowStage.java:198 as a mask.
>>
>> The
On Tue, 29 Jun 2021 14:21:27 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 18. I will integrate this immediately
> after forking the `jfx17` stabilization branch, which is scheduled for
> Thursday, July 8, 2021 at 16:00 UTC.
>
> ~~Leaving it as `Draft` for now. I'll make
On Tue, 29 Jun 2021 21:58:36 GMT, Thiago Milczarek Sayao
wrote:
>> The PR approach is to set `gtk_window_set_keep_above` to true on
>> APPLICATION_MODAL windows, so they will not stay behind non
>> APPLICATION_MODAL windows.
>>
>> This is passed on WindowStage.java:198 as a mask.
>>
>> The
On Mon, 28 Jun 2021 12:27:34 GMT, Kevin Rushforth wrote:
>> This is a fix for the assertion error message that is printed to the console
>> on macOS 10.15 or later when an application calls `Platform.exit` while a
>> `Stage` is showing.
>>
>> The root cause is a latent bug in the JavaFX glass
On Tue, 22 Jun 2021 20:42:48 GMT, Kevin Rushforth wrote:
> This is a fix for the assertion error message that is printed to the console
> on macOS 10.15 or later when an application calls `Platform.exit` while a
> `Stage` is showing.
>
> The root cause is a latent bug in the JavaFX glass code
On Sat, 26 Jun 2021 13:01:15 GMT, Kevin Rushforth wrote:
> This is a follow-on fix to
> [JDK-8264139](https://bugs.openjdk.java.net/browse/JDK-8264139), which added
> `@SuppressWarning` annotations to usages of deprecated security manager
> methods. @wangweij noticed that there was one
On Mon, 31 May 2021 06:37:40 GMT, Ambarish Rapte wrote:
>> `StyleManager.calculateCheckSum()` uses a raw InputStream as the input to a
>> `DigestInputStream` and reads one byte at a time. This is slower in
>> performance and should be changed, either to use `BufferedInputStream` or
>> read
On Thu, 27 May 2021 22:14:51 GMT, Kevin Rushforth wrote:
> This fix adds a `.gitattributes` file to prevent git from replacing line
> endings if the global `.gitconfig` file on the client system is configured
> with core.autocrlf = true (which it is by default when using the native Git
> for
On Fri, 21 May 2021 11:48:21 GMT, Ajit Ghaisas wrote:
> The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors
> were deprecated for removal in openjfx16.
> This PR removes these constructors (targeted for openjfx17).
Marked as reviewed by pbansal (Committer).
On Sat, 8 May 2021 14:13:34 GMT, Kevin Rushforth wrote:
> As noted in PR #212 the unused `tools/scripts/build.ps1` script no longer
> works. This script was added in support of the Appveyor builds in the old
> `javafxports/openjdk-jfx` sandbox repo, which haven't been used in nearly two
>
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote:
> A typo in one of the labels of Bidi text has been corrected. This is located
> in Samples > Controls > Text > Bidi
Marked as reviewed by pbansal (Committer).
-
PR: https://git.openjdk.java.net/jfx/pull/500
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote:
> As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip
> bundle for javadoc offline processing. This missing entry is causing a build
> failure on my system (which will soon propagate to our CI builds).
Marked as
On Wed, 21 Apr 2021 10:42:04 GMT, Jose Pereda wrote:
> Both `GlassDialogs.m` for macOS and `GlassCommonDialogs.c` for Linux use UTF8
> encoding for the file names selected via native FileChooser, and this will
> fail if there are emojis in the file name.
>
> This PR uses the same approach as
On Wed, 21 Apr 2021 10:42:04 GMT, Jose Pereda wrote:
> Both `GlassDialogs.m` for macOS and `GlassCommonDialogs.c` for Linux use UTF8
> encoding for the file names selected via native FileChooser, and this will
> fail if there are emojis in the file name.
>
> This PR uses the same approach as
On Thu, 6 May 2021 10:22:13 GMT, Ajit Ghaisas wrote:
> Please review a very simple fix that adds a missing javadoc tag.
Marked as reviewed by pbansal (Committer).
-
PR: https://git.openjdk.java.net/jfx/pull/487
On Wed, 10 Mar 2021 18:23:24 GMT, Thiago Milczarek Sayao
wrote:
>> This is a new approach to rewrite parts of gtk glass backend to be more
>> clean.
>>
>> I will provide small "manageable" PR to incrementally make the backend
>> better.
>>
>> This PR adresses cleanup of the Size and
On Wed, 14 Apr 2021 12:40:29 GMT, Kevin Rushforth wrote:
>> As noted in the JBS bug, the minimum macOS version on which JavaFX will run
>> is currently set to 10.10 in `mac.gradle`. macOS 10.10 is many years out of
>> support, so we should update this minimum. Further, macOS / aarch64 (aka
>>
On Wed, 24 Mar 2021 13:38:27 GMT, Kevin Rushforth wrote:
> If the macOS system settings for opening documents as tabs is set to
> "Always", then all JavaFX windows, including Dialogs, are opened as tabs,
> unless they are child windows (that is, a Window with an owner).
>
> This is a real
On Sun, 21 Mar 2021 00:31:35 GMT, Thiago Milczarek Sayao
wrote:
>> Looks good now.
>
> Testing:
>
> **master**
> 
>
> **tsayao:glass_gtk_new_position_and_size**
>
On Wed, 10 Feb 2021 02:24:57 GMT, Nir Lisker wrote:
>> Fixes a mutability issue for `LocalDateTimeStringConverter` (and
>> `LocalDateStringConverter`) where the chronology can change during the
>> lifetime of the instance and cause an inconsistent state. The following
>> changes were made:
>>
On Sun, 7 Feb 2021 11:33:13 GMT, Pankaj Bansal wrote:
> JavaFX ignores the HiDPI scaling settings on Fedora 32 and Ubuntu 20.04.
>
> The scale detection in JavaFX assumes that the "scaling-factor" setting in
> "org.gnome.desktop.interface" has the correct Hi-D
JavaFX ignores the HiDPI scaling settings on Fedora 32 and Ubuntu 20.04.
The scale detection in JavaFX assumes that the "scaling-factor" setting in
"org.gnome.desktop.interface" has the correct Hi-DPI setting. But this not true
for some systems and "scaling-factor" has value of 0. JavaFX should
On Wed, 27 Jan 2021 13:31:45 GMT, Kevin Rushforth wrote:
> Prism implements a dirty region optimization, where in many cases, only part
> of the scene graph is re-rendered when something changes. In support of this,
> the `ViewPainter` class in the Quantum Toolkit keeps an array of node paths,
On Fri, 29 Jan 2021 13:19:00 GMT, Kevin Rushforth wrote:
>> The JavaFX API does not provide a way to get the state of CAPS LOCK or NUM
>> LOCK on the keyboard. Being able to read the lock state would allow an
>> application to inform the user that caps lock was enabled for passwords or
>>
On Fri, 12 Jun 2020 20:22:12 GMT, Thiago Milczarek Sayao
wrote:
>>> I had used two compilation parameters to limit Gtk on 3.8 (so it would
>>> generate error if any symbol > 3.8 were used). But that does not seem to
>>> work on 18.04, so I removed it.
>>
>> Good. I was going to ask you about
On Sun, 14 Jun 2020 06:49:42 GMT, Pankaj Bansal wrote:
>> I have investigated the Tab Pane Drag Test and it works manually.
>>
>> import javafx.application.Application;
>> import javafx.scene.Scene;
>> import javafx.scene.control.Tab;
>> import jav
On Wed, 10 Jun 2020 13:11:29 GMT, Thiago Milczarek Sayao
wrote:
>>> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish
>>> results. I will later do the same for Oracle Linux 7.7.
>>>
>>> One thing to note is that this new GTK pipeline doesn't run on Ubuntu
>>> 16.04. I get
On Fri, 12 Jun 2020 11:55:47 GMT, Pankaj Bansal wrote:
>> I have run the test on OL82 on updated code. Following are the results. I
>> will rerun this on Ubuntu 18.04 and get back with the results
>> > src="https://user-images.githubusercontent.com/6153953/844698
On Fri, 12 Jun 2020 05:56:41 GMT, Pankaj Bansal wrote:
>> Here is the result on Ubuntu 20.04 with the latest changes:
>>
>> 
>>
>> Some tests seem
On Fri, 3 Apr 2020 23:41:49 GMT, Thiago Milczarek Sayao
wrote:
>> I see a lot of work going into this.
>>
>> In order for this to progress beyond the prototype or concept phase, we will
>> need to have a discussion on the openjfx-dev mailing list in a separate
>> email thread that is not
On Tue, 12 Jan 2021 17:01:40 GMT, Kevin Rushforth wrote:
> Simple fix to the `submit.yml` script to run `apt-get update` prior to
> installing needed packages on Linux. Without this, the request to install
> packages can fail to find the requested pacakges due to an out-of-date cache.
>
>
On Tue, 17 Nov 2020 18:10:13 GMT, Kevin Rushforth wrote:
> This fix adds documentation and a warning to clarify that loading the JavaFX
> modules from the classpath is not a supported configuration. This will not
> affect deployments that put the JavaFX modular jars on the classpath, but
>
On Wed, 6 Jan 2021 00:09:52 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 17. I will integrate this immediately
> after forking the `jfx16` stabilization branch.
Marked as reviewed by pbansal (Committer).
-
PR: https://git.openjdk.java.net/jfx/pull/371
On Thu, 22 Oct 2020 11:45:08 GMT, Kevin Rushforth wrote:
> The test targets in `build.gradle` are set up to run only classes whose name
> ends with exactly `Test`. A test class named `RunMyTest.java` will be run,
> but a test called `CheckSomething.java` will not be. This was done because
>
On Thu, 22 Oct 2020 14:22:32 GMT, Pankaj Bansal wrote:
> The test test.robot.javafx.scene.MouseLocationOnScreenTest fails
> intermittently on Windows and Mac system though it fails on Windows more
> often than Mac.
>
> The test uses robot to move the mouse at different posi
On Fri, 23 Oct 2020 13:33:35 GMT, Kevin Rushforth wrote:
>> Pankaj Bansal has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/
is passing in less than 50 seconds on all
> platforms. Following command can be used to run the test
> gradle --continue --info -PFULL_TEST=true -PUSE_ROBOT=true
> :systemTest:cleanTest :systemTests:test --tests
> test.robot.javafx.scene.MouseLocationOnScreenTest
Pankaj Bansal has upd
The test test.robot.javafx.scene.MouseLocationOnScreenTest fails intermittently
on Windows and Mac system though it fails on Windows more often than Mac.
The test uses robot to move the mouse at different positions on screen using
mouseMove and then validates the mouse coordinates by
On Thu, 22 Oct 2020 12:29:51 GMT, Pankaj Bansal wrote:
> The test test.com.sun.javafx.image.impl.ImageRaceTest is fails intermittently
> in linux
>
> This is caused by use of Thread.yield. Thread.yield is used to pause the
> current thread for some time. It gives a hint to t
The test test.com.sun.javafx.image.impl.ImageRaceTest is fails intermittently
in linux
This is caused by use of Thread.yield. Thread.yield is used to tell pause the
current thread for some time. It gives a hint to thread scheduler that the
current thread should pause and other threads with
On Thu, 3 Sep 2020 15:18:06 GMT, Kevin Rushforth wrote:
> As noted in the bug report, we get a pair of change events every time the
> list of screens changes. First, a change is
> sent with an empty list of screens and then a change is sent with the new
> list of screens. This happens whenever
On Sun, 14 Jun 2020 06:49:42 GMT, Pankaj Bansal wrote:
>> I have investigated the Tab Pane Drag Test and it works manually.
>>
>> import javafx.application.Application;
>> import javafx.scene.Scene;
>> import javafx.scene.control.Tab;
>> import jav
On Fri, 12 Jun 2020 20:22:12 GMT, Thiago Milczarek Sayao
wrote:
>>> I had used two compilation parameters to limit Gtk on 3.8 (so it would
>>> generate error if any symbol > 3.8 were used).
>>> But that does not seem to work on 18.04, so I removed it.
>>
>> Good. I was going to ask you about
On Fri, 12 Jun 2020 11:55:47 GMT, Pankaj Bansal wrote:
>> I have run the test on OL82 on updated code. Following are the results. I
>> will rerun this on Ubuntu 18.04 and get back
>> with the results > src="https://user-images.githubusercontent.com/6153953/844698
On Fri, 12 Jun 2020 05:56:41 GMT, Pankaj Bansal wrote:
>> Here is the result on Ubuntu 20.04 with the latest changes:
>>
>> 
>>
>> Some tests seem
On Wed, 10 Jun 2020 13:11:29 GMT, Thiago Milczarek Sayao
wrote:
>>> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish
>>> results. I will later do the same for Oracle
>>> Linux 7.7.
>>> One thing to note is that this new GTK pipeline doesn't run on Ubuntu
>>> 16.04. I get
On Fri, 3 Apr 2020 23:41:49 GMT, Thiago Milczarek Sayao
wrote:
>> I see a lot of work going into this.
>>
>> In order for this to progress beyond the prototype or concept phase, we will
>> need to have a discussion on the
>> openjfx-dev mailing list in a separate email thread that is not
On Thu, 2 Jan 2020 06:08:25 GMT, Thiago Milczarek Sayao
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8225571
>>
>> To run tests (on the root of the source tree):
>> ./gradlew apps
>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
>> dragdrop.DragDropWithControls
>> java
use the problem happens before.
But I suspect when the gdk_drag_context_get_selected_action(event->context)
returning ZERO problem is fixed, the need of gdk_drag_drop_done() will be the
problem.
Cheers.
____
De: Pankaj Bansal
Enviado: segunda-feira, 13 de maio de 2019
Hello Thiago,
This solution was proposed by one of the engineers in Oracle sometime back and
we have tested it. This does not seem to solve the issue. If you wish to try
this, please take the patch [1], which is attached in the bug JDK-8211302. This
patch neatly defines the function depending
Hello Dragos,
There are some known issues with Drag & Drop on Ubuntu from JavaFX11 as gtk3
has been made default. There is a bug filled for the same in JBS JDK-8211302.
Drag & Drop does not work, but I don’t get the error you are getting. Can you
please create a small reproducer to look at.
Hi Kevin/Murali,
Please review the fix.
JBS: https://bugs.openjdk.java.net/browse/JDK-8211280
webrev: http://cr.openjdk.java.net/~pbansal/8211280/webrev.00/
Regards,
Pankaj
Hi Kevin/Murali,
Please review the fix.
JBS: https://bugs.openjdk.java.net/browse/JDK-8208070
webrev: http://cr.openjdk.java.net/~pbansal/8208070/webrev.00/
Regards,
Pankaj
Hi All,
Please review the patch for 8u-dev backport for HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8087516"JDK-8087516. It adds
conditional support for gtk3.
As part of the enhancement backport, we will be backporting 18 more bugs fixes
done for GTK3 related issues since jdk9.
, October 11, 2018 9:17 PM
To: Johan Vos; Pankaj Bansal
Cc: openjfx-dev@openjdk.java.net
Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3
on Linux
I used the wrong bug ID below. Here is the right one:
8189689: JavaFX build fails with gcc 6 [1]
Pankaj will send
Hi Kevin,
Please review the backport fix for HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8189689"JDK-8189689.
Webrev: http://cr.openjdk.java.net/~pbansal/8189689/webrev.00/
Thanks,
Pankaj
From: Johan Vos [mailto:johan@gluonhq.com]
Sent: Thursday, October 11, 2018 4:05 PM
To: Pankaj Bansal
Cc: Kevin Rushforth; openjfx-dev@openjdk.java.net
Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3
on Linux
Hi Pankaj,
What gcc version did you use
rom: Kevin Rushforth
Sent: Thursday, October 4, 2018 7:41 AM
To: Pankaj Bansal; openjfx-dev@openjdk.java.net
Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3
on Linux
I debugged this offline earlier today, and it looks related to a collision in
the glib library. As
Hi All,
Please review the patch for 8u-dev backport for HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8087516"JDK-8087516. It adds
conditional support for gtk3.
Along with the enhancement, following bug fixes have also been included in the
backport webrev
1.
Hi Kevin, Murali,
Please review this fix,
Webrev: http://cr.openjdk.java.net/~pbansal/8204336/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8204336
Regards,
Pankaj
Hi Kevin, Murali & Ajit,
Please review this fix,
Webrev: http://cr.openjdk.java.net/~pbansal/8191885/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8191885
Regards,
Pankaj
Hi Kevin & Murali,
Please review this fix,
Webrev: http://cr.openjdk.java.net/~pbansal/8204635/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8204635
Regards,
Pankaj
Hello Kevin,
Thanks for the review.
I have incorporated all the review comments. Please have a look.
webrev: http://cr.openjdk.java.net/~pbansal/8196031/webrev.01/
Regards,
Pankaj Bansal
-Original Message-
From: Kevin Rushforth
Sent: Saturday, June 9, 2018 1:15 AM
To: Pankaj Bansal
Hi Kevin & Murali,
Please review this fix,
Webrev: http://cr.openjdk.java.net/~pbansal/8196031/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8196031
Regards,
Pankaj
Hi Kevin & Ajit,
Please review this fix,
Webrev: http://cr.openjdk.java.net/~pbansal/8199614/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8199614
Regards,
Pankaj
Hi All,
Request to review this fix.
Webrev: http://cr.openjdk.java.net/~pbansal/8163795/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8163795
Regards,
Pankaj Bansal
99 matches
Mail list logo
