Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v4]

2021-03-09 Thread Kevin Rushforth
On Mon, 8 Mar 2021 22:47:16 GMT, John Neffenger wrote: >> See the [Gradle Wrapper Validation >> Action](https://github.com/marketplace/actions/gradle-wrapper-validation) >> for details on this pull request. I'll test the changes with the following >> sequence of commits: >> >> 1. This commit

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 22:37:10 GMT, John Neffenger wrote: >> If it isn't too hard to make the running of the other three jobs dependent >> on the wrapper validation job, that would be good, as long as the validation >> job is fast. The other three still need to run in parallel with each other. >>

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 22:55:18 GMT, John Neffenger wrote: >> Okay, this is looking better! The validation took only 23 seconds, and >> GitHub shows the following results: >> >> ![some-checks-were-not-successful-2](https://user-images.githubusercontent.com/1413266/110390566-0b7ac680-801b-11eb-8090

Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v4]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation > Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for > details on this pull request. I'll test the changes with the following > sequence of commits: > > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go > und

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 22:13:09 GMT, Kevin Rushforth wrote: >> Thanks, Kevin. I'll merge the two workflow files. >> >> The test results aren't what I expected: >> >> ![some-checks-were-not-successful](https://user-images.githubusercontent.com/1413266/110386542-424dde00-8015-11eb-9cef-97d2ff2a5d27.p

Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v3]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation > Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for > details on this pull request. I'll test the changes with the following > sequence of commits: > > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go > und

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 22:00:14 GMT, John Neffenger wrote: >> It might be better to include the validation task in the same >> [`submit.yml`](https://github.com/openjdk/jfx/blob/master/.github/workflows/submit.yml) >> file as the pre-submit tests, as a separate job. That way it will get the >> sa

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 21:44:03 GMT, Kevin Rushforth wrote: >> So far, so good. The tampered file was not detected: >> >> ![all-checks-have-passed](https://user-images.githubusercontent.com/1413266/110383521-411ab200-8011-11eb-88ee-27102e0b6d81.png) >> >> The next commit will add the Official Gradl

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 21:23:47 GMT, John Neffenger wrote: >>> 1. This commit adds a tampered Gradle Wrapper JAR file, which should go >>> undetected. >>> 2. The next commit will add the Official Gradle Wrapper Validation Action, >>> which should detect the tampered file. >>> 3. The final commit w

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
On Mon, 8 Mar 2021 20:38:09 GMT, Kevin Rushforth wrote: >> See the [Gradle Wrapper Validation >> Action](https://github.com/marketplace/actions/gradle-wrapper-validation) >> for details on this pull request. I'll test the changes with the following >> sequence of commits: >> >> 1. This commit

Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v2]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation > Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for > details on this pull request. I'll test the changes with the following > sequence of commits: > > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go > und

Re: RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 20:34:05 GMT, John Neffenger wrote: > 1. This commit adds a tampered Gradle Wrapper JAR file, which should go > undetected. > 2. The next commit will add the Official Gradle Wrapper Validation Action, > which should detect the tampered file. > 3. The final commit will remove

RFR: 8263204: Add Gradle Wrapper Validation Action

2021-03-08 Thread John Neffenger
See the [Gradle Wrapper Validation Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for details on this pull request. I'll test the changes with the following sequence of commits: 1. This commit adds a tampered Gradle Wrapper JAR file, which should go undetected. 2. Th