On Fri, 17 Sep 2021 13:00:20 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Tue, 17 Aug 2021 13:12:41 GMT, Pankaj Bansal wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change test to manual
>
> The fix works fine and the test passes on all platforms. I have given minor
>
On Fri, 17 Sep 2021 13:00:20 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::expose` to paint with
> `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8)
On Thu, 16 Sep 2021 21:57:08 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review requests.
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp line 916:
>
>> 914:
On Fri, 20 Aug 2021 22:22:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Fri, 20 Aug 2021 22:22:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Tue, 17 Aug 2021 13:10:53 GMT, Pankaj Bansal wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change test to manual
>
> tests/manual/dnd/DndTestDragViewRawImage.java line 59:
>
>> 57: });
>>
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::expose` to paint with
> `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8)
On Sun, 15 Aug 2021 21:18:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Sun, 15 Aug 2021 21:18:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::expose` to paint with
> `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8)
On Wed, 11 Aug 2021 23:42:47 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Sun, 15 Aug 2021 16:26:59 GMT, Pankaj Bansal wrote:
>> Test works on Linux, don't know on other platforms.
>>
>> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.dnd.DndRawImageTest`
>
>> Test works on Linux, don't know on other platforms.
>>
>>
On Sun, 15 Aug 2021 16:26:59 GMT, Pankaj Bansal wrote:
>> Test works on Linux, don't know on other platforms.
>>
>> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.dnd.DndRawImageTest`
>
>> Test works on Linux, don't know on other platforms.
>>
>>
On Wed, 11 Aug 2021 23:40:00 GMT, Thiago Milczarek Sayao
wrote:
> Test works on Linux, don't know on other platforms.
>
> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.dnd.DndRawImageTest`
The fix does solve the issue and looks good to me.
The test
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::expose` to paint with
> `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8)
On Fri, 6 Aug 2021 02:18:38 GMT, Thiago Milczarek Sayao
wrote:
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::expose` to paint with
>
On 8/7/2021 11:56 AM, Pankaj Bansal wrote:
On Fri, 6 Aug 2021 20:44:23 GMT, Thiago Milczarek Sayao
wrote:
I will look at this. Meanwhile, could you please write an automated system test
for this?
Sure, I would provide it, but in the past drag and drop tests were not
possible. Any
On Fri, 6 Aug 2021 20:44:23 GMT, Thiago Milczarek Sayao
wrote:
> > I will look at this. Meanwhile, could you please write an automated system
> > test for this?
>
> Sure, I would provide it, but in the past drag and drop tests were not
> possible. Any ideas?
I think it should be possible to
On Fri, 6 Aug 2021 05:30:39 GMT, Pankaj Bansal wrote:
> I will look at this. Meanwhile, could you please write an automated system
> test for this?
Sure, I would provide it, but in the past drag and drop tests were not
possible. Any ideas?
-
PR:
On Fri, 6 Aug 2021 02:18:38 GMT, Thiago Milczarek Sayao
wrote:
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> It simplified the gtk2 `DragView::View::expose` to paint with
>
It seems raw images need to be converted BRGA -> RGBA.
It was being converted on gtk2 code path, but gtk3 only uses
`gtk_drag_set_icon_pixbuf`.
It simplified the gtk2 `DragView::View::expose` to paint with
`gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8). The existing
path
23 matches
Mail list logo
