Re: RFR: 8274433: All Cells: misbehavior of startEdit [v2]

2021-10-04 Thread Ajit Ghaisas
On Fri, 1 Oct 2021 14:59:02 GMT, Jeanette Winzenburg wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit

Re: RFR: 8274433: All Cells: misbehavior of startEdit [v2]

2021-10-01 Thread Marius Hanl
On Fri, 1 Oct 2021 14:59:02 GMT, Jeanette Winzenburg wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit

Re: RFR: 8274433: All Cells: misbehavior of startEdit [v2]

2021-10-01 Thread Jeanette Winzenburg
> The misbehavior happens if (super) startEdit didn't succeed (== > !cell.isEditing): > > - must not fire editStart event > - must not update control's editing location > > fix is to back out of startEdit if super.startEdit doesn't switch the cell > into editing mode > > Added tests that

Re: RFR: 8274433: All Cells: misbehavior of startEdit

2021-10-01 Thread Jeanette Winzenburg
On Fri, 1 Oct 2021 13:11:21 GMT, Marius Hanl wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit doesn't

Re: RFR: 8274433: All Cells: misbehavior of startEdit

2021-10-01 Thread Jeanette Winzenburg
On Fri, 1 Oct 2021 13:10:29 GMT, Marius Hanl wrote: >> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit doesn't

Re: RFR: 8274433: All Cells: misbehavior of startEdit

2021-10-01 Thread Marius Hanl
On Thu, 30 Sep 2021 12:00:16 GMT, Jeanette Winzenburg wrote: > The misbehavior happens if (super) startEdit didn't succeed (== > !cell.isEditing): > > - must not fire editStart event > - must not update control's editing location > > fix is to back out of startEdit if super.startEdit doesn't

RFR: 8274433: All Cells: misbehavior of startEdit

2021-09-30 Thread Jeanette Winzenburg
The misbehavior happens if (super) startEdit didn't succeed (== !cell.isEditing): - must not fire editStart event - must not update control's editing location fix is to back out of startEdit if super.startEdit doesn't switch the cell into editing mode Added tests that failed/passed