> Backport this a11y fix to jfx17u.
> This is not a clean backport. The source code changes apply cleanly but there
> was a conflict in test file.
> The test `DialogTest.java` file does not exist in jfx17u source.
> The file is now added but only with one test that was added as part of this
> fix
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
On Mon, 21 Nov 2022 20:05:10 GMT, Ambarish Rapte wrote:
> Backport this a11y fix to jfx17u.
> This is not a clean backport. The source code changes apply cleanly but there
> was a conflict in test file.
> The test `DialogTest.java` file does not exist in jfx17u source.
> The file is now added bu
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
I'm still leaning towards just "when" mainly because its short and,
although perhaps not 100% accurate, recognizable enough like `map` or
`flatMap` would be. I think once it is in a bit more common use, it
will be quite clear what it does and what it is intended for without
needing to be remin
On Mon, 21 Nov 2022 23:50:58 GMT, John Hendrikx wrote:
> Just making sure, I can integrate this now?
format requirements have been fulfilled (1 reviewer, 1 author). go!
-
PR: https://git.openjdk.org/jfx/pull/957
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Tue, 15 Nov 2022 18:30:33 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners insta
Clean backport. CI build run on Linux.
-
Commit messages:
- 8283402: Update to gcc 11.2 on Linux
Changes: https://git.openjdk.org/jfx17u/pull/94/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=94&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8283402
Stats: 6 lin
Clean backport. CI build run on all three platforms.
-
Commit messages:
- 8289541: Update ICU4C to 71.1
Changes: https://git.openjdk.org/jfx17u/pull/92/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=92&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8289541
Stats
Clean backport. CI build run on all three platforms.
-
Commit messages:
- 8291087: Wrong position of focus of screen reader on Windows with screen
scale > 1
Changes: https://git.openjdk.org/jfx17u/pull/93/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=93&range=00
Issu
On Mon, 21 Nov 2022 22:28:15 GMT, Kevin Rushforth wrote:
> treating certain categories of warnings as errors at compilation time is
> quite feasible. The JDK does this.
I have "missing override annotations" set to errors in my projects. I think
it's a good candidate here.
-
PR: h
On Tue, 15 Nov 2022 18:30:33 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners insta
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
Maybe "updatedWhen" would work, although I still like "activeWhen" or
simply "when" better. The problem that has been raised about
"updateWhen" is that it isn't really the right verb tense. What we want
is a binding that is updated (or active) when the condition evaluates to
true. The value its
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Mon, 21 Nov 2022 20:05:10 GMT, Ambarish Rapte wrote:
> Backport this a11y fix to jfx17u.
> This is not a clean backport. The source code changes apply cleanly but there
> was a conflict in test file.
> The test `DialogTest.java` file does not exist in jfx17u source.
> The file is now added bu
My proposal in the PR was 'updateWhen', which I prefer over observedWhen
and activeWhen. Just 'when' is also fine by me and prefered over 'when'.
My only problem with 'when'/'whenever' is that they don't say what happens
"when"/"whenever". However, since these are bindings, and what bindings do
is
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
My initial reaction is that I like the name "activeWhen" at least as
well as any of the alternatives discussed so far. It's less wordy than
"observedWhen" (which I suggested), and probably easier to describe. I
don't really care for using the term "scope".
I also think "when" or "whenever" are
On Mon, 21 Nov 2022 15:24:24 GMT, Kevin Rushforth wrote:
> One other quick comment: since you are removing some suppress warnings for
> "removal", I'd like to see the results of a build and test with `gradle
> -PLINT=removal` to ensure that there are no new warnings.
I've run this locally, and
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 22:36:05 GMT, Kevin Rushforth wrote:
>> let's create a followup ticket - the messed up statements in Disposer and
>> especially in PrismFontFactory:1401 are worrying.
>>
>> cc: @prrace
>
> @andy-goryachev-oracle The ones in the various `Disposer` classes and
> `PrismFontFac
On Mon, 21 Nov 2022 20:05:25 GMT, John Hendrikx wrote:
>> Removing the `(int)` cast is a behavior-neutral change. What you are
>> pointing out does look a bug, but it is unrelated to this cleanup, so should
>> be filed and fixed separately.
>
> Yeah, this looks like a bug, as `(steps - counter)
I like "when" (partly because it is short and to the point, Java is already
verbose enough.)
I also thought of "trackWhile" to indicate the value is only tracking the
value of the source ObservableValue while the condition is true.
Scott
On Mon, Nov 14, 2022 at 12:47 PM Andy Goryachev
wrote:
On Mon, 21 Nov 2022 20:49:07 GMT, Andy Goryachev wrote:
>> but the ticket specifies (javafx.)base, right?
>
> let's create a followup ticket - the messed up statements in Disposer and
> especially in PrismFontFactory:1401 are worrying.
>
> cc: @prrace
@andy-goryachev-oracle The ones in the var
Thanks for your clarifications.
Maybe the actual problem is that we don't have a good name for "gets
the current value, but doesn't subscribe to updates".
We could call bindings "active" when changes of the source value are
processed, and "inactive" if the binding exists, but doesn't process
change
On Mon, 21 Nov 2022 20:34:02 GMT, John Hendrikx wrote:
> I think the Skara tooling might be able to reject PR's with warnings, if not,
> Gradle can fail builds with warnings (but that's a bit more heavy handed).
Quite the opposite. This would be well beyond Skara to do this (and I would
argue
On Mon, 21 Nov 2022 20:21:23 GMT, Andy Goryachev wrote:
>> Shims are not public as far as I know.
>
> you are right. I just looked at the package "package javafx.event;" and said
> hmmm...
And _thank you_ for doing that. That's exactly the sort of thing we would want
to catch if it were part
This is why I suggested long ago that there should be .jmod zips in Maven
central or similar. We need a dependency management system that works with
JMODs for exactly this reason. Zips in the current public repos would work.
Scott
> On Nov 21, 2022, at 11:08 AM, Armin Schrenk wrote:
>
> Oh,
Hi Michael,
Thanks for your suggestion.
The effect is not quite what you describe however, as the initial value
when the operation is first invoked is retained. It's true however that
when the condition is always `false` that the value will be a constant,
and that when it is always `true` it
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 21:06:53 GMT, Nir Lisker wrote:
>> let's create a followup ticket - the messed up statements in Disposer and
>> especially in PrismFontFactory:1401 are worrying.
>>
>> cc: @prrace
>
> All of the bugs in the list are not in the base module. We are slicing the
> work both per
On Mon, 21 Nov 2022 20:49:07 GMT, Andy Goryachev wrote:
>> but the ticket specifies (javafx.)base, right?
>
> let's create a followup ticket - the messed up statements in Disposer and
> especially in PrismFontFactory:1401 are worrying.
>
> cc: @prrace
All of the bugs in the list are not in the
On Mon, 21 Nov 2022 17:03:54 GMT, Andy Goryachev wrote:
> This comment might be out of place, but since we started fixing raw type use
> may be you could take a look at it? I know it's in javafx.graphics, so not
> technically a part of this PR, but It's pretty weird. Bringing it up here
> beca
On Mon, 21 Nov 2022 20:43:11 GMT, John Hendrikx wrote:
>> I didn't fix all problems, only the easy non-controversial ones. Things
>> that might actually be bugs require more careful review and so are best
>> saved for smaller PR's IMHO.
>>
>> This is already fixing around 2000 warnings in 250
On Mon, 21 Nov 2022 20:46:57 GMT, Andy Goryachev wrote:
>> I only fixed the warnings listed in the ticket :)
>
> but the ticket specifies (javafx.)base, right?
let's create a followup ticket - the messed up statements in Disposer and
especially in PrismFontFactory:1401 are worrying.
cc: @prrac
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 20:27:27 GMT, Andy Goryachev wrote:
>> full list
>>
>>
>> Description ResourceLocation
>> Empty control-flow statement DateCellBehavior.java line 95
>> Empty control-flow statement Disposer.java line 65
>> Empty control-flow statement Disposer.java line 66
>>
On Mon, 21 Nov 2022 20:42:51 GMT, John Hendrikx wrote:
>> many of those ^^ appear to be bugs.
>
> I didn't fix all problems, only the easy non-controversial ones. Things that
> might actually be bugs require more careful review and so are best saved for
> smaller PR's IMHO.
>
> This is alread
On Mon, 21 Nov 2022 16:57:30 GMT, Andy Goryachev wrote:
> One suggestion I'd like to make is to publish the Compiler Errors/Warnings
> configuration for Eclipse. I have a set of screenshots that produce a 0
> err/warn count with the current master. Eclipse also seem to provide a way to
> expor
On Mon, 21 Nov 2022 20:26:54 GMT, Andy Goryachev wrote:
>> Cool. My eclipse finds other places which do look like a bug - see
>> disposed:65
>> It is in the base - why isn't it this PR?
>
> full list
>
>
> Description ResourceLocation
> Empty control-flow statement DateCellBehavior
On Mon, 21 Nov 2022 20:25:06 GMT, Andy Goryachev wrote:
>> Yes, `potential programming problems / empty statement`. It can sometimes
>> point to a mistake where a semi colon is used just before a block.
>
> Cool. My eclipse finds other places which do look like a bug - see
> disposed:65
> It i
On Mon, 21 Nov 2022 19:53:59 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/property/IntegerPropertyBase.java
>> line 56:
>>
>>> 54:
>>> 55: private int value;
>>> 56: private ObservableIntegerValue observable = null;;
>>
>> is there an Eclipse warning for
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 19:58:31 GMT, John Hendrikx wrote:
>> This is in the test shims, so not public API.
>
> Shims are not public as far as I know.
you are right. I just looked at the package "package javafx.event;" and said
hmmm...
-
PR: https://git.openjdk.org/jfx/pull/957
Backport this a11y fix to jfx17u.
This is not a clean backport. The source code changes apply cleanly but there
was a conflict in test file.
The test `DialogTest.java` file does not exist in jfx17u source.
The file is now added but only with one test that was added as part of this fix
to mainline
On Mon, 21 Nov 2022 19:32:01 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line
>> 123:
>>
>>> 121:
>>> 122: if (weakReference.get() == null && counter < steps / 3) {
>>> 123: int percentageUsed = (steps - counter) / ste
On Mon, 21 Nov 2022 19:26:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/shims/java/javafx/event/EventTypeShim.java line 30:
>>
>>> 28: import java.util.List;
>>> 29:
>>> 30: public class EventTypeShim {
>>
>> this changes public API surface, does it not?
>
> This is in the test shi
On Mon, 21 Nov 2022 17:29:42 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be au
On Mon, 21 Nov 2022 17:20:43 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be au
On Mon, 21 Nov 2022 19:11:16 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be au
On Mon, 21 Nov 2022 17:35:08 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be au
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
Updated sqlite to v3.39.4
Verified build on windows, linux and mac.
Sanity testing looks fine.
-
Commit messages:
- Update Sqlite to v3.39.4
Changes: https://git.openjdk.org/jfx/pull/953/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=953&range=00
Issue: https://bugs.openj
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 15:19:24 GMT, Kevin Rushforth wrote:
> The main thing to be careful of is that we don't touch any public API
> signatures, since some of these sort of automated changes can have impact
> that we would need to consider.
This set of warnings doesn't change method signatures.
Oh, thanks, didn't knew that. I tried the JMOD files provided by Gloun
company with a local build. Works!
But how can this be integrated into an automatic/CI build? Using a more
or less arbitrary url pointing to a third-party website downloading a
zip file of unknown structure would result in
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
- Remove unsupported/unnecessary SuppressWarning annotations
- Remove reduntant type specifications (use diamond operator)
- Remove unused or duplicate imports
- Remove unnecessary casts (type is already correct type or can be autoboxed)
- Remove unnecessary semi-colons (at end of class definitions
68 matches
Mail list logo
