On Fri, 1 Sep 2023 14:31:49 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Better failure detection
>
> tests/system/src/test/java/test/javafx/embed/swing/SwingNodeContentMemoryLeakTest.j
On Thu, 7 Sep 2023 21:55:31 GMT, Kevin Rushforth wrote:
> Fix icu to compile with the latest VS 2022 compilers. Note that this fix is
> already present in the upstream ICU repo. See
> unicode-org/icu@c7e967c456ceff6436607ca2a3da034320ca34c3
>
> I've built this using the current compilers on al
On Tue, 5 Sep 2023 23:27:51 GMT, Michael Strauß wrote:
>> is it actually possible to have keys removed at runtime?
>
> The set of preferences that is reported by a platform is hard-coded in the
> native platform implementation, and depends on the operating system version.
> It might indeed be t
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
So far, I've identified these interfaces for the javafx.graphics module:
Visible:
Node, MenuItem, TableColumnBase
Disable:
Node, MenuItem, Tab
Disabled:
Node, Tab
(should MenuItem also have a "disabled" property? it doesn't currently)
Properties:
Window, Scene, Node, MenuItem, Tab, Toggle, Togg
I do something very similar in my own projects where I "decompose" my
entities into such interfaces. I find it beneficial.
We do need to figure out which makes sense and for what purpose.
On Wed, Sep 6, 2023, 22:41 Andy Goryachev wrote:
> I think this proposal makes a lot of sense.
>
>
>
> Havi
On Thu, 7 Sep 2023 22:42:57 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> l
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incrementa
On Tue, 22 Aug 2023 15:15:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
>> line 172:
>>
>>> 170: @Test
>>> 171: public void testMissingFinalMethods() {
>>> 172: for (Class c: allControlClasses()) {
>>
On Tue, 22 Aug 2023 15:34:17 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Thu, 7 Sep 2023 22:52:46 GMT, John Hendrikx wrote:
> I see at least two use cases:
>
> 1. When laying out an unsnapped container which contains snapped children.
> In order to get the available (snapped) space, we'd need to floor the
> unsnapped size.
Even if this is a valid use case (whi
On Thu, 7 Sep 2023 16:24:47 GMT, Andy Goryachev wrote:
> > Are you sure you'll be needing these methods for solving the table column
> > resizing issues?
>
> Se here is the rules the way I see it:
>
> * For snapping the **min** constraint, we should be using snapSize, since the
> expected res
On Sat, 2 Sep 2023 13:09:14 GMT, Marius Hanl wrote:
>> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
>> with different scales.
>> While not explicitly documented, this method will receive the snapped and
>> correctly calculated x, y, width and height values, so that
On Thu, 7 Sep 2023 16:41:23 GMT, Andy Goryachev wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
>> (using Math.floor), see for instance
>> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
>> methods Region.snapPortionX/Y().
>
> And
On Thu, 7 Sep 2023 00:51:11 GMT, John Hendrikx wrote:
> Are you sure you'll be needing these methods for solving the table column
> resizing issues? For dealing with space, there are already the snapSpace
> methods, which do rounding.
That's a good point. These methods might or might not be ne
Fix icu to compile with the latest VS 2022 compilers. Note that this fix is
already present in the upstream ICU repo. See
unicode-org/icu@c7e967c456ceff6436607ca2a3da034320ca34c3
I've built this using the current compilers on all three platforms, and on
Windows using VS 2022 17.6.5.
--
On Thu, 7 Sep 2023 21:55:31 GMT, Kevin Rushforth wrote:
> Fix icu to compile with the latest VS 2022 compilers. Note that this fix is
> already present in the upstream ICU repo. See
> unicode-org/icu@c7e967c456ceff6436607ca2a3da034320ca34c3
>
> I've built this using the current compilers on al
Snapping introduces differences between computed values and snapped values, so
we need to use non-zero tolerance when checking for equality. The maximum
tolerance is (1 / scale) - one display pixel scaled back to the local
coordinates.
The tests have been modified to use the scale-specific tol
> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
> (using Math.floor), see for instance
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
> methods Region.snapPortionX/Y().
Andy Goryachev has updated the pull request with a new target base
On Thu, 7 Sep 2023 16:16:06 GMT, Andy Goryachev wrote:
> the javadoc was lifted almost verbatim from snapPortionX/Y (I did not find
> the words "given scale" though).
That's an internal method, not API docs.
> Changing to be the same as snapSizeX/Y, although, technically speaking, that
> desc
On Thu, 7 Sep 2023 00:51:11 GMT, John Hendrikx wrote:
> Are you sure you'll be needing these methods for solving the table column
> resizing issues?
Se here is the rules the way I see it:
- For snapping the **min** constraint, we should be using snapSize, since the
expected result should be th
On Wed, 6 Sep 2023 23:29:35 GMT, Kevin Rushforth wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
>> (using Math.floor), see for instance
>> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
>> methods Region.snapPortionX/Y().
>
> mo
On Wed, 6 Sep 2023 23:10:11 GMT, Kevin Rushforth wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
>> (using Math.floor), see for instance
>> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
>> methods Region.snapPortionX/Y().
>
> mo
Out of 62 3D tests, 26 tests fail because of minute color differences in edge
pixels.
These tests are used to verify 3D rendering with different parameters like
translation, rotation.
So adding little color tolerance will not change the test behavior and allows
us to use these tests to automati
A few SceneGraphTests and ControlsTests/chart test classes are abstract classes
and serve as base classes for other tests.
They are excluded from test execution and hence result in avoiding false
failure reports.
-
Commit messages:
- 8315845 - exclude base class tests
Changes: htt
Currently only 18 out of 62 3D tests run properly in jfx-tests repo.
All the shape tests under "test/scenegraph/fx3d/shapes" and
"test/scenegraph/fx3d/subscene/shapes" fail because they are not able to find
image input they need.
Image files currently are at wrong place and they are moved to pro
26 matches
Mail list logo
