Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture [v2]

2023-11-10 Thread Nir Lisker
> Moves the filter setting of the samplers from the device parameters > configuration to the use-site, allowing for dynamic changes in the sampler. > This PR does internal plumbing work only to bring it close to the ES2 > pipeline. A followup PR will create the public API. > > Summary of the

Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture

2023-11-10 Thread Nir Lisker
On Thu, 9 Nov 2023 02:44:44 GMT, Michael Strauß wrote: >> Moves the filter setting of the samplers from the device parameters >> configuration to the use-site, allowing for dynamic changes in the sampler. >> This PR does internal plumbing work only to bring it close to the ES2 >> pipeline. A

Re: RFR: 8301302: Platform preferences API [v23]

2023-11-10 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v3]

2023-11-10 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: minor - Changes: - all: https://git.openjdk.org/jfx/pull/1274/files - new:

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v2]

2023-11-10 Thread brunesto
On Thu, 2 Nov 2023 11:55:46 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/robot/javafx/scene/DatePickerOnFocusLostTest.java >> line 98: >> >>> 96: // 3. Click on button to grab the focus and hence attempt to >>> datePicker.commitValue() >>> 97: // 4. Verify that in

Re: RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v2]

2023-11-10 Thread brunesto
> The fix prevents the DatePicker from losing focus if the date is not parsable. brunesto has updated the pull request incrementally with one additional commit since the last revision: replaced robot test by plain junit - Changes: - all:

Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture

2023-11-10 Thread Nir Lisker
On Thu, 9 Nov 2023 03:15:27 GMT, Michael Strauß wrote: >> Moves the filter setting of the samplers from the device parameters >> configuration to the use-site, allowing for dynamic changes in the sampler. >> This PR does internal plumbing work only to bring it close to the ES2 >> pipeline. A

Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture

2023-11-10 Thread Nir Lisker
On Thu, 9 Nov 2023 03:16:51 GMT, Michael Strauß wrote: >> Moves the filter setting of the samplers from the device parameters >> configuration to the use-site, allowing for dynamic changes in the sampler. >> This PR does internal plumbing work only to bring it close to the ES2 >> pipeline. A

Integrated: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used

2023-11-10 Thread Johan Vos
On Thu, 2 Nov 2023 11:39:47 GMT, Johan Vos wrote: > When the Java layer removes a systemmenu, release the native resources > related to this systemmenu. > This removes the strong JNI Global ref, which prevents its references from > being gc'ed. > > The current implementation for the

Re: RFR: 8303826: Add FX test for JDK-8252255

2023-11-10 Thread Kevin Rushforth
On Thu, 9 Nov 2023 03:43:48 GMT, Prasanta Sadhukhan wrote: > Manual regression test for 8252255: Blurry rendering of SwingNode with HiDPI > scaling in JavaFX is added I think this test only needs a single reviewer. - PR Comment:

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-10 Thread Kevin Rushforth
On Fri, 10 Nov 2023 09:58:21 GMT, Johan Vos wrote: >> tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 164: >> >>> 162: }); >>> 163: } >>> 164: Platform.runLater( () -> { >> >> Why is `Platform.runLater` needed here?

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v7]

2023-11-10 Thread Kevin Rushforth
On Fri, 10 Nov 2023 10:20:23 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: Wayland

2023-11-10 Thread Thiago Milczarek Sayão
Hi Johan, Robot will be a challenge. For mouse and keyboard simulation this could work: https://www.kernel.org/doc/html/v4.12/input/uinput.html of maybe: https://docs.flatpak.org/pt-br/latest/portal-api-reference.html#gdbus-org.freedesktop.portal.RemoteDesktop For screenshot:

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2023-11-10 Thread John Hendrikx
On Fri, 10 Nov 2023 10:34:08 GMT, Johan Vos wrote: > A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Should there be an updated test for this? I see a lot of raw type use

RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2023-11-10 Thread Johan Vos
A listener was added but never removed. This patch removes the listener when the menu it links to is cleared. Fix for https://bugs.openjdk.org/browse/JDK-8319779 - Commit messages: - A listener was added but never removed. Changes: https://git.openjdk.org/jfx/pull/1283/files

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v7]

2023-11-10 Thread Johan Vos
> When the Java layer removes a systemmenu, release the native resources > related to this systemmenu. > This removes the strong JNI Global ref, which prevents its references from > being gc'ed. > > The current implementation for the mac-specific system menu creates a menu, > but never

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v7]

2023-11-10 Thread Jose Pereda
On Fri, 10 Nov 2023 10:17:18 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-10 Thread Johan Vos
On Thu, 9 Nov 2023 22:07:34 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use only 10 cycles instead of 50 (preventing this test to take 50 seconds >> in case it fails). > >

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-10 Thread Johan Vos
On Thu, 9 Nov 2023 22:09:30 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use only 10 cycles instead of 50 (preventing this test to take 50 seconds >> in case it fails). > >

Re: Wayland

2023-11-10 Thread Johan Vos
Hi Thiago, Thanks for the work on Wayland. I spent some time on it in the past as well, and I'll hope to find some time to look at your work soon. The main worry I had in the past was how to deal with the robot, where we need to get pixels from the screen -- did you tackle that? - Johan On