Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
Another typo: In javafx.scene.Scene, all onDragDone methods and the property use "@{code Scene}" instead of "{@code Scene}". On Wed, May 10, 2017 at 7:25 PM, Kevin Rushforth wrote: > I just filed a new issue to catch any last minute typos: > >

Re: Corrections for Javadoc

2017-05-23 Thread Kevin Rushforth
Thanks. I'm a little surprised that doclint doesn't catch this one since it seems like it would be considered a malformed tag. As a note on timing, I plan to send out the webrev for this late this afternoon and push the changes on Thursday morning. -- Kevin Nir Lisker wrote: Another typo:

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
Yes, I saw that the due date on the report is the 24th. I don't know if it's worth anyone's time, but there are simple scripts that catch all sorts of spelling and grammar mistakes. Pretty sure it won't be that hard to integrate one.

Default PointLight for Scene

2017-05-23 Thread Nir Lisker
A Scene supplies a default PointLight if it contains a 3D object. However, adding a Light to any group in the scene removes the default light. Is it possible to retain the light, or get a reference to it from the scene?

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
Hopefully this makes it in time: javafx.scene.control.TreeView has wrong javadoc for the queryAccessibleAttribute method. The source code uses javadoc blocks as titles, but they should probably be regular comment blocks. One of those blocks has been read as the doc for the method because that

Re: Default PointLight for Scene

2017-05-23 Thread Nir Lisker
Yes, I was referring to that line in the docs. Wouldn't it be better to allow users to retain the default light? On Tue, May 23, 2017 at 10:05 PM, Chien Yang wrote: > No, this light is created internally within JavaFX as a convenient light > source if the scene doesn't

Re: Default PointLight for Scene

2017-05-23 Thread Kevin Rushforth
It might be convenient to have a boolean on the scene to indicate whether it should be retained, but we don't plan any improvements to 3D in JDK 10 (which would be the absolute earliest such a change could happen). It seems it would be just as easy for an application to add a white point light

Re: Default PointLight for Scene

2017-05-23 Thread Chien Yang
No, this light is created internally within JavaFX as a convenient light source if the scene doesn't have one. User can't access to it reference. You can find this information in the Scene class documentation: Class Scene ... A default headlight will be added to a scene that contains one or

[9] Review request: 8180338: Additional HTML5 cleanup

2017-05-23 Thread Kevin Rushforth
Hi Jon, Can you review this simple change to the three .html files (other than package.html) in the FX docs? https://bugs.openjdk.java.net/browse/JDK-8180338 http://cr.openjdk.java.net/~kcr/8180338/webrev.00/ Thanks. -- Kevin

[9] Review request: 8180070: Fix additional typos in API docs

2017-05-23 Thread Kevin Rushforth
Jonathan, Please review the following fixes to various typos in the javadoc-generated API docs: https://bugs.openjdk.java.net/browse/JDK-8180070 http://cr.openjdk.java.net/~kcr/8180070/webrev.00/ Thanks. -- Kevin