Re: [Approved] RFR: 8218640: Update ICU4C to version 64.2

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 13:25:54 GMT, Arun Joseph wrote: > We currently use ICU4C version 62.1. We should update to the latest stable > version 64.2. > http://site.icu-project.org/home > > > > Commits: > - b56b720e: 8218640: Update ICU4C to version 64.2 > > Changes:

Re: [Approved] RFR: 8218640: Update ICU4C to version 64.2

2019-10-09 Thread Guru Hb
On Wed, 9 Oct 2019 13:25:54 GMT, Arun Joseph wrote: > We currently use ICU4C version 62.1. We should update to the latest stable > version 64.2. > http://site.icu-project.org/home > > > > Commits: > - b56b720e: 8218640: Update ICU4C to version 64.2 > > Changes:

Re: [Approved] RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-09 Thread Johan Vos
On Mon, 7 Oct 2019 13:35:51 GMT, Dell Green <12861109+dellgr...@users.noreply.github.com> wrote: > buildSrc/crosslibs-armv6hf.sh pulls down debian and raspbian packages to be > able to cross compile javafx for arm hard float. Up to now the upstream > distribution versions have been debian and

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Johan Vos
On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: > JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) > > As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as not > building correctly with 5.6 or later). > > The existing JavaFX build uses

Problem of compilation of OpenJFX

2019-10-09 Thread Vincent MOLLIERE
Hello, I'm trying to build the latest version of OpenJFX on Windows and I have a compilation problem in JSLVisitor, it cannot find the import com.sun.scenario.effect.compiler.JSLBaseVisitor and neither do I. Where this file can be found/generated ? Thank you in advance for your help !

Question on Git History

2019-10-09 Thread Tom Schindl
Hi, I'm not sure I fully understand that hg => git translation but do we see the full history https://github.com/openjdk/jfx of files or just a partial version? If I eg look at https://github.com/openjdk/jfx/commits/master/modules/javafx.graphics/src/main/java/javafx/scene/Node.java I doubt this

Re: Problem of compilation of OpenJFX

2019-10-09 Thread Kevin Rushforth
This class is generated by antlr during the build: modules/javafx.graphics/build/gensrc/antlr/com/sun/scenario/effect/compiler/JSLBaseVisitor.java You  may be using an old 3.x version of anltlr, although the build should download the latest antlr4 for you. Make sure that you have a clean repo

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-09 Thread Hadzic Samir
On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg wrote: > On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > >> Allright, this is a fix for JDK-8207957 >> >> >> >> Commits: >> - 969ebb51: Fixing TableColumnHeaderTest >> - 9d379619: Removing Tablecolumnbasehelper

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Johan Vos
On Wed, 9 Oct 2019 12:24:29 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 07:50:44 GMT, Johan Vos wrote: > >> On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: >> >>> JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) >>> >>> As noted in the JBS bug, the

Re: RFR: 8218640: Update ICU4C to version 64.2

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 13:25:54 GMT, Arun Joseph wrote: > We currently use ICU4C version 62.1. We should update to the latest stable > version 64.2. > http://site.icu-project.org/home > > > > Commits: > - b56b720e: 8218640: Update ICU4C to version 64.2 > > Changes:

Re: Problem of compilation of OpenJFX

2019-10-09 Thread Vincent MOLLIERE
Thank you for you answer but its seems its using the 4.7.2. I pasted the java-compiler-args.txt of the command generating the files : -source 11 -target 11 -d D:\\Git\\jfx\\modules\\javafx.graphics\\build\\classes\\java\\jslc -nowarn -g:source,lines,vars -sourcepath "" -proc:none -s

Re: Question on Git History

2019-10-09 Thread Kevin Rushforth
inline On 10/9/2019 1:13 AM, Tom Schindl wrote: Hi, I'm not sure I fully understand that hg => git translation but do we see the full history https://github.com/openjdk/jfx of files or just a partial version? It's a full history, identical to the HG repo. If I eg look at

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 07:50:44 GMT, Johan Vos wrote: > On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: > >> JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) >> >> As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as >> not building

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-09 Thread Hadzic Samir
The pull request has been updated with additional changes. Added commits: - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for clarification on TableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

RFR: 8218640: Update ICU4C to version 64.2

2019-10-09 Thread Arun Joseph
We currently use ICU4C version 62.1. We should update to the latest stable version 64.2. http://site.icu-project.org/home Commits: - b56b720e: 8218640: Update ICU4C to version 64.2 Changes: https://git.openjdk.java.net/jfx/pull/10/files Webrev:

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 07:43:43 GMT, Dell Green <12861109+dellgr...@users.noreply.github.com> wrote: > On Tue, 8 Oct 2019 12:02:22 GMT, Kevin Rushforth wrote: > >> On Tue, 8 Oct 2019 11:59:52 GMT, Kevin Rushforth wrote: >> >>> On Tue, 8 Oct 2019 11:58:43 GMT, Kevin Rushforth wrote: >>> On

Re: RFR: 8230231: font-family not updated in HTMLEditor

2019-10-09 Thread Hadzic Samir
On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wrote: > >> Fix for https://github.com/javafxports/openjdk-jfx/issues/573 >> >> Issue on JDK bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 >> >> I tried to add a test but

RFR: 8230231: font-family not updated in HTMLEditor

2019-10-09 Thread Hadzic Samir
Fix for https://github.com/javafxports/openjdk-jfx/issues/573 Issue on JDK bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 I tried to add a test but I do not succeed at even running the existing Web tests.. I will need some help on that side.. Commits: -

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 16:10:28 GMT, Johan Vos wrote: > On Wed, 9 Oct 2019 15:18:58 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 07:43:43 GMT, Dell Green >> <12861109+dellgr...@users.noreply.github.com> wrote: >> >>> On Tue, 8 Oct 2019 12:02:22 GMT, Kevin Rushforth wrote: >>> On

Re: Problem of compilation of OpenJFX

2019-10-09 Thread Michael Ennen
Can you paste the full build log somewhere (not inline on the mailing list)? On Wed, Oct 9, 2019 at 7:02 AM Vincent MOLLIERE wrote: > Thank you for you answer but its seems its using the 4.7.2. I pasted the > java-compiler-args.txt of the command generating the files : > -source > 11 > -target

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: > On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg > wrote: > >> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: >> >>> Allright, this is a fix for JDK-8207957 >>> >>> >>> >>> Commits: >>> - 969ebb51: Fixing

Re: RFR: 8230231: font-family not updated in HTMLEditor

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wrote: > Fix for https://github.com/javafxports/openjdk-jfx/issues/573 > > Issue on JDK bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 > > I tried to add a test but I do not succeed at even running the existing Web > tests.. I

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-09 Thread Hadzic Samir
On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for > clarification on TableColumnHeader > > Changes: > - all:

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-09 Thread Nir Lisker
On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for > clarification on TableColumnHeader > > Changes: > - all:

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-09 Thread Johan Vos
On Wed, 9 Oct 2019 15:18:58 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 07:43:43 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> On Tue, 8 Oct 2019 12:02:22 GMT, Kevin Rushforth wrote: >> >>> On Tue, 8 Oct 2019 11:59:52 GMT, Kevin Rushforth wrote: >>>

Re: RFR: 8231870: CrossLibs script for armv6hf toolchain download fails

2019-10-09 Thread Johan Vos
On Wed, 9 Oct 2019 16:17:39 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:10:28 GMT, Johan Vos wrote: > >> On Wed, 9 Oct 2019 15:18:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 07:43:43 GMT, Dell Green >>> <12861109+dellgr...@users.noreply.github.com> wrote: >>> On

Re: [Rev 01] RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Kevin Rushforth
The pull request has been updated with additional changes. Added commits: - a928b41f: Revert ivy layout pattern changes per review comments Changes: - all: https://git.openjdk.java.net/jfx/pull/9/files - new: https://git.openjdk.java.net/jfx/pull/9/files/bc6bd441..a928b41f

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 12:38:09 GMT, Johan Vos wrote: > On Wed, 9 Oct 2019 12:24:29 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 07:50:44 GMT, Johan Vos wrote: >> >>> On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: >>> JBS issue:

Re: RFR: 8230231: font-family not updated in HTMLEditor

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir wrote: > On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wrote: >> >>> Fix for https://github.com/javafxports/openjdk-jfx/issues/573 >>> >>> Issue on JDK bug tracking :

Re: [Rev 01] RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Johan Vos
On Wed, 9 Oct 2019 17:16:10 GMT, Kevin Rushforth wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - a928b41f: Revert ivy layout pattern changes per review comments > > Changes: > - all: